From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops
Date: Wed, 16 May 2018 16:10:15 +0300 [thread overview]
Message-ID: <ed9879ef42a70d2609f60f73834cabb7e3df9e2f.camel@linux.intel.com> (raw)
In-Reply-To: <20180516104734.357oevogppu5bsg4@linutronix.de>
On Wed, 2018-05-16 at 12:47 +0200, Sebastian Andrzej Siewior wrote:
> On 2018-05-16 13:17:36 [+0300], Andy Shevchenko wrote:
> > > The output is usually short so there
> > > shouldn't be much benefit from using it.
> > > I remember Tony wanted runtime-pm on the kernel console, too. And
> > > he
> > > told me explicit how to test it so that it works. Once the UART
> > > goes
> > > into PM (down), the whole IP block can go into power save mode.
> > > The
> > > board can be woken up by sending a character via the UART. The
> > > first few
> > > (incoming / read) characters are lost until the IP block is up
> > > again the
> > > frequency stable. This is known / expected.
> >
> > Don't consider world the OMAP only. The things more complicated if
> > we
> > go out of it. Which I tried to explain in the commit message of
> > patch
> > 2.
>
> I am not saying the world is OMAP only. I just tried to explain how
> any
> why it got there and its purpose. I haven't NACKed it. I would believe
> that with that information and Tony not defending his use case or
> possible change it somehow so it is not standing in your way, Greg
> would
> have enough information to go your way.
Yes, I got it.
> But since I am on it. You have to enable runtime-PM for the UART. So
> what is the problem if you simply don't enable it for the UART which
> used as the kernel console?
How do I know at the ->probe() time that device in question is going to
be kernel console? Maybe I missed simple way of it.
> From reading the description of #2, my understanding is that you are
> afraid that enabling the UART (bringing it from power-down mode) might
> take too long because it requires (or might require) an ACPI function
> call. This brings me again to: why bother and enable it in the first
> place? Because this might not work from NMI context.
> From looking at #2. You remove put/get in console_write()
...which must be removed in any case...
> and avoid
> runtime PM by pm_runtime_get_noresume() and need the extra hook on
> console exit. I wasn't aware that you can remove the console at
> runtime
> (and assumed you have to stick to what said in console= at bootime).
> Because if that is the case, you could simply strip UART_CAP_RPM and
> then there is no more runtime-PM for you. Or is it too simple and I
> miss something here?
See above question. IIRC it's either too early or too late to decide on
per port basis.
>
> > > In order to achieve the same thing you would have to disable the
> > > kernel
> > > console on that UART. I leave this to Tony.
> >
> > Precisely the point of the series.
Besides above this would be needed _at least_ for several 8250 glue
drivers, so, I decide to go once for all.
>
> Sebastian
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-05-16 13:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 18:34 [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops Andy Shevchenko
2018-05-15 18:34 ` [PATCH v1 1/3] console: introduce ->exit() callback Andy Shevchenko
2018-05-15 18:34 ` [PATCH v1 2/3] serial: 8250_port: Don't use power management for kernel console Andy Shevchenko
2018-05-15 18:34 ` [PATCH v1 3/3] serial: 8250_port: Disable DMA operations " Andy Shevchenko
2018-05-16 10:55 ` Sebastian Andrzej Siewior
2018-05-16 12:58 ` Andy Shevchenko
2018-05-16 18:20 ` Sebastian Andrzej Siewior
2018-05-15 18:37 ` [PATCH v1 0/3] console, serial8250: Disable PM and DMA ops Andy Shevchenko
2018-05-16 10:08 ` Sebastian Andrzej Siewior
2018-05-16 10:17 ` Andy Shevchenko
2018-05-16 10:47 ` Sebastian Andrzej Siewior
2018-05-16 13:10 ` Andy Shevchenko [this message]
2018-05-17 13:56 ` Tony Lindgren
2018-05-17 16:38 ` Andy Shevchenko
2018-05-17 19:30 ` Tony Lindgren
2018-05-22 21:39 ` Andy Shevchenko
2018-05-23 17:58 ` Tony Lindgren
2018-05-23 18:32 ` Tony Lindgren
2018-07-18 15:14 ` Andy Shevchenko
2018-07-19 6:47 ` Tony Lindgren
2018-05-17 17:04 ` Tony Lindgren
2018-05-17 13:48 ` Tony Lindgren
2018-05-17 16:36 ` Andy Shevchenko
2018-05-17 19:48 ` Tony Lindgren
2018-05-22 21:52 ` Andy Shevchenko
2018-05-23 18:00 ` Tony Lindgren
2018-07-18 14:50 ` Andy Shevchenko
2018-07-19 6:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed9879ef42a70d2609f60f73834cabb7e3df9e2f.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).