* [linux-next:master 7522/8111] drivers/usb/dwc3/drd.c:443:19: sparse: symbol 'dwc3_get_extcon' was not declared. Should it be static?
@ 2018-05-17 16:06 kbuild test robot
2018-05-17 16:06 ` [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static kbuild test robot
0 siblings, 1 reply; 6+ messages in thread
From: kbuild test robot @ 2018-05-17 16:06 UTC (permalink / raw)
To: Andrzej Hajda
Cc: kbuild-all, Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: fbbe3b8c2c9c5f84caf668703c26154cb4fbb9d1
commit: 5f0b74e54890c354d6ac0124ea7a96adf22845d0 [7522/8111] USB: dwc3: get extcon device by OF graph bindings
reproduce:
# apt-get install sparse
git checkout 5f0b74e54890c354d6ac0124ea7a96adf22845d0
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/usb/dwc3/drd.c:443:19: sparse: symbol 'dwc3_get_extcon' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static
2018-05-17 16:06 [linux-next:master 7522/8111] drivers/usb/dwc3/drd.c:443:19: sparse: symbol 'dwc3_get_extcon' was not declared. Should it be static? kbuild test robot
@ 2018-05-17 16:06 ` kbuild test robot
2018-05-18 5:39 ` Andrzej Hajda
0 siblings, 1 reply; 6+ messages in thread
From: kbuild test robot @ 2018-05-17 16:06 UTC (permalink / raw)
To: Andrzej Hajda
Cc: kbuild-all, Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
drd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
index 2706824..218371f 100644
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -440,7 +440,7 @@ static int dwc3_drd_notifier(struct notifier_block *nb,
return NOTIFY_DONE;
}
-struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
+static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
{
struct device *dev = dwc->dev;
struct device_node *np_phy, *np_conn;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static
2018-05-17 16:06 ` [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static kbuild test robot
@ 2018-05-18 5:39 ` Andrzej Hajda
2018-05-18 7:38 ` Roger Quadros
0 siblings, 1 reply; 6+ messages in thread
From: Andrzej Hajda @ 2018-05-18 5:39 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all, Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
On 17.05.2018 18:06, kbuild test robot wrote:
> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings")
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
It should be static of course, my bad.
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
> drd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
> index 2706824..218371f 100644
> --- a/drivers/usb/dwc3/drd.c
> +++ b/drivers/usb/dwc3/drd.c
> @@ -440,7 +440,7 @@ static int dwc3_drd_notifier(struct notifier_block *nb,
> return NOTIFY_DONE;
> }
>
> -struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
> +static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
> {
> struct device *dev = dwc->dev;
> struct device_node *np_phy, *np_conn;
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static
2018-05-18 5:39 ` Andrzej Hajda
@ 2018-05-18 7:38 ` Roger Quadros
2018-05-18 7:47 ` Andrzej Hajda
0 siblings, 1 reply; 6+ messages in thread
From: Roger Quadros @ 2018-05-18 7:38 UTC (permalink / raw)
To: Andrzej Hajda, kbuild test robot
Cc: kbuild-all, Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
On 18/05/18 08:39, Andrzej Hajda wrote:
> On 17.05.2018 18:06, kbuild test robot wrote:
>> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings")
>> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
>
> It should be static of course, my bad.
>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
I don't think we accept patches from robots, yet :)
>
> --
> Regards
> Andrzej
>
>> ---
>> drd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
>> index 2706824..218371f 100644
>> --- a/drivers/usb/dwc3/drd.c
>> +++ b/drivers/usb/dwc3/drd.c
>> @@ -440,7 +440,7 @@ static int dwc3_drd_notifier(struct notifier_block *nb,
>> return NOTIFY_DONE;
>> }
>>
>> -struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>> +static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>> {
>> struct device *dev = dwc->dev;
>> struct device_node *np_phy, *np_conn;
>>
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static
2018-05-18 7:38 ` Roger Quadros
@ 2018-05-18 7:47 ` Andrzej Hajda
2018-05-18 7:58 ` Roger Quadros
0 siblings, 1 reply; 6+ messages in thread
From: Andrzej Hajda @ 2018-05-18 7:47 UTC (permalink / raw)
To: Roger Quadros, kbuild test robot
Cc: kbuild-all, Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
On 18.05.2018 09:38, Roger Quadros wrote:
> On 18/05/18 08:39, Andrzej Hajda wrote:
>> On 17.05.2018 18:06, kbuild test robot wrote:
>>> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings")
>>> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
>> It should be static of course, my bad.
>>
>> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
> I don't think we accept patches from robots, yet :)
What do you mean by 'we'? In case of whole kernel it is not true:
$ git log --author='kbuild test robot <fengguang.wu@intel.com>'
--oneline | wc -l
183
Regards
Andrzej
>
>> --
>> Regards
>> Andrzej
>>
>>> ---
>>> drd.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
>>> index 2706824..218371f 100644
>>> --- a/drivers/usb/dwc3/drd.c
>>> +++ b/drivers/usb/dwc3/drd.c
>>> @@ -440,7 +440,7 @@ static int dwc3_drd_notifier(struct notifier_block *nb,
>>> return NOTIFY_DONE;
>>> }
>>>
>>> -struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>>> +static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>>> {
>>> struct device *dev = dwc->dev;
>>> struct device_node *np_phy, *np_conn;
>>>
>>>
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static
2018-05-18 7:47 ` Andrzej Hajda
@ 2018-05-18 7:58 ` Roger Quadros
0 siblings, 0 replies; 6+ messages in thread
From: Roger Quadros @ 2018-05-18 7:58 UTC (permalink / raw)
To: Andrzej Hajda, kbuild test robot
Cc: kbuild-all, Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
On 18/05/18 10:47, Andrzej Hajda wrote:
> On 18.05.2018 09:38, Roger Quadros wrote:
>> On 18/05/18 08:39, Andrzej Hajda wrote:
>>> On 17.05.2018 18:06, kbuild test robot wrote:
>>>> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings")
>>>> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
>>> It should be static of course, my bad.
>>>
>>> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
>> I don't think we accept patches from robots, yet :)
>
> What do you mean by 'we'? In case of whole kernel it is not true:
>
> $ git log --author='kbuild test robot <fengguang.wu@intel.com>'
> --oneline | wc -l
> 183
OK, then I'm wrong. Should have checked before commenting. Sorry about that.
>
> Regards
> Andrzej
>
>>
>>> --
>>> Regards
>>> Andrzej
>>>
>>>> ---
>>>> drd.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
>>>> index 2706824..218371f 100644
>>>> --- a/drivers/usb/dwc3/drd.c
>>>> +++ b/drivers/usb/dwc3/drd.c
>>>> @@ -440,7 +440,7 @@ static int dwc3_drd_notifier(struct notifier_block *nb,
>>>> return NOTIFY_DONE;
>>>> }
>>>>
>>>> -struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>>>> +static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>>>> {
>>>> struct device *dev = dwc->dev;
>>>> struct device_node *np_phy, *np_conn;
>>>>
>>>>
>>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-18 7:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-17 16:06 [linux-next:master 7522/8111] drivers/usb/dwc3/drd.c:443:19: sparse: symbol 'dwc3_get_extcon' was not declared. Should it be static? kbuild test robot
2018-05-17 16:06 ` [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static kbuild test robot
2018-05-18 5:39 ` Andrzej Hajda
2018-05-18 7:38 ` Roger Quadros
2018-05-18 7:47 ` Andrzej Hajda
2018-05-18 7:58 ` Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).