From: Matthew Wilcox <willy@infradead.org>
To: Roman Kagan <rkagan@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] idr: fix invalid ptr dereference on item delete
Date: Fri, 18 May 2018 17:31:04 -0700 [thread overview]
Message-ID: <20180519003104.GB21615@bombadil.infradead.org> (raw)
In-Reply-To: <20180518202307.GB753@rkaganb.sw.ru>
On Fri, May 18, 2018 at 11:23:08PM +0300, Roman Kagan wrote:
> On Fri, May 18, 2018 at 10:50:25AM -0700, Matthew Wilcox wrote:
> > It'd be nice if you cc'd the person who wrote the code you're patching.
> > You'd get a response a lot quicker than waiting until I happened to
> > notice the email in a different forum.
>
> I sent it to someone called "Matthew Wilcox <mawilcox@microsoft.com>".
> Also I cc'd that guy when I only started to point the finger at IDR as
> the suspected culprit in that syzcaller report. I thought it was him
> who wrote the code...
I didn't get them ;-( Sorry.
> > Thanks for finding the situation that leads to the bug. Your fix is
> > incorrect; it's legitimate to store a NULL value at offset 0, and
> > your patch makes it impossible to delete. Fortunately, the test-suite
> > covers that case ;-)
>
> How do you build it? I wish I had it when debugging but I got linking
> errors due to missing spin_lock_init, so I decided it wasn't up-to-date.
Yeah, I inadvertently broke it with commit
f6bb2a2c0b81 ("xarray: add the xa_lock to the radix_tree_root")
Andrew has a patch to fix it in his tree. All you need is:
+++ b/tools/include/linux/spinlock.h
@@ -8,6 +8,7 @@
#define spinlock_t pthread_mutex_t
#define DEFINE_SPINLOCK(x) pthread_mutex_t x = PTHREAD_MUTEX_INITIALIZER;
#define __SPIN_LOCK_UNLOCKED(x) (pthread_mutex_t)PTHREAD_MUTEX_INITIALIZ
ER
+#define spin_lock_init(x) pthread_mutex_init(x, NULL);
#define spin_lock_irqsave(x, f) (void)f, pthread_mutex_lock(x)
#define spin_unlock_irqrestore(x, f) (void)f, pthread_mutex_unlock(x)
> Thanks,
> Roman.
>
> P.S. I'll forward your message to all the recepients of my patch, to let
> them know it's wrong and you have a better one.
Thanks!
next prev parent reply other threads:[~2018-05-19 0:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 17:50 [PATCH] idr: fix invalid ptr dereference on item delete Matthew Wilcox
2018-05-18 20:23 ` Roman Kagan
2018-05-19 0:31 ` Matthew Wilcox [this message]
2018-05-18 22:31 ` Andrew Morton
2018-05-19 0:28 ` Matthew Wilcox
2018-05-19 6:26 ` Roman Kagan
2018-05-19 14:14 ` Matthew Wilcox
2018-05-21 19:13 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2018-05-10 19:16 Roman Kagan
2018-05-10 23:54 ` Paolo Bonzini
2018-05-11 5:40 ` Dmitry Vyukov
2018-05-11 5:57 ` Roman Kagan
2018-05-11 9:12 ` Paolo Bonzini
2018-05-18 20:29 ` Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180519003104.GB21615@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).