* [PATCH 2/5] staging: lustre: Fix block comments style
@ 2018-05-16 18:27 Sabin Mihai Rapan
2018-05-20 12:44 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Sabin Mihai Rapan @ 2018-05-16 18:27 UTC (permalink / raw)
To: gregkh, jsimmons, andreas.dilger, oleg.drokin, lustre-devel
Cc: kernel-janitors, linux-kernel, Sabin Mihai Rapan
This patch fixes the checkpatch.pl warning:
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
Signed-off-by: Sabin Mihai Rapan <sabin.rapan@gmail.com>
---
.../staging/lustre/include/uapi/linux/lustre/lustre_idl.h | 6 ++++--
.../staging/lustre/include/uapi/linux/lustre/lustre_user.h | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
index e6016a71ad23..f13138972be2 100644
--- a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
+++ b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
@@ -1526,9 +1526,11 @@ struct mdt_rec_setattr {
#define MDS_OPEN_HAS_OBJS 020000000000 /* Just set the EA the obj exist */
#define MDS_OPEN_NORESTORE 0100000000000ULL /* Do not restore file at open */
#define MDS_OPEN_NEWSTRIPE 0200000000000ULL /* New stripe needed (restripe or
- * hsm restore) */
+ * hsm restore)
+ */
#define MDS_OPEN_VOLATILE 0400000000000ULL /* File is volatile = created
- unlinked */
+ * unlinked
+ */
#define MDS_OPEN_LEASE 01000000000000ULL /* Open the file and grant lease
* delegation, succeed if it's not
* being opened with conflict mode.
diff --git a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_user.h b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_user.h
index 2fcfe2b2d365..f0fbe3318db6 100644
--- a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_user.h
+++ b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_user.h
@@ -405,7 +405,8 @@ static inline __u32 lov_user_md_size(__u16 stripes, __u32 lmm_magic)
/* Compile with -D_LARGEFILE64_SOURCE or -D_GNU_SOURCE (or #define) to
* use this. It is unsafe to #define those values in this header as it
- * is possible the application has already #included <sys/stat.h>. */
+ * is possible the application has already #included <sys/stat.h>.
+ */
#ifdef HAVE_LOV_USER_MDS_DATA
#define lov_user_mds_data lov_user_mds_data_v1
struct lov_user_mds_data_v1 {
@@ -468,7 +469,8 @@ struct ll_fid {
__u64 id; /* holds object id */
__u32 generation; /* holds object generation */
__u32 f_type; /* holds object type or stripe idx when passing it to
- * OST for saving into EA. */
+ * OST for saving into EA.
+ */
};
#define UUID_MAX 40
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/5] staging: lustre: Fix block comments style
2018-05-16 18:27 [PATCH 2/5] staging: lustre: Fix block comments style Sabin Mihai Rapan
@ 2018-05-20 12:44 ` Greg KH
2018-05-21 17:34 ` [PATCH 1/4] staging: lustre: Fix "from from"->"from" Sabin Mihai Rapan
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Greg KH @ 2018-05-20 12:44 UTC (permalink / raw)
To: Sabin Mihai Rapan
Cc: jsimmons, andreas.dilger, oleg.drokin, lustre-devel,
kernel-janitors, linux-kernel
On Wed, May 16, 2018 at 08:27:07PM +0200, Sabin Mihai Rapan wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
>
> Signed-off-by: Sabin Mihai Rapan <sabin.rapan@gmail.com>
> ---
> .../staging/lustre/include/uapi/linux/lustre/lustre_idl.h | 6 ++++--
> .../staging/lustre/include/uapi/linux/lustre/lustre_user.h | 6 ++++--
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
> index e6016a71ad23..f13138972be2 100644
> --- a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
> +++ b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
> @@ -1526,9 +1526,11 @@ struct mdt_rec_setattr {
> #define MDS_OPEN_HAS_OBJS 020000000000 /* Just set the EA the obj exist */
> #define MDS_OPEN_NORESTORE 0100000000000ULL /* Do not restore file at open */
> #define MDS_OPEN_NEWSTRIPE 0200000000000ULL /* New stripe needed (restripe or
> - * hsm restore) */
> + * hsm restore)
> + */
> #define MDS_OPEN_VOLATILE 0400000000000ULL /* File is volatile = created
> - unlinked */
> + * unlinked
> + */
Always run checkpatch.pl on your patches so you do not get grumpy
maintainers telling you to run checkpatch.pl on your patches :)
Also, do not create a patch to fix up a checkpatch warning, only to have
it add another one, unless you want to have an eternal number of changes
to make over time...
Please fix up and resend the whole series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] staging: lustre: Fix "from from"->"from"
2018-05-20 12:44 ` Greg KH
@ 2018-05-21 17:34 ` Sabin Mihai Rapan
2018-05-21 17:34 ` [PATCH 2/4] staging: lustre: Fix "Possible intergrate"->"Possibly integrate" Sabin Mihai Rapan
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Sabin Mihai Rapan @ 2018-05-21 17:34 UTC (permalink / raw)
To: gregkh, jsimmons, andreas.dilger, oleg.drokin
Cc: kernel-janitors, linux-kernel, Sabin Mihai Rapan
Trivial fix to spelling mistake in README.txt
Signed-off-by: Sabin Mihai Rapan <sabin.rapan@gmail.com>
---
drivers/staging/lustre/README.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/README.txt b/drivers/staging/lustre/README.txt
index 0676243eea9e..783959240490 100644
--- a/drivers/staging/lustre/README.txt
+++ b/drivers/staging/lustre/README.txt
@@ -4,7 +4,7 @@ Lustre Parallel Filesystem Client
The Lustre file system is an open-source, parallel file system
that supports many requirements of leadership class HPC simulation
environments.
-Born from from a research project at Carnegie Mellon University,
+Born from a research project at Carnegie Mellon University,
the Lustre file system is a widely-used option in HPC.
The Lustre file system provides a POSIX compliant file system interface,
can scale to thousands of clients, petabytes of storage and
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4] staging: lustre: Fix "Possible intergrate"->"Possibly integrate"
2018-05-20 12:44 ` Greg KH
2018-05-21 17:34 ` [PATCH 1/4] staging: lustre: Fix "from from"->"from" Sabin Mihai Rapan
@ 2018-05-21 17:34 ` Sabin Mihai Rapan
2018-05-21 17:34 ` [PATCH 3/4] staging: lustre: Fix "unsigned"->"unsigned int" Sabin Mihai Rapan
2018-05-21 17:34 ` [PATCH v2 4/4] staging: lustre: Fix block comments style Sabin Mihai Rapan
3 siblings, 0 replies; 6+ messages in thread
From: Sabin Mihai Rapan @ 2018-05-21 17:34 UTC (permalink / raw)
To: gregkh, jsimmons, andreas.dilger, oleg.drokin
Cc: kernel-janitors, linux-kernel, Sabin Mihai Rapan
Trivial fix to spelling mistake in TODO file.
Signed-off-by: Sabin Mihai Rapan <sabin.rapan@gmail.com>
---
drivers/staging/lustre/TODO | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/TODO b/drivers/staging/lustre/TODO
index 94446487748a..5332cdb19bfa 100644
--- a/drivers/staging/lustre/TODO
+++ b/drivers/staging/lustre/TODO
@@ -12,7 +12,7 @@ addressed:
* https://jira.hpdd.intel.com/browse/LU-9859
*
* Track all the cleanups and simplification of the libcfs module. Remove
-* functions the kernel provides. Possible intergrate some of the functionality
+* functions the kernel provides. Possibly integrate some of the functionality
* into the kernel proper.
*
******************************************************************************
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] staging: lustre: Fix "unsigned"->"unsigned int"
2018-05-20 12:44 ` Greg KH
2018-05-21 17:34 ` [PATCH 1/4] staging: lustre: Fix "from from"->"from" Sabin Mihai Rapan
2018-05-21 17:34 ` [PATCH 2/4] staging: lustre: Fix "Possible intergrate"->"Possibly integrate" Sabin Mihai Rapan
@ 2018-05-21 17:34 ` Sabin Mihai Rapan
2018-05-21 17:34 ` [PATCH v2 4/4] staging: lustre: Fix block comments style Sabin Mihai Rapan
3 siblings, 0 replies; 6+ messages in thread
From: Sabin Mihai Rapan @ 2018-05-21 17:34 UTC (permalink / raw)
To: gregkh, jsimmons, andreas.dilger, oleg.drokin
Cc: kernel-janitors, linux-kernel, Sabin Mihai Rapan
This patch fixes the checkpatch.pl warning:
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Sabin Mihai Rapan <sabin.rapan@gmail.com>
---
.../staging/lustre/include/uapi/linux/lustre/lustre_fiemap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_fiemap.h b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_fiemap.h
index f5214dc33c60..d375a476f5ea 100644
--- a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_fiemap.h
+++ b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_fiemap.h
@@ -51,7 +51,7 @@ static inline size_t fiemap_count_to_size(size_t extent_count)
sizeof(struct fiemap_extent);
}
-static inline unsigned fiemap_size_to_count(size_t array_size)
+static inline unsigned int fiemap_size_to_count(size_t array_size)
{
return (array_size - sizeof(struct fiemap)) /
sizeof(struct fiemap_extent);
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 4/4] staging: lustre: Fix block comments style
2018-05-20 12:44 ` Greg KH
` (2 preceding siblings ...)
2018-05-21 17:34 ` [PATCH 3/4] staging: lustre: Fix "unsigned"->"unsigned int" Sabin Mihai Rapan
@ 2018-05-21 17:34 ` Sabin Mihai Rapan
3 siblings, 0 replies; 6+ messages in thread
From: Sabin Mihai Rapan @ 2018-05-21 17:34 UTC (permalink / raw)
To: gregkh, jsimmons, andreas.dilger, oleg.drokin
Cc: kernel-janitors, linux-kernel, Sabin Mihai Rapan
This patch fixes the checkpatch.pl warning:
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
Signed-off-by: Sabin Mihai Rapan <sabin.rapan@gmail.com>
---
Changes in v2:
- Removed trailing whitespace at lustre_idl.h:1532.
.../staging/lustre/include/uapi/linux/lustre/lustre_idl.h | 6 ++++--
.../staging/lustre/include/uapi/linux/lustre/lustre_user.h | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
index aac98dbcf6e3..8a7301a76122 100644
--- a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
+++ b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
@@ -1526,9 +1526,11 @@ struct mdt_rec_setattr {
#define MDS_OPEN_HAS_OBJS 020000000000 /* Just set the EA the obj exist */
#define MDS_OPEN_NORESTORE 0100000000000ULL /* Do not restore file at open */
#define MDS_OPEN_NEWSTRIPE 0200000000000ULL /* New stripe needed (restripe or
- * hsm restore) */
+ * hsm restore)
+ */
#define MDS_OPEN_VOLATILE 0400000000000ULL /* File is volatile = created
- unlinked */
+ * unlinked
+ */
#define MDS_OPEN_LEASE 01000000000000ULL /* Open the file and grant lease
* delegation, succeed if it's not
* being opened with conflict mode.
diff --git a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_user.h b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_user.h
index 5e332e3af68a..69387f36d1f1 100644
--- a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_user.h
+++ b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_user.h
@@ -405,7 +405,8 @@ static inline __u32 lov_user_md_size(__u16 stripes, __u32 lmm_magic)
/* Compile with -D_LARGEFILE64_SOURCE or -D_GNU_SOURCE (or #define) to
* use this. It is unsafe to #define those values in this header as it
- * is possible the application has already #included <sys/stat.h>. */
+ * is possible the application has already #included <sys/stat.h>.
+ */
#ifdef HAVE_LOV_USER_MDS_DATA
#define lov_user_mds_data lov_user_mds_data_v1
struct lov_user_mds_data_v1 {
@@ -468,7 +469,8 @@ struct ll_fid {
__u64 id; /* holds object id */
__u32 generation; /* holds object generation */
__u32 f_type; /* holds object type or stripe idx when passing it to
- * OST for saving into EA. */
+ * OST for saving into EA.
+ */
};
#define UUID_MAX 40
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-21 17:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 18:27 [PATCH 2/5] staging: lustre: Fix block comments style Sabin Mihai Rapan
2018-05-20 12:44 ` Greg KH
2018-05-21 17:34 ` [PATCH 1/4] staging: lustre: Fix "from from"->"from" Sabin Mihai Rapan
2018-05-21 17:34 ` [PATCH 2/4] staging: lustre: Fix "Possible intergrate"->"Possibly integrate" Sabin Mihai Rapan
2018-05-21 17:34 ` [PATCH 3/4] staging: lustre: Fix "unsigned"->"unsigned int" Sabin Mihai Rapan
2018-05-21 17:34 ` [PATCH v2 4/4] staging: lustre: Fix block comments style Sabin Mihai Rapan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).