linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 7/9] clk: bd71837: Build ROHM BD71837 PMIC clock driver
@ 2018-05-24  5:59 Matti Vaittinen
  2018-05-27  8:28 ` kbuild test robot
  2018-05-27  8:28 ` [PATCH] clk: bd71837: fix platform_no_drv_owner.cocci warnings kbuild test robot
  0 siblings, 2 replies; 3+ messages in thread
From: Matti Vaittinen @ 2018-05-24  5:59 UTC (permalink / raw)
  To: mturquette, sboyd, robh+dt, mark.rutland, lee.jones, lgirdwood,
	broonie, mazziesaccount
  Cc: linux-clk, devicetree, linux-kernel, mikko.mutanen, heikki.haikola

Configuration options and Makefile for BD71837 clock driver

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
 drivers/clk/Kconfig  | 9 +++++++++
 drivers/clk/Makefile | 1 +
 2 files changed, 10 insertions(+)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 41492e980ef4..4b045699bb5e 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -279,6 +279,15 @@ config COMMON_CLK_STM32H7
 	---help---
 	  Support for stm32h7 SoC family clocks
 
+config COMMON_CLK_BD71837
+	tristate "Clock driver for ROHM BD71837 PMIC MFD"
+	depends on MFD_BD71837
+	depends on I2C=y
+	depends on OF
+	help
+	  This driver supports ROHM BD71837 PMIC clock.
+
+
 source "drivers/clk/bcm/Kconfig"
 source "drivers/clk/hisilicon/Kconfig"
 source "drivers/clk/imgtec/Kconfig"
diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
index de6d06ac790b..8393c4af7d5a 100644
--- a/drivers/clk/Makefile
+++ b/drivers/clk/Makefile
@@ -21,6 +21,7 @@ endif
 obj-$(CONFIG_MACH_ASM9260)		+= clk-asm9260.o
 obj-$(CONFIG_COMMON_CLK_AXI_CLKGEN)	+= clk-axi-clkgen.o
 obj-$(CONFIG_ARCH_AXXIA)		+= clk-axm5516.o
+obj-$(CONFIG_COMMON_CLK_BD71837)	+= clk-bd71837.o
 obj-$(CONFIG_COMMON_CLK_CDCE706)	+= clk-cdce706.o
 obj-$(CONFIG_COMMON_CLK_CDCE925)	+= clk-cdce925.o
 obj-$(CONFIG_ARCH_CLPS711X)		+= clk-clps711x.o
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 7/9] clk: bd71837: Build ROHM BD71837 PMIC clock driver
  2018-05-24  5:59 [PATCH 7/9] clk: bd71837: Build ROHM BD71837 PMIC clock driver Matti Vaittinen
@ 2018-05-27  8:28 ` kbuild test robot
  2018-05-27  8:28 ` [PATCH] clk: bd71837: fix platform_no_drv_owner.cocci warnings kbuild test robot
  1 sibling, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2018-05-27  8:28 UTC (permalink / raw)
  To: Matti Vaittinen
  Cc: kbuild-all, mturquette, sboyd, robh+dt, mark.rutland, lee.jones,
	lgirdwood, broonie, mazziesaccount, linux-clk, devicetree,
	linux-kernel, mikko.mutanen, heikki.haikola

Hi Matti,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on ljones-mfd/for-mfd-next]
[also build test WARNING on v4.17-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Matti-Vaittinen/mfd-regulator-clk-bd71837-ROHM-BD71837-PMIC-driver/20180526-192351
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next


coccinelle warnings: (new ones prefixed by >>)

>> drivers/clk/clk-bd71837.c:145:6-11: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] clk: bd71837: fix platform_no_drv_owner.cocci warnings
  2018-05-24  5:59 [PATCH 7/9] clk: bd71837: Build ROHM BD71837 PMIC clock driver Matti Vaittinen
  2018-05-27  8:28 ` kbuild test robot
@ 2018-05-27  8:28 ` kbuild test robot
  1 sibling, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2018-05-27  8:28 UTC (permalink / raw)
  To: Matti Vaittinen
  Cc: kbuild-all, mturquette, sboyd, robh+dt, mark.rutland, lee.jones,
	lgirdwood, broonie, mazziesaccount, linux-clk, devicetree,
	linux-kernel, mikko.mutanen, heikki.haikola

From: kbuild test robot <fengguang.wu@intel.com>

drivers/clk/clk-bd71837.c:145:6-11: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 0e03c7b6a3c7 ("clk: bd71837: Build ROHM BD71837 PMIC clock driver")
CC: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---

 clk-bd71837.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/clk/clk-bd71837.c
+++ b/drivers/clk/clk-bd71837.c
@@ -142,7 +142,6 @@ static int bd71837_clk_remove(struct pla
 static struct platform_driver bd71837_clk = {
 	.driver = {
 		   .name = "bd71837-clk",
-		   .owner = THIS_MODULE,
 		   },
 	.probe = bd71837_clk_probe,
 	.remove = bd71837_clk_remove,

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-27  8:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-24  5:59 [PATCH 7/9] clk: bd71837: Build ROHM BD71837 PMIC clock driver Matti Vaittinen
2018-05-27  8:28 ` kbuild test robot
2018-05-27  8:28 ` [PATCH] clk: bd71837: fix platform_no_drv_owner.cocci warnings kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).