From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
dmaengine@vger.kernel.org, linux-media@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org,
netdev@vger.kernel.org, alsa-devel@alsa-project.org
Subject: [PATCH v2 11/13] dmaengine: pxa: make the filter function internal
Date: Thu, 24 May 2018 09:07:01 +0200 [thread overview]
Message-ID: <20180524070703.11901-12-robert.jarzmik@free.fr> (raw)
In-Reply-To: <20180524070703.11901-1-robert.jarzmik@free.fr>
As the pxa architecture and all its related drivers do not rely anymore
on the filter function, thanks to the slave map conversion, make
pxad_filter_fn() static, and remove it from the global namespace.
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
drivers/dma/pxa_dma.c | 5 ++---
include/linux/dma/pxa-dma.h | 11 -----------
2 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c
index 9505334f9c6e..a332ad1d7dfb 100644
--- a/drivers/dma/pxa_dma.c
+++ b/drivers/dma/pxa_dma.c
@@ -179,7 +179,7 @@ static unsigned int pxad_drcmr(unsigned int line)
return 0x1000 + line * 4;
}
-bool pxad_filter_fn(struct dma_chan *chan, void *param);
+static bool pxad_filter_fn(struct dma_chan *chan, void *param);
/*
* Debug fs
@@ -1496,7 +1496,7 @@ static struct platform_driver pxad_driver = {
.remove = pxad_remove,
};
-bool pxad_filter_fn(struct dma_chan *chan, void *param)
+static bool pxad_filter_fn(struct dma_chan *chan, void *param)
{
struct pxad_chan *c = to_pxad_chan(chan);
struct pxad_param *p = param;
@@ -1509,7 +1509,6 @@ bool pxad_filter_fn(struct dma_chan *chan, void *param)
return true;
}
-EXPORT_SYMBOL_GPL(pxad_filter_fn);
module_platform_driver(pxad_driver);
diff --git a/include/linux/dma/pxa-dma.h b/include/linux/dma/pxa-dma.h
index 9fc594f69eff..fceb5df07097 100644
--- a/include/linux/dma/pxa-dma.h
+++ b/include/linux/dma/pxa-dma.h
@@ -23,15 +23,4 @@ struct pxad_param {
enum pxad_chan_prio prio;
};
-struct dma_chan;
-
-#ifdef CONFIG_PXA_DMA
-bool pxad_filter_fn(struct dma_chan *chan, void *param);
-#else
-static inline bool pxad_filter_fn(struct dma_chan *chan, void *param)
-{
- return false;
-}
-#endif
-
#endif /* _PXA_DMA_H_ */
--
2.11.0
next prev parent reply other threads:[~2018-05-24 7:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 7:06 [PATCH v2 00/13] ARM: pxa: switch to DMA slave maps Robert Jarzmik
2018-05-24 7:06 ` [PATCH v2 01/13] dmaengine: pxa: use a dma slave map Robert Jarzmik
2018-06-25 13:15 ` Applied "dmaengine: pxa: use a dma slave map" to the asoc tree Mark Brown
2018-05-24 7:06 ` [PATCH v2 02/13] ARM: pxa: add dma slave map Robert Jarzmik
2018-05-24 18:11 ` Robert Jarzmik
2018-05-24 7:06 ` [PATCH v2 03/13] mmc: pxamci: remove the dmaengine compat need Robert Jarzmik
2018-06-25 13:15 ` Applied "mmc: pxamci: remove the dmaengine compat need" to the asoc tree Mark Brown
2018-05-24 7:06 ` [PATCH v2 04/13] media: pxa_camera: remove the dmaengine compat need Robert Jarzmik
2018-06-25 13:15 ` Applied "media: pxa_camera: remove the dmaengine compat need" to the asoc tree Mark Brown
2018-05-24 7:06 ` [PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need Robert Jarzmik
2018-05-24 9:30 ` Miquel Raynal
2018-05-24 18:07 ` Robert Jarzmik
2018-05-25 6:56 ` Miquel Raynal
2018-05-24 7:06 ` [PATCH v2 06/13] net: smc911x: " Robert Jarzmik
2018-05-24 7:06 ` [PATCH v2 07/13] net: smc91x: " Robert Jarzmik
2018-05-24 7:06 ` [PATCH v2 08/13] ASoC: pxa: " Robert Jarzmik
2018-05-24 13:58 ` Mark Brown
2018-05-25 8:35 ` Daniel Mack
2018-06-29 11:07 ` Applied "ASoC: pxa: remove the dmaengine compat need" to the asoc tree Mark Brown
2018-05-24 7:06 ` [PATCH v2 09/13] ata: pata_pxa: remove the dmaengine compat need Robert Jarzmik
2018-06-25 13:15 ` Applied "ata: pata_pxa: remove the dmaengine compat need" to the asoc tree Mark Brown
2018-05-24 7:07 ` [PATCH v2 10/13] dmaengine: pxa: document pxad_param Robert Jarzmik
2018-05-25 10:59 ` Vinod
2018-06-25 13:15 ` Applied "dmaengine: pxa: document pxad_param" to the asoc tree Mark Brown
2018-05-24 7:07 ` Robert Jarzmik [this message]
2018-05-25 10:59 ` [PATCH v2 11/13] dmaengine: pxa: make the filter function internal Vinod
2018-05-24 7:07 ` [PATCH v2 12/13] ARM: pxa: remove the DMA IO resources Robert Jarzmik
2018-06-25 13:15 ` Applied "ARM: pxa: remove the DMA IO resources" to the asoc tree Mark Brown
2018-05-24 7:07 ` [PATCH v2 13/13] ARM: pxa: change SSP DMA channels allocation Robert Jarzmik
2018-05-25 7:56 ` Daniel Mack
2018-06-25 13:15 ` Applied "ARM: pxa: change SSP DMA channels allocation" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524070703.11901-12-robert.jarzmik@free.fr \
--to=robert.jarzmik@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=daniel@zonque.org \
--cc=dmaengine@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=haojian.zhuang@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).