* [PATCH net-next] net: fec: remove stale comment
@ 2018-05-24 11:27 YueHaibing
2018-05-24 11:31 ` Andy Duan
2018-05-25 18:53 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2018-05-24 11:27 UTC (permalink / raw)
To: davem, fugang.duan; +Cc: netdev, linux-kernel, YueHaibing
This comment is outdated as fec_ptp_ioctl has been replaced by fec_ptp_set/fec_ptp_get
since commit 1d5244d0e43b ("fec: Implement the SIOCGHWTSTAMP ioctl")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/freescale/fec_ptp.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index f814397..d438ef8 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -466,12 +466,6 @@ static int fec_ptp_enable(struct ptp_clock_info *ptp,
return -EOPNOTSUPP;
}
-/**
- * fec_ptp_hwtstamp_ioctl - control hardware time stamping
- * @ndev: pointer to net_device
- * @ifreq: ioctl data
- * @cmd: particular ioctl requested
- */
int fec_ptp_set(struct net_device *ndev, struct ifreq *ifr)
{
struct fec_enet_private *fep = netdev_priv(ndev);
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH net-next] net: fec: remove stale comment
2018-05-24 11:27 [PATCH net-next] net: fec: remove stale comment YueHaibing
@ 2018-05-24 11:31 ` Andy Duan
2018-05-25 18:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andy Duan @ 2018-05-24 11:31 UTC (permalink / raw)
To: YueHaibing, davem; +Cc: netdev, linux-kernel
> From: YueHaibing <yuehaibing@huawei.com> Sent: 2018年5月24日 19:27
> This comment is outdated as fec_ptp_ioctl has been replaced by
> fec_ptp_set/fec_ptp_get since commit 1d5244d0e43b ("fec: Implement
> the SIOCGHWTSTAMP ioctl")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks.
Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> drivers/net/ethernet/freescale/fec_ptp.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index f814397..d438ef8 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -466,12 +466,6 @@ static int fec_ptp_enable(struct ptp_clock_info
> *ptp,
> return -EOPNOTSUPP;
> }
>
> -/**
> - * fec_ptp_hwtstamp_ioctl - control hardware time stamping
> - * @ndev: pointer to net_device
> - * @ifreq: ioctl data
> - * @cmd: particular ioctl requested
> - */
> int fec_ptp_set(struct net_device *ndev, struct ifreq *ifr) {
> struct fec_enet_private *fep = netdev_priv(ndev);
> --
> 2.7.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: fec: remove stale comment
2018-05-24 11:27 [PATCH net-next] net: fec: remove stale comment YueHaibing
2018-05-24 11:31 ` Andy Duan
@ 2018-05-25 18:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-05-25 18:53 UTC (permalink / raw)
To: yuehaibing; +Cc: fugang.duan, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 24 May 2018 19:27:07 +0800
> This comment is outdated as fec_ptp_ioctl has been replaced by fec_ptp_set/fec_ptp_get
> since commit 1d5244d0e43b ("fec: Implement the SIOCGHWTSTAMP ioctl")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-25 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-24 11:27 [PATCH net-next] net: fec: remove stale comment YueHaibing
2018-05-24 11:31 ` Andy Duan
2018-05-25 18:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).