From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Ramon Fried <ramon.fried@gmail.com>
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remoteproc: qcom_q6v5: don't auto boot remote processor
Date: Mon, 28 May 2018 21:20:47 -0700 [thread overview]
Message-ID: <20180529042047.GE2259@tuxbook-pro> (raw)
In-Reply-To: <20180524192141.20323-1-ramon.fried@gmail.com>
On Thu 24 May 12:21 PDT 2018, Ramon Fried wrote:
> Sometimes that rmtfs userspace module is not brought
> up fast enough and the modem crashes.
> disabling automated boot in the driver and triggering
> the boot from user-space sovles the problem.
>
> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
Thanks for your patch Ramon. While this nudges the behavior to make
things work slightly better I think we need to describe the explicit
dependency between the mss firmware and the existence of rmtfs.
As our remoteprocs are essentially always-on I would prefer that they
start "automatically" and not through use of the sysfs interface.
But we're at the point where this is a real problem on 410, 820 and 845,
so we have to come up with some way to tie these pieces together. If
your patch suits that solution I will happily take it.
Regards,
Bjorn
> ---
> drivers/remoteproc/qcom_q6v5_pil.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c
> index cbbafdcaaecb..719ee96445b3 100644
> --- a/drivers/remoteproc/qcom_q6v5_pil.c
> +++ b/drivers/remoteproc/qcom_q6v5_pil.c
> @@ -1133,6 +1133,8 @@ static int q6v5_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> + rproc->auto_boot = false;
> +
> qproc = (struct q6v5 *)rproc->priv;
> qproc->dev = &pdev->dev;
> qproc->rproc = rproc;
> --
> 2.17.0
>
next prev parent reply other threads:[~2018-05-29 4:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 19:21 [PATCH] remoteproc: qcom_q6v5: don't auto boot remote processor Ramon Fried
2018-05-29 4:20 ` Bjorn Andersson [this message]
2018-05-29 11:31 ` Ramon Fried
2019-01-18 7:04 ` Sibi Sankar
2019-01-18 18:35 ` Brian Norris
2019-01-18 19:46 ` Sibi Sankar
2019-01-18 21:04 ` Brian Norris
2019-01-19 4:17 ` Sibi Sankar
2019-01-30 21:07 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529042047.GE2259@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ramon.fried@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).