* [PATCH] platform/chrome: chromeos_laptop: fix touchpad button mapping on Celes
@ 2018-05-29 19:06 Dmitry Torokhov
2018-05-29 22:12 ` Benson Leung
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2018-05-29 19:06 UTC (permalink / raw)
To: Benson Leung; +Cc: Sultan Alsawaf, linux-kernel
Celes has newer touch controller (compared to the controllers used in
older BayTrail-based devices) and so uses the same button mapping as
Samus.
This fixes the issue with mouse button being stuck in pressed state
after the first click.
Reported-by: Sultan Alsawaf <sultanxda@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/platform/chrome/chromeos_laptop.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c
index 3cecf7933f751..24326eecd7876 100644
--- a/drivers/platform/chrome/chromeos_laptop.c
+++ b/drivers/platform/chrome/chromeos_laptop.c
@@ -620,10 +620,18 @@ static const struct dmi_system_id chromeos_laptop_dmi_table[] __initconst = {
},
.driver_data = (void *)&samus,
},
+ {
+ .ident = "Samsung Chromebook 3",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
+ },
+ .driver_data = (void *)&samus,
+ },
{
/*
* Other Chromebooks with Atmel touch controllers:
- * - Celes, Winky (touchpad)
+ * - Winky (touchpad)
* - Clapper, Expresso, Rambi, Glimmer (touchscreen)
*/
.ident = "Other Chromebook",
--
2.17.0.921.gf22659ad46-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/chrome: chromeos_laptop: fix touchpad button mapping on Celes
2018-05-29 19:06 [PATCH] platform/chrome: chromeos_laptop: fix touchpad button mapping on Celes Dmitry Torokhov
@ 2018-05-29 22:12 ` Benson Leung
0 siblings, 0 replies; 2+ messages in thread
From: Benson Leung @ 2018-05-29 22:12 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Benson Leung, Sultan Alsawaf, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
Hi Dmitry, Hi Sultan,
On Tue, May 29, 2018 at 12:06:59PM -0700, Dmitry Torokhov wrote:
> Celes has newer touch controller (compared to the controllers used in
> older BayTrail-based devices) and so uses the same button mapping as
> Samus.
>
> This fixes the issue with mouse button being stuck in pressed state
> after the first click.
>
> Reported-by: Sultan Alsawaf <sultanxda@gmail.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied for v4.18. Thanks.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-29 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-29 19:06 [PATCH] platform/chrome: chromeos_laptop: fix touchpad button mapping on Celes Dmitry Torokhov
2018-05-29 22:12 ` Benson Leung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).