Re: [PATCH] powerpc/64s: Enhance the information in cpu_show_spectre_v1()

From: kbuild test robot <lkp@intel.com>
To: Michal Suchanek <msuchanek@suse.de>
Cc: kbuild-all@01.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Michal Suchanek <msuchanek@suse.de>,
	Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Michael Neuling <mikey@neuling.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/64s: Enhance the information in cpu_show_spectre_v1()
Date: Tue, 29 May 2018 22:03:10 +0800	[thread overview]
Message-ID: <201805292116.2rlCnXEW%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180528131914.32231-1-msuchanek@suse.de>

[-- Attachment #1: Type: text/plain, Size: 2084 bytes --]

Hi Michal,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.17-rc7 next-20180529]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Michal-Suchanek/powerpc-64s-Enhance-the-information-in-cpu_show_spectre_v1/20180529-181036
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   arch/powerpc/kernel/security.c: In function 'cpu_show_spectre_v1':
>> arch/powerpc/kernel/security.c:54:6: error: 'barrier_nospec_enabled' undeclared (first use in this function); did you mean 'kernfs_ns_enabled'?
     if (barrier_nospec_enabled)
         ^~~~~~~~~~~~~~~~~~~~~~
         kernfs_ns_enabled
   arch/powerpc/kernel/security.c:54:6: note: each undeclared identifier is reported only once for each function it appears in
   arch/powerpc/kernel/security.c:58:1: error: control reaches end of non-void function [-Werror=return-type]
    }
    ^
   cc1: all warnings being treated as errors

vim +54 arch/powerpc/kernel/security.c

    48	
    49	ssize_t cpu_show_spectre_v1(struct device *dev, struct device_attribute *attr, char *buf)
    50	{
    51		if (!security_ftr_enabled(SEC_FTR_BNDS_CHK_SPEC_BAR))
    52			return sprintf(buf, "Not affected\n");
    53	
  > 54		if (barrier_nospec_enabled)
    55			return sprintf(buf, "Mitigation: __user pointer sanitization\n");
    56		else
    57			return sprintf(buf, "Vulnerable\n");
    58	}
    59	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23378 bytes --]