From: Michael Ellerman <mpe@ellerman.id.au>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: linuxppc-dev@ozlabs.org, npiggin@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] powerpc/64s: Add support for ori barrier_nospec patching
Date: Tue, 01 May 2018 22:25:14 +1000 [thread overview]
Message-ID: <87sh7br2ad.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180426181042.38971664@kitsune.suse.cz>
Michal Suchánek <msuchanek@suse.de> writes:
> On Tue, 24 Apr 2018 14:15:55 +1000
> Michael Ellerman <mpe@ellerman.id.au> wrote:
>
>> From: Michal Suchanek <msuchanek@suse.de>
>>
>> Based on the RFI patching. This is required to be able to disable the
>> speculation barrier.
>
> why do you not patch the nospec barrier which is included as part of
> the RFI flush code?
We didn't want to put it in the asm like you had, because not all RFI
flush types need the spec barrier.
So it's more complicated than just patching in the spec barrier, we'd
need to only patch it in if the configured RFI flush also needed it.
> I think when debugging the code it would make more sense if RFI is
> patched by RFI patcher and nospec by nospec patcher.
True. I think what I'm saying is that the spec barrier in the RFI
flush is not a nospec barrier, it's part of that RFI flush type.
> A separate question is if the RFI flush would break without the nospec
> barrier.
The ORI flush requires it, but the others don't.
cheers
next prev parent reply other threads:[~2018-05-01 12:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 4:15 [PATCH 1/6] powerpc/64s: Add barrier_nospec Michael Ellerman
2018-04-24 4:15 ` [PATCH 2/6] powerpc/64s: Add support for ori barrier_nospec patching Michael Ellerman
2018-04-26 16:10 ` Michal Suchánek
2018-05-01 12:25 ` Michael Ellerman [this message]
2018-04-24 4:15 ` [PATCH 3/6] powerpc/64s: Patch barrier_nospec in modules Michael Ellerman
2018-05-03 13:15 ` Michal Suchánek
2018-04-24 4:15 ` [PATCH 4/6] powerpc/64s: Enable barrier_nospec based on firmware settings Michael Ellerman
2018-04-26 16:02 ` Michal Suchánek
2018-05-01 11:11 ` Michael Ellerman
2018-05-02 11:41 ` Michal Suchánek
2018-05-04 0:58 ` Michael Ellerman
2018-04-24 4:15 ` [PATCH 5/6] powerpc: Use barrier_nospec in copy_from_user() Michael Ellerman
2018-04-24 4:15 ` [PATCH 6/6] powerpc/64: Use barrier_nospec in syscall entry Michael Ellerman
2018-04-24 5:44 ` [PATCH 1/6] powerpc/64s: Add barrier_nospec Nicholas Piggin
2018-05-28 13:19 ` [PATCH] powerpc/64s: Enhance the information in cpu_show_spectre_v1() Michal Suchanek
2018-05-29 14:03 ` kbuild test robot
2018-05-29 14:13 ` Christophe LEROY
2018-05-29 14:46 ` Michal Suchánek
2018-05-29 15:24 ` Christophe Leroy
2018-05-29 16:15 ` Joe Perches
2018-06-04 14:11 ` Michael Ellerman
2018-06-04 14:10 ` [1/6] powerpc/64s: Add barrier_nospec Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh7br2ad.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=msuchanek@suse.de \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).