From: Sean Paul <seanpaul@chromium.org>
To: Lowry Li <lowry.li@arm.com>
Cc: liviu.dudau@arm.com, gustavo@padovan.org,
maarten.lankhorst@linux.intel.com, daniel.vetter@intel.com,
jani.nikula@linux.intel.com, seanpaul@chromium.org,
airlied@linux.ie, ville.syrjala@linux.intel.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
brian.starkey@arm.com, malidp@foss.arm.com, nd@arm.com
Subject: Re: [PATCH v2 0/2] drm/blend: Add per-plane pixel blend mode property
Date: Wed, 30 May 2018 10:40:40 -0400 [thread overview]
Message-ID: <20180530144040.GM3373@art_vandelay> (raw)
In-Reply-To: <1527679434-13228-1-git-send-email-lowry.li@arm.com>
On Wed, May 30, 2018 at 07:23:52PM +0800, Lowry Li wrote:
> Hi,
>
> This serie aims at adding the support for pixel blend modes represent the
> alpha blending equation selection in the driver. It also introduces to use
> it in the malidp driver.
>
> Let me know what you think,
Hi Lowry,
Thank you for doing this work. I know this is something that is missing for
proper Android support, so it's most welcome.
Do you have userspace patches using this property?
Sean
> Lowry
>
> Changes for v2:
> - Moves the blending equation into the DOC comment
> - Refines the comments of drm_plane_create_blend_mode_property to not
> enumerate the #defines, but instead the string values
> - Uses fg.* instead of pixel.* and plane_alpha instead of plane.alpha
> - Introduces to use it in the malidp driver, which depends on the plane
> alpha patch
>
> Changes from v1:
> - v1 is just the core changes to request for commments
> - Adds a pixel_blend_mode to drm_plane_state and a blend_mode_property to
> drm_plane, and related support functions
> - Defines three blend modes in drm_blend.h
> - Rebased on current drm-next
>
> Lowry Li (2):
> drm/blend: Add per-plane pixel blend mode property
> drm/mali-dp: Implement plane alpha and pixel blend on malidp
>
> drivers/gpu/drm/arm/malidp_planes.c | 76 ++++++++++++++-----------
> drivers/gpu/drm/drm_atomic.c | 4 ++
> drivers/gpu/drm/drm_atomic_helper.c | 1 +
> drivers/gpu/drm/drm_blend.c | 110 ++++++++++++++++++++++++++++++++++++
> include/drm/drm_blend.h | 6 ++
> include/drm/drm_plane.h | 6 ++
> 6 files changed, 171 insertions(+), 32 deletions(-)
>
> --
> 1.9.1
>
--
Sean Paul, Software Engineer, Google / Chromium OS
prev parent reply other threads:[~2018-05-30 14:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 11:23 [PATCH v2 0/2] drm/blend: Add per-plane pixel blend mode property Lowry Li
2018-05-30 11:23 ` [PATCH v2 1/2] " Lowry Li
2018-05-30 13:27 ` Brian Starkey
2018-05-31 9:36 ` Maarten Lankhorst
2018-05-31 14:51 ` Emil Velikov
2018-05-30 11:23 ` [PATCH v2 2/2] drm/mali-dp: Implement plane alpha and pixel blend on malidp Lowry Li
2018-05-30 13:34 ` Brian Starkey
2018-06-01 11:22 ` kbuild test robot
2018-05-30 14:40 ` Sean Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530144040.GM3373@art_vandelay \
--to=seanpaul@chromium.org \
--cc=airlied@linux.ie \
--cc=brian.starkey@arm.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lowry.li@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=malidp@foss.arm.com \
--cc=nd@arm.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).