From: Emil Velikov <emil.l.velikov@gmail.com>
To: Lowry Li <lowry.li@arm.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>,
David Airlie <airlied@linux.ie>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Mali DP Maintainers <malidp@foss.arm.com>,
"Vetter, Daniel" <daniel.vetter@intel.com>,
nd@arm.com
Subject: Re: [PATCH v2 1/2] drm/blend: Add per-plane pixel blend mode property
Date: Thu, 31 May 2018 15:51:37 +0100 [thread overview]
Message-ID: <CACvgo52NznSOWNvB_uOT4iQ-8+3A=ohhBe2os+jbEc=8pswn3A@mail.gmail.com> (raw)
In-Reply-To: <1527679434-13228-2-git-send-email-lowry.li@arm.com>
Hi Lowry,
Small drive-by suggestion. Haven't checked if others have pointed it
out previously :-\
On 30 May 2018 at 12:23, Lowry Li <lowry.li@arm.com> wrote:
> +/**
> + * drm_plane_create_blend_mode_property - create a new blend mode property
> + * @plane: drm plane
> + * @supported_modes: bitmask of supported modes, must include
> + * BIT(DRM_MODE_BLEND_PREMULTI)
> + *
There are two possible blend modes (ignoring 'none'), yet premult must
be supported.
What if the hardware can do only "coverage"?
One-liner explaining why things are as-is would be a great move.
HTH
Emil
next prev parent reply other threads:[~2018-05-31 14:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 11:23 [PATCH v2 0/2] drm/blend: Add per-plane pixel blend mode property Lowry Li
2018-05-30 11:23 ` [PATCH v2 1/2] " Lowry Li
2018-05-30 13:27 ` Brian Starkey
2018-05-31 9:36 ` Maarten Lankhorst
2018-05-31 14:51 ` Emil Velikov [this message]
2018-05-30 11:23 ` [PATCH v2 2/2] drm/mali-dp: Implement plane alpha and pixel blend on malidp Lowry Li
2018-05-30 13:34 ` Brian Starkey
2018-06-01 11:22 ` kbuild test robot
2018-05-30 14:40 ` [PATCH v2 0/2] drm/blend: Add per-plane pixel blend mode property Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo52NznSOWNvB_uOT4iQ-8+3A=ohhBe2os+jbEc=8pswn3A@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lowry.li@arm.com \
--cc=malidp@foss.arm.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).