* [PATCH] message: fusion: Remove extra parentheses
@ 2018-06-03 11:03 Varsha Rao
2018-06-03 11:31 ` Nicholas Mc Guire
0 siblings, 1 reply; 2+ messages in thread
From: Varsha Rao @ 2018-06-03 11:03 UTC (permalink / raw)
To: Sathya Prakash, Chaitra P B, Suganath Prabu Subramani,
MPT-FusionLinux.pdl, linux-scsi, linux-kernel, Nicholas Mc Guire,
Lukas Bulwahn
Cc: Varsha Rao
To fix clang warning of extraneous parentheses and check patch issue,
remove extra parentheses and replace x == NULL with !x. Following
coccinelle script is used to fix it.
@disable is_null,paren@
expression e;
statement s;
@@
if (
- (e==NULL)
+!e
)
s
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
drivers/message/fusion/mptbase.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index 51eb1b027963..3fe53b65c5fa 100644
--- a/drivers/message/fusion/mptbase.c
+++ b/drivers/message/fusion/mptbase.c
@@ -335,11 +335,11 @@ static int mpt_remove_dead_ioc_func(void *arg)
MPT_ADAPTER *ioc = (MPT_ADAPTER *)arg;
struct pci_dev *pdev;
- if ((ioc == NULL))
+ if (!ioc)
return -1;
pdev = ioc->pcidev;
- if ((pdev == NULL))
+ if (!pdev)
return -1;
pci_stop_and_remove_bus_device_locked(pdev);
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] message: fusion: Remove extra parentheses
2018-06-03 11:03 [PATCH] message: fusion: Remove extra parentheses Varsha Rao
@ 2018-06-03 11:31 ` Nicholas Mc Guire
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas Mc Guire @ 2018-06-03 11:31 UTC (permalink / raw)
To: Varsha Rao
Cc: Sathya Prakash, Chaitra P B, Suganath Prabu Subramani,
MPT-FusionLinux.pdl, linux-scsi, linux-kernel, Lukas Bulwahn
On Sun, Jun 03, 2018 at 04:33:07PM +0530, Varsha Rao wrote:
> To fix clang warning of extraneous parentheses and check patch issue,
> remove extra parentheses and replace x == NULL with !x. Following
> coccinelle script is used to fix it.
>
> @disable is_null,paren@
> expression e;
> statement s;
> @@
> if (
> - (e==NULL)
> +!e
> )
> s
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
Reviewed-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
> drivers/message/fusion/mptbase.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
> index 51eb1b027963..3fe53b65c5fa 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -335,11 +335,11 @@ static int mpt_remove_dead_ioc_func(void *arg)
> MPT_ADAPTER *ioc = (MPT_ADAPTER *)arg;
> struct pci_dev *pdev;
>
> - if ((ioc == NULL))
> + if (!ioc)
> return -1;
>
> pdev = ioc->pcidev;
> - if ((pdev == NULL))
> + if (!pdev)
This is of course equivalent - but note that in mptbase.c the "style"
== NULL is used in other places as well - so maybe it would be good to
change those as well or leave the == NULL in place for readability reasons.
> return -1;
>
> pci_stop_and_remove_bus_device_locked(pdev);
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-03 11:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-03 11:03 [PATCH] message: fusion: Remove extra parentheses Varsha Rao
2018-06-03 11:31 ` Nicholas Mc Guire
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).