[PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode

[PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode

[Andy Shevchenko]

According to documentation REMAP register has to be programmed in
either DMA or PIO mode of the slice.

Move the DMA capability check below to let REMAP register be programmed
in PIO mode.

Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mfd/intel-lpss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 9e545eb6e8b4..4bcf117a7ba8 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -275,11 +275,11 @@ static void intel_lpss_init_dev(const struct intel_lpss *lpss)
 
 	intel_lpss_deassert_reset(lpss);
 
+	intel_lpss_set_remap_addr(lpss);
+
 	if (!intel_lpss_has_idma(lpss))
 		return;
 
-	intel_lpss_set_remap_addr(lpss);
-
 	/* Make sure that SPI multiblock DMA transfers are re-enabled */
 	if (lpss->type == LPSS_DEV_SPI)
 		writel(value, lpss->priv + LPSS_PRIV_SSP_REG);
-- 
2.17.0

Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode

[Mika Westerberg]

On Tue, Apr 24, 2018 at 06:00:10PM +0300, Andy Shevchenko wrote:
> According to documentation REMAP register has to be programmed in
> either DMA or PIO mode of the slice.
> 
> Move the DMA capability check below to let REMAP register be programmed
> in PIO mode.
> 
> Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode

[Andy Shevchenko]

On Wed, 2018-04-25 at 13:25 +0300, Mika Westerberg wrote:
> On Tue, Apr 24, 2018 at 06:00:10PM +0300, Andy Shevchenko wrote:
> > According to documentation REMAP register has to be programmed in
> > either DMA or PIO mode of the slice.
> > 
> > Move the DMA capability check below to let REMAP register be
> > programmed
> > in PIO mode.
> > 
> > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS
> > devices")
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Lee, can we have this applied in next rc cycle?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode

[Lee Jones]

On Fri, 18 May 2018, Andy Shevchenko wrote:

> On Wed, 2018-04-25 at 13:25 +0300, Mika Westerberg wrote:
> > On Tue, Apr 24, 2018 at 06:00:10PM +0300, Andy Shevchenko wrote:
> > > According to documentation REMAP register has to be programmed in
> > > either DMA or PIO mode of the slice.
> > > 
> > > Move the DMA capability check below to let REMAP register be
> > > programmed
> > > in PIO mode.
> > > 
> > > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS
> > > devices")
> > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > 
> > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Lee, can we have this applied in next rc cycle?

This has been broken since v4.3.

We'll roll it into v4.18 and tag it for -stable.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode

[Lee Jones]

On Tue, 24 Apr 2018, Andy Shevchenko wrote:

> According to documentation REMAP register has to be programmed in
> either DMA or PIO mode of the slice.
> 
> Move the DMA capability check below to let REMAP register be programmed
> in PIO mode.
> 
> Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mfd/intel-lpss.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied and tagged for -stable # 4.3+

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode

[Andy Shevchenko]

On Fri, 2018-05-18 at 14:51 +0100, Lee Jones wrote:
> On Tue, 24 Apr 2018, Andy Shevchenko wrote:
> 
> > According to documentation REMAP register has to be programmed in
> > either DMA or PIO mode of the slice.
> > 
> > Move the DMA capability check below to let REMAP register be
> > programmed
> > in PIO mode.
> > 
> > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS
> > devices")
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/mfd/intel-lpss.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Applied and tagged for -stable # 4.3+

Thanks!

Though can not see it in Linus' tree still.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode

[Lee Jones]

On Fri, 01 Jun 2018, Andy Shevchenko wrote:

> On Fri, 2018-05-18 at 14:51 +0100, Lee Jones wrote:
> > On Tue, 24 Apr 2018, Andy Shevchenko wrote:
> > 
> > > According to documentation REMAP register has to be programmed in
> > > either DMA or PIO mode of the slice.
> > > 
> > > Move the DMA capability check below to let REMAP register be
> > > programmed
> > > in PIO mode.
> > > 
> > > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS
> > > devices")
> > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >  drivers/mfd/intel-lpss.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > Applied and tagged for -stable # 4.3+
> 
> Thanks!
> 
> Though can not see it in Linus' tree still.

Why would it be in Linus' tree?

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog