* [PATCH] net: hns3: remove unused hclgevf_cfg_func_mta_filter
@ 2018-06-05 11:38 Arnd Bergmann
2018-06-05 15:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-06-05 11:38 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta
Cc: Arnd Bergmann, David S. Miller, Peng Li, Fuyun Liang,
Yunsheng Lin, Jian Shen, Xi Wang, netdev, linux-kernel
The last patch apparently added a complete replacement for this
function, but left the old one in place, which now causes a
harmless warning:
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c:731:12: 'hclgevf_cfg_func_mta_filter' defined but not used
I assume it can be removed.
Fixes: 3a678b5806e6 ("net: hns3: Optimize the VF's process of updating multicast MAC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
index dd8e8e6718dc..bc8a5760d959 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
@@ -728,17 +728,6 @@ static void hclgevf_reset_tqp_stats(struct hnae3_handle *handle)
}
}
-static int hclgevf_cfg_func_mta_filter(struct hnae3_handle *handle, bool en)
-{
- struct hclgevf_dev *hdev = hclgevf_ae_get_hdev(handle);
- u8 msg[2] = {0};
-
- msg[0] = en;
- return hclgevf_send_mbx_msg(hdev, HCLGE_MBX_SET_MULTICAST,
- HCLGE_MBX_MAC_VLAN_MC_FUNC_MTA_ENABLE,
- msg, 1, false, NULL, 0);
-}
-
static int hclgevf_cfg_func_mta_type(struct hclgevf_dev *hdev)
{
u8 resp_msg = HCLGEVF_MTA_TYPE_SEL_MAX;
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: hns3: remove unused hclgevf_cfg_func_mta_filter
2018-06-05 11:38 [PATCH] net: hns3: remove unused hclgevf_cfg_func_mta_filter Arnd Bergmann
@ 2018-06-05 15:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-06-05 15:10 UTC (permalink / raw)
To: arnd
Cc: yisen.zhuang, salil.mehta, lipeng321, liangfuyun1, linyunsheng,
shenjian15, wangxi11, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 5 Jun 2018 13:38:21 +0200
> The last patch apparently added a complete replacement for this
> function, but left the old one in place, which now causes a
> harmless warning:
>
> drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c:731:12: 'hclgevf_cfg_func_mta_filter' defined but not used
>
> I assume it can be removed.
>
> Fixes: 3a678b5806e6 ("net: hns3: Optimize the VF's process of updating multicast MAC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks Arnd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-05 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-05 11:38 [PATCH] net: hns3: remove unused hclgevf_cfg_func_mta_filter Arnd Bergmann
2018-06-05 15:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).