linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] docs: atomic_ops: atomic_set is a write (not read) operation
@ 2018-06-05 19:43 Jonathan Neuschäfer
  2018-06-06  8:07 ` Paul E. McKenney
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Neuschäfer @ 2018-06-05 19:43 UTC (permalink / raw)
  To: linux-doc
  Cc: Jonathan Neuschäfer, Jonathan Corbet, Paul E. McKenney,
	linux-kernel

Describe it as such.

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 Documentation/core-api/atomic_ops.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/core-api/atomic_ops.rst b/Documentation/core-api/atomic_ops.rst
index 2e7165f86f55..724583453e1f 100644
--- a/Documentation/core-api/atomic_ops.rst
+++ b/Documentation/core-api/atomic_ops.rst
@@ -29,7 +29,7 @@ updated by one CPU, local_t is probably more appropriate. Please see
 local_t.
 
 The first operations to implement for atomic_t's are the initializers and
-plain reads. ::
+plain writes. ::
 
 	#define ATOMIC_INIT(i)		{ (i) }
 	#define atomic_set(v, i)	((v)->counter = (i))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: atomic_ops: atomic_set is a write (not read) operation
  2018-06-05 19:43 [PATCH] docs: atomic_ops: atomic_set is a write (not read) operation Jonathan Neuschäfer
@ 2018-06-06  8:07 ` Paul E. McKenney
  2018-06-29 13:43   ` Andrea Parri
  0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2018-06-06  8:07 UTC (permalink / raw)
  To: Jonathan Neuschäfer; +Cc: linux-doc, Jonathan Corbet, linux-kernel

On Tue, Jun 05, 2018 at 09:43:23PM +0200, Jonathan Neuschäfer wrote:
> Describe it as such.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

I have queued this, but if someone else would prefer to take it:

Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

> ---
>  Documentation/core-api/atomic_ops.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/core-api/atomic_ops.rst b/Documentation/core-api/atomic_ops.rst
> index 2e7165f86f55..724583453e1f 100644
> --- a/Documentation/core-api/atomic_ops.rst
> +++ b/Documentation/core-api/atomic_ops.rst
> @@ -29,7 +29,7 @@ updated by one CPU, local_t is probably more appropriate. Please see
>  local_t.
> 
>  The first operations to implement for atomic_t's are the initializers and
> -plain reads. ::
> +plain writes. ::
> 
>  	#define ATOMIC_INIT(i)		{ (i) }
>  	#define atomic_set(v, i)	((v)->counter = (i))
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: atomic_ops: atomic_set is a write (not read) operation
  2018-06-06  8:07 ` Paul E. McKenney
@ 2018-06-29 13:43   ` Andrea Parri
  2018-07-02 18:55     ` Paul E. McKenney
  0 siblings, 1 reply; 4+ messages in thread
From: Andrea Parri @ 2018-06-29 13:43 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: Jonathan Neuschäfer, linux-doc, Jonathan Corbet, linux-kernel

On Wed, Jun 06, 2018 at 01:07:56AM -0700, Paul E. McKenney wrote:
> On Tue, Jun 05, 2018 at 09:43:23PM +0200, Jonathan Neuschäfer wrote:
> > Describe it as such.
> > 
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> 
> I have queued this, but if someone else would prefer to take it:
> 
> Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

In the commit message of bb7d47b697116c ("docs: atomic_ops: Describe
atomic_set as a write operation") from your dev branch,

from "reads" to "writes"

  Andrea


> 
> > ---
> >  Documentation/core-api/atomic_ops.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/core-api/atomic_ops.rst b/Documentation/core-api/atomic_ops.rst
> > index 2e7165f86f55..724583453e1f 100644
> > --- a/Documentation/core-api/atomic_ops.rst
> > +++ b/Documentation/core-api/atomic_ops.rst
> > @@ -29,7 +29,7 @@ updated by one CPU, local_t is probably more appropriate. Please see
> >  local_t.
> > 
> >  The first operations to implement for atomic_t's are the initializers and
> > -plain reads. ::
> > +plain writes. ::
> > 
> >  	#define ATOMIC_INIT(i)		{ (i) }
> >  	#define atomic_set(v, i)	((v)->counter = (i))
> > -- 
> > 2.17.1
> > 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: atomic_ops: atomic_set is a write (not read) operation
  2018-06-29 13:43   ` Andrea Parri
@ 2018-07-02 18:55     ` Paul E. McKenney
  0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2018-07-02 18:55 UTC (permalink / raw)
  To: Andrea Parri
  Cc: Jonathan Neuschäfer, linux-doc, Jonathan Corbet, linux-kernel

On Fri, Jun 29, 2018 at 03:43:45PM +0200, Andrea Parri wrote:
> On Wed, Jun 06, 2018 at 01:07:56AM -0700, Paul E. McKenney wrote:
> > On Tue, Jun 05, 2018 at 09:43:23PM +0200, Jonathan Neuschäfer wrote:
> > > Describe it as such.
> > > 
> > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > 
> > I have queued this, but if someone else would prefer to take it:
> > 
> > Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> 
> In the commit message of bb7d47b697116c ("docs: atomic_ops: Describe
> atomic_set as a write operation") from your dev branch,
> 
> from "reads" to "writes"

Good catch, fixed, thank you!

							Thanx, Paul

>   Andrea
> 
> 
> > 
> > > ---
> > >  Documentation/core-api/atomic_ops.rst | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/core-api/atomic_ops.rst b/Documentation/core-api/atomic_ops.rst
> > > index 2e7165f86f55..724583453e1f 100644
> > > --- a/Documentation/core-api/atomic_ops.rst
> > > +++ b/Documentation/core-api/atomic_ops.rst
> > > @@ -29,7 +29,7 @@ updated by one CPU, local_t is probably more appropriate. Please see
> > >  local_t.
> > > 
> > >  The first operations to implement for atomic_t's are the initializers and
> > > -plain reads. ::
> > > +plain writes. ::
> > > 
> > >  	#define ATOMIC_INIT(i)		{ (i) }
> > >  	#define atomic_set(v, i)	((v)->counter = (i))
> > > -- 
> > > 2.17.1
> > > 
> > 
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-07-02 18:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-05 19:43 [PATCH] docs: atomic_ops: atomic_set is a write (not read) operation Jonathan Neuschäfer
2018-06-06  8:07 ` Paul E. McKenney
2018-06-29 13:43   ` Andrea Parri
2018-07-02 18:55     ` Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).