From: Vinod <vkoul@kernel.org>
To: Sricharan R <sricharan@codeaurora.org>
Cc: bjorn.andersson@linaro.org, ohad@wizery.com, robh+dt@kernel.org,
mark.rutland@arm.com, andy.gross@linaro.org,
david.brown@linaro.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
sibis@codeaurora.org
Subject: Re: [PATCH] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver
Date: Wed, 6 Jun 2018 12:19:09 +0530 [thread overview]
Message-ID: <20180606064909.GC16230@vkoul-mobl> (raw)
In-Reply-To: <1b376fc2-6a1b-1457-ffff-332954d1bef8@codeaurora.org>
Hi Sricharan,
On 06-06-18, 12:09, Sricharan R wrote:
> >>>> +config QCOM_Q6V5_WCSS
> >>>> + tristate "Qualcomm Hexagon based WCSS Peripheral Image Loader"
> >>>> + depends on OF && ARCH_QCOM
> >>>> + depends on QCOM_SMEM
> >>>> + depends on RPMSG_QCOM_SMD || (COMPILE_TEST && RPMSG_QCOM_SMD=n)
> >>>> + depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n
> >>>
> >>> Is there a reason why it depends on RPMSG_QCOM_GLINK_SMEM=n? What would
> >>> happen if distro wants both this and RPMSG_QCOM_GLINK_SMEM
> >>>
> >> RPMSG_QCOM_GLINK_SMEM=n should be for the COMPILE_TEST. Probably that
> >
> > why would that be a limitation? I am more worried about
> > RPMSG_QCOM_GLINK_SMEM=n being the condition here. In new drivers we
> > should not typically have dependency on some symbol being not there
>
> Without that, if RPMSG_QCOM_GLINK_SMEM=m is compiled as a module, then
> it would break the build.
Okay I do not know the details, but that doesn't sound correct to me.
Breaking build sounds a bit extreme to me. Can you give details on this
part..
> >> means that it should be corrected here and for ADSP, Q6V5_PIL as well.
> >> Bjorn, is that correct ?, should it be, below ?
> >>
> >> depends on (RPMSG_QCOM_SMD || (COMPILE_TEST && RPMSG_QCOM_SMD=n)) || (RPMSG_QCOM_GLINK_SMEM || (COMPILE_TEST && RPMSG_QCOM_GLINK_SMEM=n))
> >
> > that doesnt really sound good :(
>
> Hmm, but i was thinking it should functionally depend on either SMD or GLINK and not both.
If you are depedent upon a symbol provided by a module you should say
depends on. If a machine is not supposed to have both SMD or GLINK then
the driver will not get probed.
--
~Vinod
next prev parent reply other threads:[~2018-06-06 6:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 5:42 [PATCH] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver Sricharan R
2018-06-05 6:19 ` Vinod
2018-06-05 12:56 ` Sricharan R
2018-06-05 16:40 ` Vinod Koul
2018-06-06 6:39 ` Sricharan R
2018-06-06 6:49 ` Vinod [this message]
2018-06-06 9:51 ` Sricharan R
2018-06-06 16:17 ` Bjorn Andersson
2018-06-07 4:11 ` Vinod
2018-06-07 4:24 ` Bjorn Andersson
2018-06-07 5:29 ` Sricharan R
2018-06-07 5:48 ` Bjorn Andersson
2018-06-07 6:36 ` Sricharan R
2018-06-07 8:43 ` Vinod
2018-06-07 9:32 ` Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606064909.GC16230@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).