From: Vinod <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Sricharan R <sricharan@codeaurora.org>,
ohad@wizery.com, robh+dt@kernel.org, mark.rutland@arm.com,
andy.gross@linaro.org, david.brown@linaro.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, sibis@codeaurora.org
Subject: Re: [PATCH] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver
Date: Thu, 7 Jun 2018 09:41:34 +0530 [thread overview]
Message-ID: <20180607041134.GF16230@vkoul-mobl> (raw)
In-Reply-To: <20180606161733.GE510@tuxbook-pro>
On 06-06-18, 09:17, Bjorn Andersson wrote:
> On Tue 05 Jun 05:56 PDT 2018, Sricharan R wrote:
>
> > Hi Vinod,
> >
> > On 6/5/2018 11:49 AM, Vinod wrote:
> > > On 05-06-18, 11:12, Sricharan R wrote:
> > >
> > >> +config QCOM_Q6V5_WCSS
> > >> + tristate "Qualcomm Hexagon based WCSS Peripheral Image Loader"
> > >> + depends on OF && ARCH_QCOM
> > >> + depends on QCOM_SMEM
> > >> + depends on RPMSG_QCOM_SMD || (COMPILE_TEST && RPMSG_QCOM_SMD=n)
> > >> + depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n
> > >
> > > Is there a reason why it depends on RPMSG_QCOM_GLINK_SMEM=n? What would
> > > happen if distro wants both this and RPMSG_QCOM_GLINK_SMEM
> > >
>
> It says that QCOM_Q6V5_WCSS either must have a compatible state (i.e.
> builtin vs builtin, module vs builtin, but not builtin vs module) or
> that it's disabled, in which case we will hit the stub functions in
> qcom_glink.h.
>
> I.e. this prevents QCOM_Q6V5_WCSS to be compiled builtin when
> RPMSG_QCOM_GLINK_SMEM is module, as this would give us both stubs and
> the module.
IIUC, you want to have QCOM_Q6V5_WCSS and RPMSG_QCOM_GLINK_SMEM as
modules or builtin
So, wouldn't Kconfig syntax something like where we say:
M if RPMSG_QCOM_GLINK_SMEM=m
bool if RPMSG_QCOM_GLINK_SMEM=y
Which makes it clear that both these have to be same type?
--
~Vinod
next prev parent reply other threads:[~2018-06-07 4:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 5:42 [PATCH] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver Sricharan R
2018-06-05 6:19 ` Vinod
2018-06-05 12:56 ` Sricharan R
2018-06-05 16:40 ` Vinod Koul
2018-06-06 6:39 ` Sricharan R
2018-06-06 6:49 ` Vinod
2018-06-06 9:51 ` Sricharan R
2018-06-06 16:17 ` Bjorn Andersson
2018-06-07 4:11 ` Vinod [this message]
2018-06-07 4:24 ` Bjorn Andersson
2018-06-07 5:29 ` Sricharan R
2018-06-07 5:48 ` Bjorn Andersson
2018-06-07 6:36 ` Sricharan R
2018-06-07 8:43 ` Vinod
2018-06-07 9:32 ` Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607041134.GF16230@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).