linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH rcu] fixup! EXP iommu: stupid_workaround() can be static
  2018-06-08 20:11 [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static? kbuild test robot
@ 2018-06-08 20:11 ` kbuild test robot
  2018-06-09  6:17 ` [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static? Paul E. McKenney
  1 sibling, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2018-06-08 20:11 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: kbuild-all, linux-kernel


Fixes: 814ee31d1f90 ("fixup! EXP iommu: Placeholder for fix in mainline")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
 amd_iommu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 46519d0..00dcafe 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3563,7 +3563,7 @@ EXPORT_SYMBOL(amd_iommu_device_info);
 static struct irq_chip amd_ir_chip;
 static DEFINE_SPINLOCK(iommu_table_lock);
 
-void __maybe_unused stupid_workaround(void)
+static void __maybe_unused stupid_workaround(void)
 {
 	spin_lock(&iommu_table_lock);
 	spin_unlock(&iommu_table_lock);

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?
@ 2018-06-08 20:11 kbuild test robot
  2018-06-08 20:11 ` [RFC PATCH rcu] fixup! EXP iommu: stupid_workaround() can be static kbuild test robot
  2018-06-09  6:17 ` [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static? Paul E. McKenney
  0 siblings, 2 replies; 3+ messages in thread
From: kbuild test robot @ 2018-06-08 20:11 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: kbuild-all, linux-kernel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev
head:   f20dfe840ba05efdc4071106cffa31cb67cf6bc8
commit: 814ee31d1f906ad00daccb58944ab16fa279690c [114/116] fixup! EXP iommu: Placeholder for fix in mainline
reproduce:
        # apt-get install sparse
        git checkout 814ee31d1f906ad00daccb58944ab16fa279690c
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   drivers/iommu/amd_iommu.c:3539:30: sparse: expression using sizeof(void)
   drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
   drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
>> drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?
  2018-06-08 20:11 [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static? kbuild test robot
  2018-06-08 20:11 ` [RFC PATCH rcu] fixup! EXP iommu: stupid_workaround() can be static kbuild test robot
@ 2018-06-09  6:17 ` Paul E. McKenney
  1 sibling, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2018-06-09  6:17 UTC (permalink / raw)
  To: kbuild test robot; +Cc: kbuild-all, linux-kernel

On Sat, Jun 09, 2018 at 04:11:26AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev
> head:   f20dfe840ba05efdc4071106cffa31cb67cf6bc8
> commit: 814ee31d1f906ad00daccb58944ab16fa279690c [114/116] fixup! EXP iommu: Placeholder for fix in mainline
> reproduce:
>         # apt-get install sparse
>         git checkout 814ee31d1f906ad00daccb58944ab16fa279690c
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF=-D__CHECK_ENDIAN__
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
>    drivers/iommu/amd_iommu.c:3539:30: sparse: expression using sizeof(void)
>    drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
>    drivers/iommu/amd_iommu.c:3542:36: sparse: expression using sizeof(void)
> >> drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static?
> 
> Please review and possibly fold the followup patch.

This whole thing disappears when I rebase to v4.18-rc1.  ;-)

							Thanx, Paul

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-09  6:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-08 20:11 [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static? kbuild test robot
2018-06-08 20:11 ` [RFC PATCH rcu] fixup! EXP iommu: stupid_workaround() can be static kbuild test robot
2018-06-09  6:17 ` [rcu:rcu/dev 114/116] drivers/iommu/amd_iommu.c:3566:21: sparse: symbol 'stupid_workaround' was not declared. Should it be static? Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).