* [PATCH] tsl2550: fix lux1_input error in low light
@ 2018-06-09 6:58 Matt Ranostay
0 siblings, 0 replies; 2+ messages in thread
From: Matt Ranostay @ 2018-06-09 6:58 UTC (permalink / raw)
To: linux-kernel; +Cc: Matt Ranostay, Arnd Bergmann, Greg Kroah-Hartman
ADC channel 0 photodiode detects both infrared + visible light,
but ADC channel 1 just detects infrared. However, the latter is a bit
more sensitive in that range so complete darkness or low light causes
a error condition in which the chan0 - chan1 is negative that
results in a -EAGAIN.
This patch changes the resulting lux1_input sysfs attribute message from
"Resource temporarily unavailable" to a user-grokable lux value of 0.
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
---
drivers/misc/tsl2550.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c
index adf46072cb37..3fce3b6a3624 100644
--- a/drivers/misc/tsl2550.c
+++ b/drivers/misc/tsl2550.c
@@ -177,7 +177,7 @@ static int tsl2550_calculate_lux(u8 ch0, u8 ch1)
} else
lux = 0;
else
- return -EAGAIN;
+ return 0;
/* LUX range check */
return lux > TSL2550_MAX_LUX ? TSL2550_MAX_LUX : lux;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] tsl2550: fix lux1_input error in low light
@ 2013-06-03 22:38 Matt Ranostay
0 siblings, 0 replies; 2+ messages in thread
From: Matt Ranostay @ 2013-06-03 22:38 UTC (permalink / raw)
To: giometti; +Cc: linux-kernel, koen.kooi, pantelis.antoniou, Matt Ranostay
ADC channel 0 photodiode detects both infrared + visible light,
but ADC channel 1 just detects infrared. However, the latter is a bit
more sensitive in that range so complete darkness or low light causes
a error condition in which the chan0 - chan1 is negative that
results in a -EAGAIN.
This patch changes the resulting lux1_input sysfs attribute message from
"Resource temporarily unavailable" to a user-grokable lux value of 0.
Signed-off-by: Matt Ranostay <mranostay@gmail.com>
---
drivers/misc/tsl2550.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c
index 1dfde4d..e58620b 100644
--- a/drivers/misc/tsl2550.c
+++ b/drivers/misc/tsl2550.c
@@ -178,7 +178,7 @@ static int tsl2550_calculate_lux(u8 ch0, u8 ch1)
} else
lux = 0;
else
- return -EAGAIN;
+ return 0;
/* LUX range check */
return lux > TSL2550_MAX_LUX ? TSL2550_MAX_LUX : lux;
--
1.8.2.rc3.6.g407929c
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-09 6:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-09 6:58 [PATCH] tsl2550: fix lux1_input error in low light Matt Ranostay
-- strict thread matches above, loose matches on Subject: below --
2013-06-03 22:38 Matt Ranostay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).