From: Brian Norris <briannorris@chromium.org>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Govind Singh <govinds@codeaurora.org>,
<linux-kernel@vger.kernel.org>,
Brian Norris <briannorris@chromium.org>
Subject: [PATCH 1/4] ath10k: snoc: use correct bus-specific pointer in RX retry
Date: Mon, 11 Jun 2018 14:09:43 -0700 [thread overview]
Message-ID: <20180611210946.241341-1-briannorris@chromium.org> (raw)
We're 'ath10k_snoc', not 'ath10k_pci'. This probably means we're
accessing junk data in ath10k_snoc_rx_replenish_retry(), unless
'ath10k_snoc' and 'ath10k_pci' happen to have very similar struct
layouts.
Noticed by inspection.
Fixes: d915105231ca ("ath10k: add hif rx methods for wcn3990")
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
It's possible this would be a for-4.18 target, since the buggy patch is
in the -rc1 merge. But this driver is not fully operational yet. Also,
I'm sending some companion refactorings to help avoid this bug. They
probably aren't 4.18 material.
Let me know if I should do anything differently.
drivers/net/wireless/ath/ath10k/snoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
index ee74e0060504..c7cfc9c9b3d7 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -449,7 +449,7 @@ static void ath10k_snoc_htt_rx_cb(struct ath10k_ce_pipe *ce_state)
static void ath10k_snoc_rx_replenish_retry(struct timer_list *t)
{
- struct ath10k_pci *ar_snoc = from_timer(ar_snoc, t, rx_post_retry);
+ struct ath10k_snoc *ar_snoc = from_timer(ar_snoc, t, rx_post_retry);
struct ath10k *ar = ar_snoc->ar;
ath10k_snoc_rx_post(ar);
--
2.18.0.rc1.242.g61856ae69a-goog
next reply other threads:[~2018-06-11 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 21:09 Brian Norris [this message]
2018-06-11 21:09 ` [PATCH 2/4] ath10k: snoc: stop including pci.h Brian Norris
2018-06-11 21:09 ` [PATCH 3/4] ath10k: snoc: drop unused WCN3990_CE_ATTR_FLAGS Brian Norris
2018-06-11 21:09 ` [PATCH 4/4] ath10k: snoc: sort include files Brian Norris
2018-06-12 11:22 ` [PATCH 1/4] ath10k: snoc: use correct bus-specific pointer in RX retry Kalle Valo
2018-06-14 15:16 ` [1/4] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611210946.241341-1-briannorris@chromium.org \
--to=briannorris@chromium.org \
--cc=ath10k@lists.infradead.org \
--cc=govinds@codeaurora.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).