From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Govind Singh <govinds@codeaurora.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH 1/4] ath10k: snoc: use correct bus-specific pointer in RX retry
Date: Tue, 12 Jun 2018 14:22:08 +0300 [thread overview]
Message-ID: <87wov4ckrj.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180611210946.241341-1-briannorris@chromium.org> (Brian Norris's message of "Mon, 11 Jun 2018 14:09:43 -0700")
Brian Norris <briannorris@chromium.org> writes:
> We're 'ath10k_snoc', not 'ath10k_pci'. This probably means we're
> accessing junk data in ath10k_snoc_rx_replenish_retry(), unless
> 'ath10k_snoc' and 'ath10k_pci' happen to have very similar struct
> layouts.
>
> Noticed by inspection.
>
> Fixes: d915105231ca ("ath10k: add hif rx methods for wcn3990")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> It's possible this would be a for-4.18 target, since the buggy patch is
> in the -rc1 merge. But this driver is not fully operational yet. Also,
> I'm sending some companion refactorings to help avoid this bug. They
> probably aren't 4.18 material.
Yeah, in theory this should go to 4.18 but, like you said, snoc support
does not even work on 4.18 so there would be no benefit. Actually just
more work while we add final pieces of wcn3990 support to ath10k. So
I'll queue these to 4.19.
> Let me know if I should do anything differently.
This is very good as is, thanks.
--
Kalle Valo
next prev parent reply other threads:[~2018-06-12 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 21:09 [PATCH 1/4] ath10k: snoc: use correct bus-specific pointer in RX retry Brian Norris
2018-06-11 21:09 ` [PATCH 2/4] ath10k: snoc: stop including pci.h Brian Norris
2018-06-11 21:09 ` [PATCH 3/4] ath10k: snoc: drop unused WCN3990_CE_ATTR_FLAGS Brian Norris
2018-06-11 21:09 ` [PATCH 4/4] ath10k: snoc: sort include files Brian Norris
2018-06-12 11:22 ` Kalle Valo [this message]
2018-06-14 15:16 ` [1/4] ath10k: snoc: use correct bus-specific pointer in RX retry Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wov4ckrj.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=govinds@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).