Re: [PATCH v7 4/4] vsprintf: Add command line option debug_boot_weak_hash

From: Steven Rostedt <rostedt@goodmis.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Kees Cook <keescook@chromium.org>,
	Anna-Maria Gleixner <anna-maria@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 4/4] vsprintf: Add command line option debug_boot_weak_hash
Date: Wed, 13 Jun 2018 15:01:54 -0400	[thread overview]
Message-ID: <20180613150154.61b52e05@gandalf.local.home> (raw)
In-Reply-To: <1528763954-27731-5-git-send-email-me@tobin.cc>

On Tue, 12 Jun 2018 10:39:14 +1000
"Tobin C. Harding" <me@tobin.cc> wrote:

> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index c445f9f28760..6d2479eb7c2b 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -1651,6 +1651,18 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
>  	return widen_string(buf, buf - buf_start, end, spec);
>  }
>  
> +/* Make pointers available for printing early in the boot sequence. */
> +static int debug_boot_weak_hash __ro_after_init;
> +EXPORT_SYMBOL(debug_boot_weak_hash);

I was too busy trying to make this use a static_branch, that I forgot
to mention this in my review.

Why did you add that EXPORT_SYMBOL()? It's useless with a static
variable. I think you can nuke that line.

-- Steve