From: "Tobin C. Harding" <me@tobin.cc>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Kees Cook <keescook@chromium.org>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/4] random: Return nbytes filled from hw RNG
Date: Wed, 13 Jun 2018 07:42:42 +1000 [thread overview]
Message-ID: <20180612214242.GB4528@eros> (raw)
In-Reply-To: <CAHp75Vcqni6MtnLcoMG+2Tt_YeGq2QeQy4myEJp+dmjPXdj3XQ@mail.gmail.com>
On Tue, Jun 12, 2018 at 11:39:56AM +0300, Andy Shevchenko wrote:.
> On Tue, Jun 12, 2018 at 3:39 AM, Tobin C. Harding <me@tobin.cc> wrote:
> > Currently the function get_random_bytes_arch() has return value 'void'.
> > If the hw RNG fails we currently fall back to using get_random_bytes().
> > This defeats the purpose of requesting random material from the hw RNG
> > in the first place.
>
> > - int chunk = min(nbytes, (int)sizeof(unsigned long));
> > + int chunk = min_t(int, left, (int)sizeof(unsigned long));
>
> Isn't this (int) implied when you use min_t(int, ...) ?
thanks Andy, will spin another version.
Tobin
next prev parent reply other threads:[~2018-06-12 21:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 0:39 [PATCH v7 0/4] enable early printing of hashed pointers Tobin C. Harding
2018-06-12 0:39 ` [PATCH v7 1/4] random: Fix whitespace pre random-bytes work Tobin C. Harding
2018-06-12 0:39 ` [PATCH v7 2/4] random: Return nbytes filled from hw RNG Tobin C. Harding
2018-06-12 8:39 ` Andy Shevchenko
2018-06-12 18:28 ` Steven Rostedt
2018-06-12 21:42 ` Tobin C. Harding [this message]
2018-06-12 0:39 ` [PATCH v7 3/4] vsprintf: Use hw RNG for ptr_key Tobin C. Harding
2018-06-12 18:44 ` Steven Rostedt
2018-06-12 21:41 ` Tobin C. Harding
2018-06-12 0:39 ` [PATCH v7 4/4] vsprintf: Add command line option debug_boot_weak_hash Tobin C. Harding
2018-06-13 18:46 ` Steven Rostedt
2018-06-13 19:01 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612214242.GB4528@eros \
--to=me@tobin.cc \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).