From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Giulio Benetti <giulio.benetti@micronovasrl.com>
Cc: matwey.kornilov@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Stefan Potyra <Stefan.Potyra@elektrobit.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Ed Blake <ed.blake@sondrel.com>,
Joshua Scott <joshua.scott@alliedtelesis.co.nz>,
Vignesh R <vigneshr@ti.com>,
Rolf Evers-Fischer <rolf.evers.fischer@aptiv.com>,
Aaron Sierra <asierra@xes-inc.com>,
Phil Elwell <phil@raspberrypi.org>,
Rafael Gago <rafael.gago@gmail.com>,
Joel Stanley <joel@jms.id.au>, Sean Wang <sean.wang@mediatek.com>,
linux-serial@vger.kernel.org (open list:SERIAL DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH 3/4] serial: 8250: Handle case port doesn't have TEMT interrupt using em485.
Date: Wed, 13 Jun 2018 17:59:38 +0100 [thread overview]
Message-ID: <20180613175915.279d03e2@alans-desktop> (raw)
In-Reply-To: <20180606095156.72628-2-giulio.benetti@micronovasrl.com>
> + } else {
> + while ((lsr & BOTH_EMPTY) != BOTH_EMPTY) {
> + lsr = serial_in(p, UART_LSR);
> + cpu_relax();
> + }
> + }
This still needs a timeout in case some kind of hardware flow control line
is asserted and therefore the byte is staying put.
Alan
next prev parent reply other threads:[~2018-06-13 17:01 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 12:40 [PATCH 0/8] serial: 8250: Add 485 emulation to 8250_dw Giulio Benetti
2018-06-01 12:40 ` [PATCH 1/8] serial: 8250_dw: add em485 support Giulio Benetti
2018-06-01 12:40 ` [PATCH 2/8] serial: 8250_dw: allow enable rs485 at boot time Giulio Benetti
2018-06-01 12:40 ` [PATCH 3/8] serial: 8250: Copy em485 from port to real port Giulio Benetti
2018-06-04 10:13 ` Andy Shevchenko
2018-06-04 10:52 ` Giulio Benetti
2018-06-01 12:40 ` [PATCH 4/8] serial: 8250: Handle case port doesn't have TEMT interrupt using em485 Giulio Benetti
2018-06-04 10:17 ` Andy Shevchenko
2018-06-04 10:50 ` Giulio Benetti
2018-06-04 11:38 ` Andy Shevchenko
2018-06-04 11:50 ` Giulio Benetti
2018-06-04 12:26 ` Andy Shevchenko
2018-06-04 17:40 ` Matwey V. Kornilov
2018-06-04 18:50 ` Giulio Benetti
2018-06-05 10:51 ` Matwey V. Kornilov
2018-06-06 9:36 ` Giulio Benetti
2018-06-06 9:49 ` [PATCH 2/4] serial: 8250: Copy mctrl when register port Giulio Benetti
2018-06-06 9:49 ` [PATCH 3/4] serial: 8250: Make em485_rts_after_send() set mctrl according to rts state Giulio Benetti
2018-06-06 12:02 ` Andy Shevchenko
2018-06-06 9:49 ` [PATCH 4/4] serial: core: Mask mctrl with TIOCM_RTS too if rs485 on and RTS_AFTER_SEND set Giulio Benetti
2018-06-06 12:03 ` Andy Shevchenko
2018-06-06 12:07 ` Giulio Benetti
2018-06-06 9:49 ` [PATCH 1/4] serial: 8250: Copy em485 from port to real port Giulio Benetti
2018-06-06 11:56 ` Andy Shevchenko
2018-06-06 12:15 ` Giulio Benetti
2018-06-06 13:11 ` Andy Shevchenko
2018-06-06 14:32 ` Giulio Benetti
2018-06-06 18:55 ` Matwey V. Kornilov
2018-06-06 19:15 ` Giulio Benetti
2018-06-07 7:03 ` Matwey V. Kornilov
2018-06-07 12:43 ` Giulio Benetti
2018-06-06 12:01 ` [PATCH 2/4] serial: 8250: Copy mctrl when register port Andy Shevchenko
2018-06-06 9:51 ` [PATCH 2/4] serial: 8250_dw: allow enable rs485 at boot time Giulio Benetti
2018-06-06 9:51 ` [PATCH 3/4] serial: 8250: Handle case port doesn't have TEMT interrupt using em485 Giulio Benetti
2018-06-13 16:59 ` Alan Cox [this message]
2018-06-06 9:51 ` [PATCH 4/4] serial: 8250_dw: treat rpm suspend with -EBUSY if RS485 ON and RTS_AFTER_SEND Giulio Benetti
2018-06-06 9:51 ` [PATCH 1/4] serial: 8250_dw: add em485 support Giulio Benetti
2018-06-06 16:51 ` Andy Shevchenko
2018-06-06 19:16 ` Giulio Benetti
2018-06-01 12:40 ` [PATCH 5/8] serial: 8250_dw: treat rpm suspend with -EBUSY if RS485 ON and RTS_AFTER_SEND Giulio Benetti
2018-06-01 12:40 ` [PATCH 6/8] serial: 8250: Copy mctrl when register port Giulio Benetti
2018-06-06 14:31 ` Aaron Sierra
2018-06-06 14:44 ` Giulio Benetti
2018-06-01 12:40 ` [PATCH 7/8] serial: 8250: Make em485_rts_after_send() set mctrl according to rts state Giulio Benetti
2018-06-01 12:40 ` [PATCH 8/8] serial: core: Mask mctrl with TIOCM_RTS too if rs485 on and RTS_AFTER_SEND set Giulio Benetti
2018-06-04 10:12 ` [PATCH 0/8] serial: 8250: Add 485 emulation to 8250_dw Andy Shevchenko
2018-06-04 10:34 ` Matwey V. Kornilov
2018-06-04 10:42 ` Giulio Benetti
2018-06-04 11:44 ` Andy Shevchenko
2018-06-04 14:58 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613175915.279d03e2@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=Stefan.Potyra@elektrobit.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=asierra@xes-inc.com \
--cc=ed.blake@sondrel.com \
--cc=giulio.benetti@micronovasrl.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=joshua.scott@alliedtelesis.co.nz \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=matwey.kornilov@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=phil@raspberrypi.org \
--cc=rafael.gago@gmail.com \
--cc=rolf.evers.fischer@aptiv.com \
--cc=sean.wang@mediatek.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).