From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: matwey.kornilov@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Matthias Brugger <mbrugger@suse.com>,
Kees Cook <keescook@chromium.org>, Sean Young <sean@mess.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] serial: core: Mask mctrl with TIOCM_RTS too if rs485 on and RTS_AFTER_SEND set.
Date: Wed, 6 Jun 2018 14:07:45 +0200 [thread overview]
Message-ID: <5bda9e82-369a-ff5f-fef8-f3933c6f1c64@micronovasrl.com> (raw)
In-Reply-To: <a156ce90ab7e45ecf6936c29cc5d976c56f49a51.camel@linux.intel.com>
Il 06/06/2018 14:03, Andy Shevchenko ha scritto:
> On Wed, 2018-06-06 at 11:49 +0200, Giulio Benetti wrote:
>> If rs485 is enabled and RTS_AFTER_SEND is set on startup need to keep
>> TIOCM_RTS asserted to keep rs485 transceiver in RX when idle.
>>
>> Check if rs485 is on and RTS_AFTER_SEND is set and mask port->mctrl
>> with
>> TIOCM_RTS too and not only TIOCM_DTR.
>>
>
> This one feels wrong to be in serial_core.c. Perhaps in 8250/8250*.c.
I've tried to avoid modifying serial_core.c but if it masks mctrl only
with TIOCM_DTR, it forces RTS unasserted.
Another way could be:
If rs485 ON and RTS_AFTER_SEND set, then ignore RTS driving in
8250_set_mctrl, would it make sense?
Thanks
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
next prev parent reply other threads:[~2018-06-06 12:07 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 12:40 [PATCH 0/8] serial: 8250: Add 485 emulation to 8250_dw Giulio Benetti
2018-06-01 12:40 ` [PATCH 1/8] serial: 8250_dw: add em485 support Giulio Benetti
2018-06-01 12:40 ` [PATCH 2/8] serial: 8250_dw: allow enable rs485 at boot time Giulio Benetti
2018-06-01 12:40 ` [PATCH 3/8] serial: 8250: Copy em485 from port to real port Giulio Benetti
2018-06-04 10:13 ` Andy Shevchenko
2018-06-04 10:52 ` Giulio Benetti
2018-06-01 12:40 ` [PATCH 4/8] serial: 8250: Handle case port doesn't have TEMT interrupt using em485 Giulio Benetti
2018-06-04 10:17 ` Andy Shevchenko
2018-06-04 10:50 ` Giulio Benetti
2018-06-04 11:38 ` Andy Shevchenko
2018-06-04 11:50 ` Giulio Benetti
2018-06-04 12:26 ` Andy Shevchenko
2018-06-04 17:40 ` Matwey V. Kornilov
2018-06-04 18:50 ` Giulio Benetti
2018-06-05 10:51 ` Matwey V. Kornilov
2018-06-06 9:36 ` Giulio Benetti
2018-06-06 9:49 ` [PATCH 2/4] serial: 8250: Copy mctrl when register port Giulio Benetti
2018-06-06 9:49 ` [PATCH 3/4] serial: 8250: Make em485_rts_after_send() set mctrl according to rts state Giulio Benetti
2018-06-06 12:02 ` Andy Shevchenko
2018-06-06 9:49 ` [PATCH 4/4] serial: core: Mask mctrl with TIOCM_RTS too if rs485 on and RTS_AFTER_SEND set Giulio Benetti
2018-06-06 12:03 ` Andy Shevchenko
2018-06-06 12:07 ` Giulio Benetti [this message]
2018-06-06 9:49 ` [PATCH 1/4] serial: 8250: Copy em485 from port to real port Giulio Benetti
2018-06-06 11:56 ` Andy Shevchenko
2018-06-06 12:15 ` Giulio Benetti
2018-06-06 13:11 ` Andy Shevchenko
2018-06-06 14:32 ` Giulio Benetti
2018-06-06 18:55 ` Matwey V. Kornilov
2018-06-06 19:15 ` Giulio Benetti
2018-06-07 7:03 ` Matwey V. Kornilov
2018-06-07 12:43 ` Giulio Benetti
2018-06-06 12:01 ` [PATCH 2/4] serial: 8250: Copy mctrl when register port Andy Shevchenko
2018-06-06 9:51 ` [PATCH 2/4] serial: 8250_dw: allow enable rs485 at boot time Giulio Benetti
2018-06-06 9:51 ` [PATCH 3/4] serial: 8250: Handle case port doesn't have TEMT interrupt using em485 Giulio Benetti
2018-06-13 16:59 ` Alan Cox
2018-06-06 9:51 ` [PATCH 4/4] serial: 8250_dw: treat rpm suspend with -EBUSY if RS485 ON and RTS_AFTER_SEND Giulio Benetti
2018-06-06 9:51 ` [PATCH 1/4] serial: 8250_dw: add em485 support Giulio Benetti
2018-06-06 16:51 ` Andy Shevchenko
2018-06-06 19:16 ` Giulio Benetti
2018-06-01 12:40 ` [PATCH 5/8] serial: 8250_dw: treat rpm suspend with -EBUSY if RS485 ON and RTS_AFTER_SEND Giulio Benetti
2018-06-01 12:40 ` [PATCH 6/8] serial: 8250: Copy mctrl when register port Giulio Benetti
2018-06-06 14:31 ` Aaron Sierra
2018-06-06 14:44 ` Giulio Benetti
2018-06-01 12:40 ` [PATCH 7/8] serial: 8250: Make em485_rts_after_send() set mctrl according to rts state Giulio Benetti
2018-06-01 12:40 ` [PATCH 8/8] serial: core: Mask mctrl with TIOCM_RTS too if rs485 on and RTS_AFTER_SEND set Giulio Benetti
2018-06-04 10:12 ` [PATCH 0/8] serial: 8250: Add 485 emulation to 8250_dw Andy Shevchenko
2018-06-04 10:34 ` Matwey V. Kornilov
2018-06-04 10:42 ` Giulio Benetti
2018-06-04 11:44 ` Andy Shevchenko
2018-06-04 14:58 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bda9e82-369a-ff5f-fef8-f3933c6f1c64@micronovasrl.com \
--to=giulio.benetti@micronovasrl.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=matwey.kornilov@gmail.com \
--cc=mbrugger@suse.com \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).