linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Staging: octeon-usb: octeon-hcd.c: style fix line length warning
@ 2018-06-13 20:40 Javier Martinez
  2018-06-13 20:52 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez @ 2018-06-13 20:40 UTC (permalink / raw)
  To: gregkh; +Cc: jhogan, aaro.koskinen, devel, linux-kernel

Checkpatch.pl issued a warning in the top of the commment within
octeon-hcd.c. This is a simple style fix for that.

Signed-off-by: Javier Martinez <javiermlinux@gmail.com>
---
 drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index cded30f145aa..768b0148f3d5 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -1,5 +1,5 @@
 /*
- * This file is subject to the terms and conditions of the GNU General Public
+ * This file is subject to the terms and conditions of the GPL
  * License.  See the file "COPYING" in the main directory of this archive
  * for more details.
  *
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Staging: octeon-usb: octeon-hcd.c: style fix line length warning
  2018-06-13 20:40 [PATCH] Staging: octeon-usb: octeon-hcd.c: style fix line length warning Javier Martinez
@ 2018-06-13 20:52 ` Greg KH
  2018-06-13 20:59   ` Javier Martinez
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2018-06-13 20:52 UTC (permalink / raw)
  To: Javier Martinez; +Cc: devel, jhogan, linux-kernel, aaro.koskinen

On Wed, Jun 13, 2018 at 04:40:15PM -0400, Javier Martinez wrote:
> Checkpatch.pl issued a warning in the top of the commment within
> octeon-hcd.c. This is a simple style fix for that.
> 
> Signed-off-by: Javier Martinez <javiermlinux@gmail.com>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index cded30f145aa..768b0148f3d5 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -1,5 +1,5 @@
>  /*
> - * This file is subject to the terms and conditions of the GNU General Public
> + * This file is subject to the terms and conditions of the GPL
>   * License.  See the file "COPYING" in the main directory of this archive

The grammer is now incorrect :(

Shouldn't we just have a SPDX line at the top here and this whole boiler
plate text be removed?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Staging: octeon-usb: octeon-hcd.c: style fix line length warning
  2018-06-13 20:52 ` Greg KH
@ 2018-06-13 20:59   ` Javier Martinez
  0 siblings, 0 replies; 3+ messages in thread
From: Javier Martinez @ 2018-06-13 20:59 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel

On Wed, Jun 13, 2018 at 10:52:55PM +0200, Greg KH wrote:
> On Wed, Jun 13, 2018 at 04:40:15PM -0400, Javier Martinez wrote:
> > Checkpatch.pl issued a warning in the top of the commment within
> > octeon-hcd.c. This is a simple style fix for that.
> > 
> > Signed-off-by: Javier Martinez <javiermlinux@gmail.com>
> > ---
> >  drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> > index cded30f145aa..768b0148f3d5 100644
> > --- a/drivers/staging/octeon-usb/octeon-hcd.c
> > +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> > @@ -1,5 +1,5 @@
> >  /*
> > - * This file is subject to the terms and conditions of the GNU General Public
> > + * This file is subject to the terms and conditions of the GPL
> >   * License.  See the file "COPYING" in the main directory of this archive
> 
> The grammer is now incorrect :(
> 
> Shouldn't we just have a SPDX line at the top here and this whole boiler
> plate text be removed?
> 
> thanks,
> 
> greg k-h

Sure, will get right to it. I am actually newbie to all this.
I watched your tutorial on youtube when you were at FOSDEM,
Huge help, thank you for that.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-13 21:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-13 20:40 [PATCH] Staging: octeon-usb: octeon-hcd.c: style fix line length warning Javier Martinez
2018-06-13 20:52 ` Greg KH
2018-06-13 20:59   ` Javier Martinez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).