* [PATCH] crash: print timestamp using time64_t
@ 2018-06-18 15:03 Arnd Bergmann
0 siblings, 0 replies; only message in thread
From: Arnd Bergmann @ 2018-06-18 15:03 UTC (permalink / raw)
To: Andrew Morton
Cc: Arnd Bergmann, Dave Young, Xunlei Pang, Baoquan He,
Kirill A. Shutemov, Petr Tesarik, Matthew Wilcox,
Marc-André Lureau, linux-kernel
The get_seconds() call returns a 32-bit timestamp on some architectures,
and will overflow in the future. The newer ktime_get_real_seconds()
always returns a 64-bit timestamp that does not suffer from this problem.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
kernel/crash_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index b66aced5e8c2..9612b2571bd6 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -344,7 +344,7 @@ void crash_save_vmcoreinfo(void)
if (vmcoreinfo_data_safecopy)
vmcoreinfo_data = vmcoreinfo_data_safecopy;
- vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds());
+ vmcoreinfo_append_str("CRASHTIME=%lld\n", ktime_get_real_seconds());
update_vmcoreinfo_note();
}
--
2.9.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-06-18 15:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-18 15:03 [PATCH] crash: print timestamp using time64_t Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).