* [PATCH v1] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
@ 2018-06-19 22:07 Nick Dyer
2018-06-20 8:05 ` Lucas Stach
0 siblings, 1 reply; 2+ messages in thread
From: Nick Dyer @ 2018-06-19 22:07 UTC (permalink / raw)
To: Shawn Guo
Cc: Sascha Hauer, linux-arm-kernel, linux-kernel, devicetree,
Nikita Yushchenko, Chris Healy, Lucas Stach, Nick Dyer
The pinctrl settings were incorrect for the touchscreen interrupt line, causing
an interrupt storm. This change has been tested with both the atmel_mxt_ts and
RMI4 drivers on the RDU1 units.
Signed-off-by: Nick Dyer <nick@shmanahar.org>
---
arch/arm/boot/dts/imx51-zii-rdu1.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index df9eca94d812..4d12ba54ba15 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -770,8 +770,8 @@
pinctrl_ts: tsgrp {
fsl,pins = <
- MX51_PAD_CSI1_D8__GPIO3_12 0x85
- MX51_PAD_CSI1_D9__GPIO3_13 0x85
+ MX51_PAD_CSI1_D8__GPIO3_12 4
+ MX51_PAD_CSI1_D9__GPIO3_13 (1<<16)
>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
2018-06-19 22:07 [PATCH v1] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl Nick Dyer
@ 2018-06-20 8:05 ` Lucas Stach
0 siblings, 0 replies; 2+ messages in thread
From: Lucas Stach @ 2018-06-20 8:05 UTC (permalink / raw)
To: Nick Dyer, Shawn Guo
Cc: Sascha Hauer, linux-arm-kernel, linux-kernel, devicetree,
Nikita Yushchenko, Chris Healy
Hi Nick,
Am Dienstag, den 19.06.2018, 23:07 +0100 schrieb Nick Dyer:
> The pinctrl settings were incorrect for the touchscreen interrupt line, causing
> an interrupt storm. This change has been tested with both the atmel_mxt_ts and
> RMI4 drivers on the RDU1 units.
>
> > Signed-off-by: Nick Dyer <nick@shmanahar.org>
> ---
> arch/arm/boot/dts/imx51-zii-rdu1.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index df9eca94d812..4d12ba54ba15 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -770,8 +770,8 @@
>
> > pinctrl_ts: tsgrp {
> > fsl,pins = <
> > > - MX51_PAD_CSI1_D8__GPIO3_12 0x85
> > > - MX51_PAD_CSI1_D9__GPIO3_13 0x85
> > > + MX51_PAD_CSI1_D8__GPIO3_12 4
> + MX51_PAD_CSI1_D9__GPIO3_13 (1<<16)
Please don't move away from using hex notation for the padctrl
settings.
Thanks,
Lucas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-20 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-19 22:07 [PATCH v1] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl Nick Dyer
2018-06-20 8:05 ` Lucas Stach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).