From: Borislav Petkov <bp@alien8.de>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: KVM <kvm@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
Tony Luck <tony.luck@intel.com>,
Yazen Ghannam <Yazen.Ghannam@amd.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] x86/kvm: Handle all MCA banks
Date: Fri, 22 Jun 2018 20:24:19 +0200 [thread overview]
Message-ID: <20180622182419.GE1882@zn.tnic> (raw)
In-Reply-To: <20180622181603.GB5549@flask>
On Fri, Jun 22, 2018 at 08:16:04PM +0200, Radim Krčmář wrote:
> 2018-06-22 11:51+0200, Borislav Petkov:
> > From: Borislav Petkov <bp@suse.de>
> >
> > Extend the range of MCA banks which get passed to set/get_msr_mce() to
> > include all the MSRs of the last bank too.
> >
> > Signed-off-by: Borislav Petkov <bp@suse.de>
> > ---
> > arch/x86/kvm/x86.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> > index 80452b0f0e8c..a7d344823356 100644
> > --- a/arch/x86/kvm/x86.c
> > +++ b/arch/x86/kvm/x86.c
> > @@ -2466,7 +2466,7 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
> >
> > case MSR_IA32_MCG_CTL:
> > case MSR_IA32_MCG_STATUS:
> > - case MSR_IA32_MC0_CTL ... MSR_IA32_MCx_CTL(KVM_MAX_MCE_BANKS) - 1:
> > + case MSR_IA32_MC0_CTL ... MSR_IA32_MCx_MISC(KVM_MAX_MCE_BANKS) - 1:
>
> It was correct before. We have 32 banks (KVM_MAX_MCE_BANKS), so the
> last useable has index 31 and the "- 1" is going to roll over from first
> MSR of bank 32 to the last MSR of the last bank.
>
> Another way of writing it would be:
>
> case MSR_IA32_MC0_CTL ... MSR_IA32_MCx_MISC(KVM_MAX_MCE_BANKS - 1):
Huh?
This is what I did:
+ case MSR_IA32_MC0_CTL ... MSR_IA32_MCx_MISC(KVM_MAX_MCE_BANKS) - 1:
It needs to be MISC because it is the last MSR in the MCA bank and thus
the highest.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-06-22 18:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 9:50 [PATCH 0/3] x86/kvm: Enable MCE injection in the guest Borislav Petkov
2018-06-22 9:50 ` [PATCH 1/3] kvm/x86: Move MSR_K7_HWCR to svm.c Borislav Petkov
2018-06-22 9:51 ` [PATCH 2/3] x86/kvm: Implement MSR_HWCR support Borislav Petkov
2018-06-22 18:52 ` Radim Krčmář
2018-06-22 19:09 ` Borislav Petkov
2018-06-22 19:22 ` Radim Krčmář
2018-06-22 9:51 ` [PATCH 3/3] x86/kvm: Handle all MCA banks Borislav Petkov
2018-06-22 18:16 ` Radim Krčmář
2018-06-22 18:24 ` Borislav Petkov [this message]
2018-06-22 18:47 ` Radim Krčmář
2018-06-22 19:02 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622182419.GE1882@zn.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).