From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
qemu-s390x <qemu-s390x@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
Thomas Huth <thuth@redhat.com>
Subject: Re: s390 qemu boot failure in -next
Date: Mon, 25 Jun 2018 10:05:48 +0200 [thread overview]
Message-ID: <20180625100548.64222dad.cohuck@redhat.com> (raw)
In-Reply-To: <88d9afed-f91d-c320-13c8-9a93fc52b700@de.ibm.com>
On Mon, 25 Jun 2018 09:27:59 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> Also adding QEMU.
>
> On 06/25/2018 09:10 AM, Christian Borntraeger wrote:
> >
> >
> > On 06/22/2018 09:47 PM, Guenter Roeck wrote:
> >> Hi,
> >>
> >> starting with commit 's390/boot: make head.S and als.c be part of the
> >> decompressor only' in -next, s390 immages no longer boot in qemu.
> >> As far as I can see, the reason is that the command line is no longer
> >> passed from qemu to the kernel, which results in a panic because the
> >> root file system can not be mounted.
> >>
> >> Was this change made on purpose ? If so, is there a way to get qemu
> >> back to working ?
> >
> > Certainly not on purpose.
> >
> > Vasily, I can reproduce this with KVM and an external kernel boot of the vmlinux file (the elf file)
> >
> > e.g.
> >
> > qemu-system-s390 -enable-kvm -nographic -kernel vmlinux -append "this string no longer is command line"
> >
> > The compressed image (bzImage) seems to work fine though.
> >
> > This seems to be an unfortunate side effect of QEMUs ways to "guess" its Linux (checking for start
> > address 0x10000, which is no longer true for the vmlinux file). With the pure vmlinux elf file
> > the load address is 0x100000 as there is no unpacker.
Do we consider these locations to be an exported interface, or is it
just QEMU guessing?
> >
> > Guenter, can you check if arch/s390/boot/bzImage works for you as a workaround?
>
> Something like this in QEMU
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index f278036fa7..14153ce880 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -187,11 +187,13 @@ static void s390_ipl_realize(DeviceState *dev, Error **errp)
> */
> if (pentry == KERN_IMAGE_START || pentry == 0x800) {
> ipl->start_addr = KERN_IMAGE_START;
> - /* Overwrite parameters in the kernel image, which are "rom" */
> - strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline);
> } else {
> ipl->start_addr = pentry;
> }
> + if (ipl->cmdline) {
> + /* If there is a command line, put it in the right place */
> + strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline);
> + }
Check for the magic Linux string (like in the non-elf case) first?
>
> if (ipl->initrd) {
> ram_addr_t initrd_offset;
>
> would put the command line in no matter what the start address is.
I'm for putting that one in (and backporting it to qemu-stable). It's a
bit worrying, though, that our ipl code is so fragile...
next prev parent reply other threads:[~2018-06-25 8:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 19:47 s390 qemu boot failure in -next Guenter Roeck
2018-06-25 7:10 ` Christian Borntraeger
2018-06-25 7:27 ` Christian Borntraeger
2018-06-25 8:02 ` [qemu-s390x] " Christian Borntraeger
2018-06-25 8:08 ` Cornelia Huck
2018-06-25 8:27 ` Thomas Huth
2018-06-25 8:05 ` Cornelia Huck [this message]
2018-06-25 8:29 ` Christian Borntraeger
2018-06-26 8:29 ` Cornelia Huck
2018-06-26 8:54 ` Christian Borntraeger
2018-06-25 8:36 ` Vasily Gorbik
2018-06-25 8:49 ` Cornelia Huck
2018-06-25 12:26 ` Christian Borntraeger
2018-06-25 13:35 ` Guenter Roeck
2018-06-25 15:09 ` Vasily Gorbik
2018-06-25 15:09 ` [PATCH] s390/boot: block uncompressed vmlinux booting attempts Vasily Gorbik
2018-06-25 19:40 ` Guenter Roeck
2018-06-26 7:30 ` Christian Borntraeger
2018-06-26 8:24 ` Cornelia Huck
2018-06-26 5:32 ` s390 qemu boot failure in -next Georgi Guninski
2018-06-26 5:40 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625100548.64222dad.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=schwidefsky@de.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).