From: Georgi Guninski <guninski@guninski.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
qemu-s390x <qemu-s390x@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>
Subject: Re: s390 qemu boot failure in -next
Date: Tue, 26 Jun 2018 08:32:46 +0300 [thread overview]
Message-ID: <20180626053246.6kyvrj7jbuhgdkgv@sivokote.iziade.m$> (raw)
In-Reply-To: <88d9afed-f91d-c320-13c8-9a93fc52b700@de.ibm.com>
On Mon, Jun 25, 2018 at 09:27:59AM +0200, Christian Borntraeger wrote:
> - /* Overwrite parameters in the kernel image, which are "rom" */
> - strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline);
> + strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline);
Why not replace strcpy() with strncpy() or snprintf()?
strcpy() may overflow.
next prev parent reply other threads:[~2018-06-26 5:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 19:47 s390 qemu boot failure in -next Guenter Roeck
2018-06-25 7:10 ` Christian Borntraeger
2018-06-25 7:27 ` Christian Borntraeger
2018-06-25 8:02 ` [qemu-s390x] " Christian Borntraeger
2018-06-25 8:08 ` Cornelia Huck
2018-06-25 8:27 ` Thomas Huth
2018-06-25 8:05 ` Cornelia Huck
2018-06-25 8:29 ` Christian Borntraeger
2018-06-26 8:29 ` Cornelia Huck
2018-06-26 8:54 ` Christian Borntraeger
2018-06-25 8:36 ` Vasily Gorbik
2018-06-25 8:49 ` Cornelia Huck
2018-06-25 12:26 ` Christian Borntraeger
2018-06-25 13:35 ` Guenter Roeck
2018-06-25 15:09 ` Vasily Gorbik
2018-06-25 15:09 ` [PATCH] s390/boot: block uncompressed vmlinux booting attempts Vasily Gorbik
2018-06-25 19:40 ` Guenter Roeck
2018-06-26 7:30 ` Christian Borntraeger
2018-06-26 8:24 ` Cornelia Huck
2018-06-26 5:32 ` Georgi Guninski [this message]
2018-06-26 5:40 ` s390 qemu boot failure in -next Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20180626053246.6kyvrj7jbuhgdkgv@sivokote.iziade.m$' \
--to=guninski@guninski.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=schwidefsky@de.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).