From: Byungchul Park <byungchul.park@lge.com>
To: sjpark <sj38.park@gmail.com>
Cc: paulmck@linux.vnet.ibm.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: Re: [PATCH] locking/memory-barriers.txt/kokr: Update Korean translation to fix broken DMA vs. MMIO ordering example
Date: Tue, 26 Jun 2018 13:56:09 +0900 [thread overview]
Message-ID: <20180626045609.GB20783@X58A-UD3R> (raw)
In-Reply-To: <alpine.DEB.2.20.1806261218490.1528@hxeon>
On Tue, Jun 26, 2018 at 12:21:23PM +0900, sjpark wrote:
> Hello Byungchul,
>
>
> On Tue, 26 Jun 2018, Byungchul Park wrote:
>
> > On Sun, Jun 17, 2018 at 02:16:08PM +0900, SeongJae Park wrote:
> > > Translate this commit to Korean:
> > >
> > > 5846581e3563 ("locking/memory-barriers.txt: Fix broken DMA vs. MMIO ordering example")
> >
> > Hi SeongJae,
> >
> > You keep doing good jobs ;)
> >
> > I believe it would be better if you consider the little things below
> > more. What do you think about it, SeongJae?
>
> Thank you for great comments!
>
> >
> > > Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> > > ---
> > > Documentation/translations/ko_KR/memory-barriers.txt | 15 +++++++--------
> > > 1 file changed, 7 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/Documentation/translations/ko_KR/memory-barriers.txt b/Documentation/translations/ko_KR/memory-barriers.txt
> > > index 921739d00f69..ada0a709cce1 100644
> > > --- a/Documentation/translations/ko_KR/memory-barriers.txt
> > > +++ b/Documentation/translations/ko_KR/memory-barriers.txt
> > > @@ -1891,19 +1891,18 @@ Mandatory 배리어들은 SMP 시스템에서도 UP 시스템에서도 SMP 효
> > > /* 소유권을 수정 */
> > > desc->status = DEVICE_OWN;
> > >
> > > - /* MMIO 를 통해 디바이스에 공지를 하기 전에 메모리를 동기화 */
> > > - wmb();
> > > -
> > > /* 업데이트된 디스크립터의 디바이스에 공지 */
> > > writel(DESC_NOTIFY, doorbell);
> > > }
> > >
> > > dma_rmb() 는 디스크립터로부터 데이터를 읽어오기 전에 디바이스가 소유권을
> > > - 내놓았음을 보장하게 하고, dma_wmb() 는 디바이스가 자신이 소유권을 다시
> > > - 가졌음을 보기 전에 디스크립터에 데이터가 쓰였음을 보장합니다. wmb() 는
> > > - 캐시 일관성이 없는 (cache incoherent) MMIO 영역에 쓰기를 시도하기 전에
> > > - 캐시 일관성이 있는 메모리 (cache coherent memory) 쓰기가 완료되었음을
> > > - 보장해주기 위해 필요합니다.
> > > + 내려놓았을 것을 보장하고, dma_wmb() 는 디바이스가 자신이 소유권을 다시
> > > + 가졌음을 보기 전에 디스크립터에 데이터가 쓰였을 것을 보장합니다. writel()
> > ^
> > 참고로,
>
> Nice comment. This will enhance the readability a lot.
Could you add this, too? A quite little thing tho.
> > > + 을 사용하면 캐시 일관성이 있는 메모리 (cache coherent memory) 쓰기가 MMIO
> > > + 영역에의 쓰기 전에 완료되었을 것을 보장하므로 writel() 앞에 wmb() 를
> > > + 실행할 필요가 없음을 알아두시기 바랍니다. writel() 보다 비용이 저렴한
> > > + writel_relaxed() 는 이런 보장을 제공하지 않으므로 여기선 사용되지 않아야
> > > + 합니다.
> > >
> > > consistent memory 에 대한 자세한 내용을 위해선 Documentation/DMA-API.txt
> > > 문서를 참고하세요.
> >
> > See the subsection "Kernel I/O barrier effects" for more information on
> > relaxed I/O accessors and the Documentation/DMA-API.txt file for more
> > information on consistent memory.
> >
> > Don't you think the whole sentence need to be translated? If yes, then
> > it would be better to do that as well ;)
>
> Oh, my mistake! It should be.
>
> I applied your comments to the second version.
Thank you SeongJae :)
> Thanks,
> SeongJae Park
>
> >
> > > --
> > > 2.13.0
> >
> > --
> > Thanks,
> > Byungchul
> >
next prev parent reply other threads:[~2018-06-26 4:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 5:16 [PATCH] locking/memory-barriers.txt/kokr: Update Korean translation to fix broken DMA vs. MMIO ordering example SeongJae Park
2018-06-18 15:56 ` Paul E. McKenney
2018-06-26 0:47 ` Byungchul Park
2018-06-26 3:21 ` sjpark
2018-06-26 3:24 ` [PATCH v2] " SeongJae Park
2018-06-26 4:56 ` Byungchul Park [this message]
2018-06-26 5:10 ` [PATCH] " SeongJae Park
2018-06-26 6:58 ` Byungchul Park
2018-06-26 12:22 ` Paul E. McKenney
2018-06-26 12:25 ` SeongJae Park
2018-06-26 22:06 ` Paul E. McKenney
2018-06-26 22:43 ` SeongJae Park
2018-06-27 1:51 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626045609.GB20783@X58A-UD3R \
--to=byungchul.park@lge.com \
--cc=kernel-team@lge.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sj38.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).