* [PATCH 0/3] ASoC: add simple-amplifier
@ 2018-06-26 12:11 Jerome Brunet
2018-06-26 12:11 ` [PATCH 1/3] ASoC: simple-amplifier: remame dio2125 documentation Jerome Brunet
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jerome Brunet @ 2018-06-26 12:11 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood, Nicolò Veronese
Cc: Jerome Brunet, linux-kernel, devicetree, alsa-devel
As discuss here [0], this patchset rename the dio2125 driver to
simple-amplifier in order to make it more discoverable.
The last patch adds simple-audio-amplifier as new compatible
[0]: https://lkml.kernel.org/r/20180625114445.GG9413@sirena.org.uk
Jerome Brunet (3):
ASoC: simple-amplifier: remame dio2125 documentation
ASoC: simple-amplifier: rename dio2125 to simple-amplifer
ASoC: simple-amplifer: add simple-amplifier compatible
.../devicetree/bindings/sound/dioo,dio2125.txt | 12 -------
.../devicetree/bindings/sound/simple-amplifier.txt | 12 +++++++
sound/soc/codecs/Kconfig | 10 +++---
sound/soc/codecs/Makefile | 4 +--
sound/soc/codecs/{dio2125.c => simple-amplifier.c} | 42 +++++++++++-----------
5 files changed, 41 insertions(+), 39 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/dioo,dio2125.txt
create mode 100644 Documentation/devicetree/bindings/sound/simple-amplifier.txt
rename sound/soc/codecs/{dio2125.c => simple-amplifier.c} (68%)
--
2.14.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/3] ASoC: simple-amplifier: remame dio2125 documentation 2018-06-26 12:11 [PATCH 0/3] ASoC: add simple-amplifier Jerome Brunet @ 2018-06-26 12:11 ` Jerome Brunet 2018-06-27 11:30 ` Applied "ASoC: simple-amplifier: remame dio2125 documentation" to the asoc tree Mark Brown 2018-06-26 12:11 ` [PATCH 2/3] ASoC: simple-amplifier: rename dio2125 to simple-amplifer Jerome Brunet 2018-06-26 12:11 ` [PATCH 3/3] ASoC: simple-amplifer: add simple-amplifier compatible Jerome Brunet 2 siblings, 1 reply; 6+ messages in thread From: Jerome Brunet @ 2018-06-26 12:11 UTC (permalink / raw) To: Mark Brown, Liam Girdwood, Nicolò Veronese Cc: Jerome Brunet, linux-kernel, devicetree, alsa-devel The dio2125 is simple enough that we can make it a generic component. Rename the the dio2125 documentation to simple-amplifier to prepare this change. Suggested-by: Nicolò Veronese <nicveronese@gmail.com> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- Documentation/devicetree/bindings/sound/dioo,dio2125.txt | 12 ------------ Documentation/devicetree/bindings/sound/simple-amplifier.txt | 12 ++++++++++++ 2 files changed, 12 insertions(+), 12 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/dioo,dio2125.txt create mode 100644 Documentation/devicetree/bindings/sound/simple-amplifier.txt diff --git a/Documentation/devicetree/bindings/sound/dioo,dio2125.txt b/Documentation/devicetree/bindings/sound/dioo,dio2125.txt deleted file mode 100644 index 63dbfe0f11d0..000000000000 --- a/Documentation/devicetree/bindings/sound/dioo,dio2125.txt +++ /dev/null @@ -1,12 +0,0 @@ -DIO2125 Audio Driver - -Required properties: -- compatible : "dioo,dio2125" -- enable-gpios : the gpio connected to the enable pin of the dio2125 - -Example: - -amp: analog-amplifier { - compatible = "dioo,dio2125"; - enable-gpios = <&gpio GPIOH_3 0>; -}; diff --git a/Documentation/devicetree/bindings/sound/simple-amplifier.txt b/Documentation/devicetree/bindings/sound/simple-amplifier.txt new file mode 100644 index 000000000000..8647edae7af0 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/simple-amplifier.txt @@ -0,0 +1,12 @@ +Simple Amplifier Audio Driver + +Required properties: +- compatible : "dioo,dio2125" or "simple-audio-amplifier" +- enable-gpios : the gpio connected to the enable pin of the simple amplifier + +Example: + +amp: analog-amplifier { + compatible = "simple-audio-amplifier"; + enable-gpios = <&gpio GPIOH_3 0>; +}; -- 2.14.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Applied "ASoC: simple-amplifier: remame dio2125 documentation" to the asoc tree 2018-06-26 12:11 ` [PATCH 1/3] ASoC: simple-amplifier: remame dio2125 documentation Jerome Brunet @ 2018-06-27 11:30 ` Mark Brown 0 siblings, 0 replies; 6+ messages in thread From: Mark Brown @ 2018-06-27 11:30 UTC (permalink / raw) To: Jerome Brunet Cc: Mark Brown, Mark Brown, Liam Girdwood, Nicolò Veronese, devicetree, alsa-devel, linux-kernel, alsa-devel [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain, Size: 3073 bytes --] The patch ASoC: simple-amplifier: remame dio2125 documentation has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 0ed03e6dc288c50b2e7d71523b99df1afd81cea1 Mon Sep 17 00:00:00 2001 From: Jerome Brunet <jbrunet@baylibre.com> Date: Tue, 26 Jun 2018 14:11:26 +0200 Subject: [PATCH] ASoC: simple-amplifier: remame dio2125 documentation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The dio2125 is simple enough that we can make it a generic component. Rename the the dio2125 documentation to simple-amplifier to prepare this change. Suggested-by: Nicolò Veronese <nicveronese@gmail.com> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- .../devicetree/bindings/sound/dioo,dio2125.txt | 12 ------------ .../devicetree/bindings/sound/simple-amplifier.txt | 12 ++++++++++++ 2 files changed, 12 insertions(+), 12 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/dioo,dio2125.txt create mode 100644 Documentation/devicetree/bindings/sound/simple-amplifier.txt diff --git a/Documentation/devicetree/bindings/sound/dioo,dio2125.txt b/Documentation/devicetree/bindings/sound/dioo,dio2125.txt deleted file mode 100644 index 63dbfe0f11d0..000000000000 --- a/Documentation/devicetree/bindings/sound/dioo,dio2125.txt +++ /dev/null @@ -1,12 +0,0 @@ -DIO2125 Audio Driver - -Required properties: -- compatible : "dioo,dio2125" -- enable-gpios : the gpio connected to the enable pin of the dio2125 - -Example: - -amp: analog-amplifier { - compatible = "dioo,dio2125"; - enable-gpios = <&gpio GPIOH_3 0>; -}; diff --git a/Documentation/devicetree/bindings/sound/simple-amplifier.txt b/Documentation/devicetree/bindings/sound/simple-amplifier.txt new file mode 100644 index 000000000000..8647edae7af0 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/simple-amplifier.txt @@ -0,0 +1,12 @@ +Simple Amplifier Audio Driver + +Required properties: +- compatible : "dioo,dio2125" or "simple-audio-amplifier" +- enable-gpios : the gpio connected to the enable pin of the simple amplifier + +Example: + +amp: analog-amplifier { + compatible = "simple-audio-amplifier"; + enable-gpios = <&gpio GPIOH_3 0>; +}; -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] ASoC: simple-amplifier: rename dio2125 to simple-amplifer 2018-06-26 12:11 [PATCH 0/3] ASoC: add simple-amplifier Jerome Brunet 2018-06-26 12:11 ` [PATCH 1/3] ASoC: simple-amplifier: remame dio2125 documentation Jerome Brunet @ 2018-06-26 12:11 ` Jerome Brunet 2018-06-26 12:11 ` [PATCH 3/3] ASoC: simple-amplifer: add simple-amplifier compatible Jerome Brunet 2 siblings, 0 replies; 6+ messages in thread From: Jerome Brunet @ 2018-06-26 12:11 UTC (permalink / raw) To: Mark Brown, Liam Girdwood, Nicolò Veronese Cc: Jerome Brunet, linux-kernel, devicetree, alsa-devel The dio2125 is simple enough that we can make it a generic component. Just rename and sed the dio2125 amplifier driver to simple_amplifier. Suggested-by: Nicolò Veronese <nicveronese@gmail.com> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- sound/soc/codecs/Kconfig | 10 +++--- sound/soc/codecs/Makefile | 4 +-- sound/soc/codecs/{dio2125.c => simple-amplifier.c} | 41 +++++++++++----------- 3 files changed, 28 insertions(+), 27 deletions(-) rename sound/soc/codecs/{dio2125.c => simple-amplifier.c} (69%) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 63cf62e9c9aa..1d2ddb528fd2 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -74,7 +74,6 @@ config SND_SOC_ALL_CODECS select SND_SOC_DA7219 if I2C select SND_SOC_DA732X if I2C select SND_SOC_DA9055 if I2C - select SND_SOC_DIO2125 select SND_SOC_DMIC if GPIOLIB select SND_SOC_ES8316 if I2C select SND_SOC_ES8328_SPI if SPI_MASTER @@ -143,6 +142,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_RT5677 if I2C && SPI_MASTER select SND_SOC_SGTL5000 if I2C select SND_SOC_SI476X if MFD_SI476X_CORE + select SND_SOC_SIMPLE_AMPLIFIER select SND_SOC_SIRF_AUDIO_CODEC select SND_SOC_SPDIF select SND_SOC_SSM2305 @@ -572,10 +572,6 @@ config SND_SOC_DA732X config SND_SOC_DA9055 tristate -config SND_SOC_DIO2125 - tristate "Dioo DIO2125 Amplifier" - select GPIOLIB - config SND_SOC_DMIC tristate @@ -891,6 +887,10 @@ config SND_SOC_SIGMADSP_REGMAP tristate select SND_SOC_SIGMADSP +config SND_SOC_SIMPLE_AMPLIFIER + tristate "Simple Audio Amplifier" + select GPIOLIB + config SND_SOC_SIRF_AUDIO_CODEC tristate "SiRF SoC internal audio codec" select REGMAP_MMIO diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile index e023fdf85221..6cc15d1c5767 100644 --- a/sound/soc/codecs/Makefile +++ b/sound/soc/codecs/Makefile @@ -249,9 +249,9 @@ snd-soc-wm9713-objs := wm9713.o snd-soc-wm-hubs-objs := wm_hubs.o snd-soc-zx-aud96p22-objs := zx_aud96p22.o # Amp -snd-soc-dio2125-objs := dio2125.o snd-soc-max9877-objs := max9877.o snd-soc-max98504-objs := max98504.o +snd-soc-simple-amplifier-objs := simple-amplifier.o snd-soc-tpa6130a2-objs := tpa6130a2.o snd-soc-tas2552-objs := tas2552.o @@ -507,7 +507,7 @@ obj-$(CONFIG_SND_SOC_WM_HUBS) += snd-soc-wm-hubs.o obj-$(CONFIG_SND_SOC_ZX_AUD96P22) += snd-soc-zx-aud96p22.o # Amp -obj-$(CONFIG_SND_SOC_DIO2125) += snd-soc-dio2125.o obj-$(CONFIG_SND_SOC_MAX9877) += snd-soc-max9877.o obj-$(CONFIG_SND_SOC_MAX98504) += snd-soc-max98504.o +obj-$(CONFIG_SND_SOC_SIMPLE_AMPLIFIER) += snd-soc-simple-amplifier.o obj-$(CONFIG_SND_SOC_TPA6130A2) += snd-soc-tpa6130a2.o diff --git a/sound/soc/codecs/dio2125.c b/sound/soc/codecs/simple-amplifier.c similarity index 69% rename from sound/soc/codecs/dio2125.c rename to sound/soc/codecs/simple-amplifier.c index 09451cd44f9b..6c27d4afaf3a 100644 --- a/sound/soc/codecs/dio2125.c +++ b/sound/soc/codecs/simple-amplifier.c @@ -21,9 +21,9 @@ #include <linux/module.h> #include <sound/soc.h> -#define DRV_NAME "dio2125" +#define DRV_NAME "simple-amplifier" -struct dio2125 { +struct simple_amp { struct gpio_desc *gpiod_enable; }; @@ -31,7 +31,7 @@ static int drv_event(struct snd_soc_dapm_widget *w, struct snd_kcontrol *control, int event) { struct snd_soc_component *c = snd_soc_dapm_to_component(w->dapm); - struct dio2125 *priv = snd_soc_component_get_drvdata(c); + struct simple_amp *priv = snd_soc_component_get_drvdata(c); int val; switch (event) { @@ -51,7 +51,7 @@ static int drv_event(struct snd_soc_dapm_widget *w, return 0; } -static const struct snd_soc_dapm_widget dio2125_dapm_widgets[] = { +static const struct snd_soc_dapm_widget simple_amp_dapm_widgets[] = { SND_SOC_DAPM_INPUT("INL"), SND_SOC_DAPM_INPUT("INR"), SND_SOC_DAPM_OUT_DRV_E("DRV", SND_SOC_NOPM, 0, 0, NULL, 0, drv_event, @@ -60,24 +60,24 @@ static const struct snd_soc_dapm_widget dio2125_dapm_widgets[] = { SND_SOC_DAPM_OUTPUT("OUTR"), }; -static const struct snd_soc_dapm_route dio2125_dapm_routes[] = { +static const struct snd_soc_dapm_route simple_amp_dapm_routes[] = { { "DRV", NULL, "INL" }, { "DRV", NULL, "INR" }, { "OUTL", NULL, "DRV" }, { "OUTR", NULL, "DRV" }, }; -static const struct snd_soc_component_driver dio2125_component_driver = { - .dapm_widgets = dio2125_dapm_widgets, - .num_dapm_widgets = ARRAY_SIZE(dio2125_dapm_widgets), - .dapm_routes = dio2125_dapm_routes, - .num_dapm_routes = ARRAY_SIZE(dio2125_dapm_routes), +static const struct snd_soc_component_driver simple_amp_component_driver = { + .dapm_widgets = simple_amp_dapm_widgets, + .num_dapm_widgets = ARRAY_SIZE(simple_amp_dapm_widgets), + .dapm_routes = simple_amp_dapm_routes, + .num_dapm_routes = ARRAY_SIZE(simple_amp_dapm_routes), }; -static int dio2125_probe(struct platform_device *pdev) +static int simple_amp_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct dio2125 *priv; + struct simple_amp *priv; int err; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); @@ -93,28 +93,29 @@ static int dio2125_probe(struct platform_device *pdev) return err; } - return devm_snd_soc_register_component(dev, &dio2125_component_driver, + return devm_snd_soc_register_component(dev, + &simple_amp_component_driver, NULL, 0); } #ifdef CONFIG_OF -static const struct of_device_id dio2125_ids[] = { +static const struct of_device_id simple_amp_ids[] = { { .compatible = "dioo,dio2125", }, { } }; -MODULE_DEVICE_TABLE(of, dio2125_ids); +MODULE_DEVICE_TABLE(of, simple_amp_ids); #endif -static struct platform_driver dio2125_driver = { +static struct platform_driver simple_amp_driver = { .driver = { .name = DRV_NAME, - .of_match_table = of_match_ptr(dio2125_ids), + .of_match_table = of_match_ptr(simple_amp_ids), }, - .probe = dio2125_probe, + .probe = simple_amp_probe, }; -module_platform_driver(dio2125_driver); +module_platform_driver(simple_amp_driver); -MODULE_DESCRIPTION("ASoC DIO2125 output driver"); +MODULE_DESCRIPTION("ASoC Simple Audio Amplifier driver"); MODULE_AUTHOR("Jerome Brunet <jbrunet@baylibre.com>"); MODULE_LICENSE("GPL"); -- 2.14.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] ASoC: simple-amplifer: add simple-amplifier compatible 2018-06-26 12:11 [PATCH 0/3] ASoC: add simple-amplifier Jerome Brunet 2018-06-26 12:11 ` [PATCH 1/3] ASoC: simple-amplifier: remame dio2125 documentation Jerome Brunet 2018-06-26 12:11 ` [PATCH 2/3] ASoC: simple-amplifier: rename dio2125 to simple-amplifer Jerome Brunet @ 2018-06-26 12:11 ` Jerome Brunet 2018-06-27 11:30 ` Applied "ASoC: simple-amplifer: add simple-amplifier compatible" to the asoc tree Mark Brown 2 siblings, 1 reply; 6+ messages in thread From: Jerome Brunet @ 2018-06-26 12:11 UTC (permalink / raw) To: Mark Brown, Liam Girdwood, Nicolò Veronese Cc: Jerome Brunet, linux-kernel, devicetree, alsa-devel Add simple-audio-amplifier to the list of available compatible Suggested-by: Nicolò Veronese <nicveronese@gmail.com> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- sound/soc/codecs/simple-amplifier.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/simple-amplifier.c b/sound/soc/codecs/simple-amplifier.c index 6c27d4afaf3a..85524acf3e9c 100644 --- a/sound/soc/codecs/simple-amplifier.c +++ b/sound/soc/codecs/simple-amplifier.c @@ -101,6 +101,7 @@ static int simple_amp_probe(struct platform_device *pdev) #ifdef CONFIG_OF static const struct of_device_id simple_amp_ids[] = { { .compatible = "dioo,dio2125", }, + { .compatible = "simple-audio-amplifier", }, { } }; MODULE_DEVICE_TABLE(of, simple_amp_ids); -- 2.14.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Applied "ASoC: simple-amplifer: add simple-amplifier compatible" to the asoc tree 2018-06-26 12:11 ` [PATCH 3/3] ASoC: simple-amplifer: add simple-amplifier compatible Jerome Brunet @ 2018-06-27 11:30 ` Mark Brown 0 siblings, 0 replies; 6+ messages in thread From: Mark Brown @ 2018-06-27 11:30 UTC (permalink / raw) To: Jerome Brunet Cc: Mark Brown, Mark Brown, Liam Girdwood, Nicolò Veronese, devicetree, alsa-devel, linux-kernel, alsa-devel [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain, Size: 2068 bytes --] The patch ASoC: simple-amplifer: add simple-amplifier compatible has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 8ed237e83ce9ff4b3964a6b096beb1cbd3397d5a Mon Sep 17 00:00:00 2001 From: Jerome Brunet <jbrunet@baylibre.com> Date: Tue, 26 Jun 2018 14:11:28 +0200 Subject: [PATCH] ASoC: simple-amplifer: add simple-amplifier compatible MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add simple-audio-amplifier to the list of available compatible Suggested-by: Nicolò Veronese <nicveronese@gmail.com> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/codecs/simple-amplifier.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/simple-amplifier.c b/sound/soc/codecs/simple-amplifier.c index 6c27d4afaf3a..85524acf3e9c 100644 --- a/sound/soc/codecs/simple-amplifier.c +++ b/sound/soc/codecs/simple-amplifier.c @@ -101,6 +101,7 @@ static int simple_amp_probe(struct platform_device *pdev) #ifdef CONFIG_OF static const struct of_device_id simple_amp_ids[] = { { .compatible = "dioo,dio2125", }, + { .compatible = "simple-audio-amplifier", }, { } }; MODULE_DEVICE_TABLE(of, simple_amp_ids); -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-27 11:30 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-06-26 12:11 [PATCH 0/3] ASoC: add simple-amplifier Jerome Brunet 2018-06-26 12:11 ` [PATCH 1/3] ASoC: simple-amplifier: remame dio2125 documentation Jerome Brunet 2018-06-27 11:30 ` Applied "ASoC: simple-amplifier: remame dio2125 documentation" to the asoc tree Mark Brown 2018-06-26 12:11 ` [PATCH 2/3] ASoC: simple-amplifier: rename dio2125 to simple-amplifer Jerome Brunet 2018-06-26 12:11 ` [PATCH 3/3] ASoC: simple-amplifer: add simple-amplifier compatible Jerome Brunet 2018-06-27 11:30 ` Applied "ASoC: simple-amplifer: add simple-amplifier compatible" to the asoc tree Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).