From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: GaoMing <gaoming20@huawei.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
sorp.liqingchao@huawei.com, harry.shen@huawei.com,
miaoxie@huawei.com
Subject: Re: [PATCH] ext4: e2fsprogs: fix inode bitmap num not integer,incompatible for ancient android devices
Date: Wed, 27 Jun 2018 10:09:37 -0400 [thread overview]
Message-ID: <20180627140937.GA3348@thunk.org> (raw)
In-Reply-To: <1530014046-62466-1-git-send-email-gaoming20@huawei.com>
On Tue, Jun 26, 2018 at 07:54:06PM +0800, GaoMing wrote:
> for example, 1708 inodes every group,3 block groups, bitmap bytes are 1708/8=213.5 when the inode bitmap has some errors, e2fsprogs cannot fix it
>
> Signed-off-by: GaoMing <gaoming20@huawei.com>
File systems like this should not exist. Can you please please please
make sure that any use of make_ext2fs are ripped out by the roots?
What I *should* do is have e2fsck reject these file systems as
completely invalid in pass 0, when we check for superblock sanity. I
haven't because there are some older Android systems that use
make_ext2fs. But at this point, what I am **seriously** doing is to
make e2fsck reject these file systems by default, unless a setting in
e2fsck.conf is set to allow them as an exception.
My concern about applying this patch is that it will be taken as
acceptance of e2fsprogs to fully support these sorts of invalid file
systems. In particular, there is no guarantee that various tune2fs
options, resize2fs, etc., will work correctly even with your patch.
- Ted
next prev parent reply other threads:[~2018-06-27 14:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 11:54 [PATCH] ext4: e2fsprogs: fix inode bitmap num not integer,incompatible for ancient android devices GaoMing
2018-06-27 14:09 ` Theodore Y. Ts'o [this message]
2018-06-28 1:40 ` 答复: " Gaoming (ming, consumer BG)
2018-06-28 2:29 ` Theodore Y. Ts'o
2018-06-28 7:56 ` 答复: " Gaoming (ming, consumer BG)
2018-06-28 15:30 ` Theodore Y. Ts'o
2018-06-29 2:06 ` 答复: " Gaoming (ming, consumer BG)
2018-06-29 14:26 ` Theodore Y. Ts'o
2018-06-30 1:26 ` 答复: " Gaoming (ming, consumer BG)
2018-06-30 13:04 ` Theodore Y. Ts'o
2018-07-02 9:34 ` 答复: " Gaoming (ming, consumer BG)
2018-07-02 12:16 ` Theodore Y. Ts'o
2018-07-03 0:58 ` 答复: " Gaoming (ming, consumer BG)
2018-07-03 10:35 ` Theodore Y. Ts'o
2018-07-03 11:15 ` 答复: " Gaoming (ming, consumer BG)
2018-07-03 16:03 ` Theodore Y. Ts'o
2018-07-04 1:54 ` 答复: " Gaoming (ming, consumer BG)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627140937.GA3348@thunk.org \
--to=tytso@mit.edu \
--cc=gaoming20@huawei.com \
--cc=harry.shen@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=sorp.liqingchao@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).