答复: 答复: [PATCH] ext4: e2fsprogs: fix inode bitmap num not integer,incompatible for ancient android devices

From: "Gaoming (ming, consumer BG)" <gaoming20@huawei.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Liqingchao (sorp)" <sorp.liqingchao@huawei.com>,
	"Shenchen (harry)" <harry.shen@huawei.com>,
	"miaoxie (A)" <miaoxie@huawei.com>,
	"yangfei (D)" <yangfei39@huawei.com>,
	"Renlipeng (OS driver)" <renlipeng@huawei.com>
Subject: 答复: 答复: [PATCH] ext4: e2fsprogs: fix inode bitmap num not integer,incompatible for ancient android devices
Date: Thu, 28 Jun 2018 07:56:59 +0000	[thread overview]
Message-ID: <FDC91B229D965C458E3615E98C48ADDD0EC416E8@dggemm511-mbx.china.huawei.com> (raw)
In-Reply-To: <20180628022900.GA663@thunk.org>

Hi,

I have cloned the repo /system/extras on master branch.
git clone https://android.googlesource.com/platform/system/extras && (cd extras && curl -Lo `git rev-parse --git-dir`/hooks/commit-msg https://gerrit-review.googlesource.com/tools/hooks/commit-msg ; chmod +x `git rev-parse --git-dir`/hooks/commit-msg)
and 
git checkout git checkout 9c27970d142dc14b1e82b1d6f9fa827f994609b6 -b tmp
//this means rollback to the version before make_ext4fs code was deleted on Jun 21th 2018.

And copy the codes to android project, then compile, and produce the image. Like below,

./host/linux-x86/bin/make_ext4fs  -s -l 20M -b 1024 gaoming.img
Creating filesystem with parameters:
    Size: 20971520
    Block size: 1024
    Blocks per group: 8192
    Inodes per group: 1708
    Inode size: 256
    Journal blocks: 1024
    Label:
    Blocks: 20480
    Block groups: 3
    Reserved block group size: 95
Created filesystem with 11/5124 inodes and 2509/20480 blocks

You see, Inodes per group is 1708,which is illegal as you said.

So, the problem exists a long time until Jun 21th 2018.

You complained the problem in 2011, they do not fix it till 2018.
Just as
I complained, fix it,  and you do not accept it. ^_^

Regards,
Ming

-----邮件原件-----
发件人: Theodore Y. Ts'o [mailto:tytso@mit.edu] 
发送时间: 2018年6月28日 10:29
收件人: Gaoming (ming, consumer BG)
抄送: linux-ext4@vger.kernel.org; linux-kernel@vger.kernel.org; Liqingchao (sorp); Shenchen (harry); miaoxie (A); yangfei (D)
主题: Re: 答复: [PATCH] ext4: e2fsprogs: fix inode bitmap num not integer,incompatible for ancient android devices

On Thu, Jun 28, 2018 at 01:40:30AM +0000, Gaoming (ming, consumer BG) wrote:
> Hi tytso,
> 
> I have checked that make_ext4fs code was deleted o Jun 21th 2018 on master branch of /system/extras repository.
> e.g. 
> https://android-review.googlesource.com/c/platform/system/extras/+/708003

Make_ext4fs was fixed not create invalid file systems a *long* time
ago.  What I'm not sure about is why the patch hasn't gotten out to
more Android manufacters sooner.

It should have been fixed by sometime in 2012 --- I complained to the
Android team in early 2011.  What I don't understand is why people are
coming out of the woodwork *now*.

					- Ted