* [PATCH v5] tpm: Return the actual size when receiving an unsupported command
@ 2018-06-26 15:31 Ricardo Schwarzmeier
2018-06-29 11:31 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Schwarzmeier @ 2018-06-26 15:31 UTC (permalink / raw)
To: linux-integrity
Cc: linux-kernel, peterhuewe, jarkko.sakkinen, jgg, arnd, gregkh,
Ricardo Schwarzmeier
The userpace expects to read the number of bytes stated in the header.
Returning the size of the buffer instead would be unexpected.
Fixes: 095531f891e6 ("tpm: return a TPM_RC_COMMAND_CODE response if command is not implemented")
Signed-off-by: Ricardo Schwarzmeier <Ricardo.Schwarzmeier@infineon.com>
---
v2: *Add fixes tag
v3: *Avoid endianness problem
*Make commit message more clear
v4: *Fix commit message style
v5: *Add change log
drivers/char/tpm/tpm-interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
index e32f6e85dc6d..7f2e2d54894d 100644
--- a/drivers/char/tpm/tpm-interface.c
+++ b/drivers/char/tpm/tpm-interface.c
@@ -423,7 +423,7 @@ static ssize_t tpm_try_transmit(struct tpm_chip *chip,
header->tag = cpu_to_be16(TPM2_ST_NO_SESSIONS);
header->return_code = cpu_to_be32(TPM2_RC_COMMAND_CODE |
TSS2_RESMGR_TPM_RC_LAYER);
- return bufsiz;
+ return sizeof(*header);
}
if (bufsiz > TPM_BUFSIZE)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v5] tpm: Return the actual size when receiving an unsupported command
2018-06-26 15:31 [PATCH v5] tpm: Return the actual size when receiving an unsupported command Ricardo Schwarzmeier
@ 2018-06-29 11:31 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2018-06-29 11:31 UTC (permalink / raw)
To: Ricardo Schwarzmeier
Cc: linux-integrity, linux-kernel, peterhuewe, jgg, arnd, gregkh
On Tue, Jun 26, 2018 at 05:31:45PM +0200, Ricardo Schwarzmeier wrote:
> The userpace expects to read the number of bytes stated in the header.
> Returning the size of the buffer instead would be unexpected.
> Fixes: 095531f891e6 ("tpm: return a TPM_RC_COMMAND_CODE response if command is not implemented")
>
> Signed-off-by: Ricardo Schwarzmeier <Ricardo.Schwarzmeier@infineon.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-29 11:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-26 15:31 [PATCH v5] tpm: Return the actual size when receiving an unsupported command Ricardo Schwarzmeier
2018-06-29 11:31 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).