* [PATCH] platform/x86: dell-smbios-wmi: make function dell_smbios_wmi_call static
@ 2018-06-30 12:10 Colin King
2018-07-02 13:15 ` Andy Shevchenko
2018-07-02 13:33 ` Mario.Limonciello
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2018-06-30 12:10 UTC (permalink / raw)
To: Mario Limonciello, Darren Hart, Andy Shevchenko, platform-driver-x86
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function dell_smbios_wmi_call is local to the source and does not
need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'dell_smbios_wmi_call' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/platform/x86/dell-smbios-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/dell-smbios-wmi.c b/drivers/platform/x86/dell-smbios-wmi.c
index fbefedb1c172..88afe5651d24 100644
--- a/drivers/platform/x86/dell-smbios-wmi.c
+++ b/drivers/platform/x86/dell-smbios-wmi.c
@@ -82,7 +82,7 @@ static int run_smbios_call(struct wmi_device *wdev)
return 0;
}
-int dell_smbios_wmi_call(struct calling_interface_buffer *buffer)
+static int dell_smbios_wmi_call(struct calling_interface_buffer *buffer)
{
struct wmi_smbios_priv *priv;
size_t difference;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: dell-smbios-wmi: make function dell_smbios_wmi_call static
2018-06-30 12:10 [PATCH] platform/x86: dell-smbios-wmi: make function dell_smbios_wmi_call static Colin King
@ 2018-07-02 13:15 ` Andy Shevchenko
2018-07-02 13:33 ` Mario.Limonciello
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2018-07-02 13:15 UTC (permalink / raw)
To: Colin King
Cc: Mario Limonciello, Darren Hart, Andy Shevchenko, Platform Driver,
kernel-janitors, Linux Kernel Mailing List
On Sat, Jun 30, 2018 at 3:10 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function dell_smbios_wmi_call is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'dell_smbios_wmi_call' was not declared. Should it be static?
>
Pushed to my review and testing queue, thanks!
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/platform/x86/dell-smbios-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell-smbios-wmi.c b/drivers/platform/x86/dell-smbios-wmi.c
> index fbefedb1c172..88afe5651d24 100644
> --- a/drivers/platform/x86/dell-smbios-wmi.c
> +++ b/drivers/platform/x86/dell-smbios-wmi.c
> @@ -82,7 +82,7 @@ static int run_smbios_call(struct wmi_device *wdev)
> return 0;
> }
>
> -int dell_smbios_wmi_call(struct calling_interface_buffer *buffer)
> +static int dell_smbios_wmi_call(struct calling_interface_buffer *buffer)
> {
> struct wmi_smbios_priv *priv;
> size_t difference;
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] platform/x86: dell-smbios-wmi: make function dell_smbios_wmi_call static
2018-06-30 12:10 [PATCH] platform/x86: dell-smbios-wmi: make function dell_smbios_wmi_call static Colin King
2018-07-02 13:15 ` Andy Shevchenko
@ 2018-07-02 13:33 ` Mario.Limonciello
1 sibling, 0 replies; 3+ messages in thread
From: Mario.Limonciello @ 2018-07-02 13:33 UTC (permalink / raw)
To: colin.king, dvhart, andy, platform-driver-x86
Cc: kernel-janitors, linux-kernel
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Saturday, June 30, 2018 7:10 AM
> To: Limonciello, Mario; Darren Hart; Andy Shevchenko; platform-driver-
> x86@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] platform/x86: dell-smbios-wmi: make function
> dell_smbios_wmi_call static
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The function dell_smbios_wmi_call is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'dell_smbios_wmi_call' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Same vain as the other one of these, makes sense to me.
Acked-by: Mario Limonciello <mario.limonciello@dell.com>
> ---
> drivers/platform/x86/dell-smbios-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell-smbios-wmi.c b/drivers/platform/x86/dell-
> smbios-wmi.c
> index fbefedb1c172..88afe5651d24 100644
> --- a/drivers/platform/x86/dell-smbios-wmi.c
> +++ b/drivers/platform/x86/dell-smbios-wmi.c
> @@ -82,7 +82,7 @@ static int run_smbios_call(struct wmi_device *wdev)
> return 0;
> }
>
> -int dell_smbios_wmi_call(struct calling_interface_buffer *buffer)
> +static int dell_smbios_wmi_call(struct calling_interface_buffer *buffer)
> {
> struct wmi_smbios_priv *priv;
> size_t difference;
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-02 13:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-30 12:10 [PATCH] platform/x86: dell-smbios-wmi: make function dell_smbios_wmi_call static Colin King
2018-07-02 13:15 ` Andy Shevchenko
2018-07-02 13:33 ` Mario.Limonciello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).