* [PATCH v4] ata: Remove depends on HAS_DMA in case of platform dependency
@ 2018-06-22 11:03 Geert Uytterhoeven
2018-07-02 16:12 ` Tejun Heo
2018-07-02 20:18 ` Tejun Heo
0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-06-22 11:03 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide, linux-kernel, Geert Uytterhoeven
Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
In most cases this other symbol is an architecture or platform specific
symbol, or PCI.
Generic symbols and drivers without platform dependencies keep their
dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
cannot work anyway.
This simplifies the dependencies, and allows to improve compile-testing.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Mark Brown <broonie@kernel.org>
Acked-by: Robin Murphy <robin.murphy@arm.com>
---
v4:
- Rebase to v4.18-rc1 (applies to next-20180622, too),
v3:
- Rebase to v4.17-rc1,
v2:
- Add Reviewed-by, Acked-by,
- Drop RFC state,
- Split per subsystem.
---
drivers/ata/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 2b16e7c8fff35764..39b181d6bd0d8cf2 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -398,7 +398,6 @@ config SATA_DWC_VDEBUG
config SATA_HIGHBANK
tristate "Calxeda Highbank SATA support"
- depends on HAS_DMA
depends on ARCH_HIGHBANK || COMPILE_TEST
help
This option enables support for the Calxeda Highbank SoC's
@@ -408,7 +407,6 @@ config SATA_HIGHBANK
config SATA_MV
tristate "Marvell SATA support"
- depends on HAS_DMA
depends on PCI || ARCH_DOVE || ARCH_MV78XX0 || \
ARCH_MVEBU || ARCH_ORION5X || COMPILE_TEST
select GENERIC_PHY
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v4] ata: Remove depends on HAS_DMA in case of platform dependency
2018-06-22 11:03 [PATCH v4] ata: Remove depends on HAS_DMA in case of platform dependency Geert Uytterhoeven
@ 2018-07-02 16:12 ` Tejun Heo
2018-07-02 20:04 ` Geert Uytterhoeven
2018-07-02 20:18 ` Tejun Heo
1 sibling, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2018-07-02 16:12 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-ide, linux-kernel
On Fri, Jun 22, 2018 at 01:03:07PM +0200, Geert Uytterhoeven wrote:
> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
> In most cases this other symbol is an architecture or platform specific
> symbol, or PCI.
>
> Generic symbols and drivers without platform dependencies keep their
> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
> cannot work anyway.
>
> This simplifies the dependencies, and allows to improve compile-testing.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Mark Brown <broonie@kernel.org>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
This looks fine to me but how do you wanna route it? Should I apply
it to for-4.18-fixes or should it go with arch changes in some other
tree?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] ata: Remove depends on HAS_DMA in case of platform dependency
2018-07-02 16:12 ` Tejun Heo
@ 2018-07-02 20:04 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-07-02 20:04 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide, Linux Kernel Mailing List
Hi Tejun,
On Mon, Jul 2, 2018 at 6:12 PM Tejun Heo <tj@kernel.org> wrote:
> On Fri, Jun 22, 2018 at 01:03:07PM +0200, Geert Uytterhoeven wrote:
> > Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
> > symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
> > In most cases this other symbol is an architecture or platform specific
> > symbol, or PCI.
> >
> > Generic symbols and drivers without platform dependencies keep their
> > dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
> > cannot work anyway.
> >
> > This simplifies the dependencies, and allows to improve compile-testing.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Reviewed-by: Mark Brown <broonie@kernel.org>
> > Acked-by: Robin Murphy <robin.murphy@arm.com>
>
> This looks fine to me but how do you wanna route it? Should I apply
> it to for-4.18-fixes or should it go with arch changes in some other
> tree?
Please queue it in the ata tree. There are no related arch changes.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] ata: Remove depends on HAS_DMA in case of platform dependency
2018-06-22 11:03 [PATCH v4] ata: Remove depends on HAS_DMA in case of platform dependency Geert Uytterhoeven
2018-07-02 16:12 ` Tejun Heo
@ 2018-07-02 20:18 ` Tejun Heo
1 sibling, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2018-07-02 20:18 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-ide, linux-kernel
On Fri, Jun 22, 2018 at 01:03:07PM +0200, Geert Uytterhoeven wrote:
> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
> In most cases this other symbol is an architecture or platform specific
> symbol, or PCI.
>
> Generic symbols and drivers without platform dependencies keep their
> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
> cannot work anyway.
>
> This simplifies the dependencies, and allows to improve compile-testing.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Mark Brown <broonie@kernel.org>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
Applied to libata/for-4.18-fixes.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-02 20:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-22 11:03 [PATCH v4] ata: Remove depends on HAS_DMA in case of platform dependency Geert Uytterhoeven
2018-07-02 16:12 ` Tejun Heo
2018-07-02 20:04 ` Geert Uytterhoeven
2018-07-02 20:18 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).