* [PATCH v2 0/2] clk: meson-axg: add pcie related clocks @ 2018-07-02 21:31 Yixun Lan 2018-07-02 21:31 ` [PATCH v2 1/2] clk: meson-axg: add pcie and mipi clock bindings Yixun Lan 2018-07-02 21:31 ` [PATCH v2 2/2] clk: meson-axg: add clocks required by pcie driver Yixun Lan 0 siblings, 2 replies; 9+ messages in thread From: Yixun Lan @ 2018-07-02 21:31 UTC (permalink / raw) To: Jerome Brunet, Neil Armstrong Cc: Yixun Lan, Kevin Hilman, Carlo Caione, Michael Turquette, Stephen Boyd, Qiufang Dai, Jian Hu, Jianxin Qin, linux-clk, linux-amlogic, linux-arm-kernel, linux-kernel, devicetree This patch series try to add clocks for the pcie driver, Due to ASIC desigin, the mipi clock is also required by the pcie controller, so we also added in this patch series. Changes since v1 at [1]: -- Separate dt-binding header files -- use table to exclude unwanted clock parent [1] https://lkml.kernel.org/r/20180621122620.13195-1-yixun.lan@amlogic.com Yixun Lan (2): clk: meson-axg: add pcie and mipi clock bindings clk: meson-axg: add clocks required by pcie driver drivers/clk/meson/axg.c | 148 +++++++++++++++++++++++++++ drivers/clk/meson/axg.h | 6 +- include/dt-bindings/clock/axg-clkc.h | 3 + 3 files changed, 156 insertions(+), 1 deletion(-) -- 2.18.0 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/2] clk: meson-axg: add pcie and mipi clock bindings 2018-07-02 21:31 [PATCH v2 0/2] clk: meson-axg: add pcie related clocks Yixun Lan @ 2018-07-02 21:31 ` Yixun Lan 2018-07-03 9:20 ` Jerome Brunet 2018-07-02 21:31 ` [PATCH v2 2/2] clk: meson-axg: add clocks required by pcie driver Yixun Lan 1 sibling, 1 reply; 9+ messages in thread From: Yixun Lan @ 2018-07-02 21:31 UTC (permalink / raw) To: Jerome Brunet, Neil Armstrong Cc: Yixun Lan, Kevin Hilman, Carlo Caione, Michael Turquette, Stephen Boyd, Qiufang Dai, Jian Hu, Jianxin Qin, linux-clk, linux-amlogic, linux-arm-kernel, linux-kernel, devicetree Add the pcie and mipi clock dt-bindings for the pcie driver. Since the mipi clock isalso used by the pcie driver, we add it together in this patch. Tested-by: Jianxin Qin <jianxin.qin@amlogic.com> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> --- include/dt-bindings/clock/axg-clkc.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/dt-bindings/clock/axg-clkc.h b/include/dt-bindings/clock/axg-clkc.h index 555937a25504..70371228b7e0 100644 --- a/include/dt-bindings/clock/axg-clkc.h +++ b/include/dt-bindings/clock/axg-clkc.h @@ -68,5 +68,8 @@ #define CLKID_SD_EMMC_B_CLK0 59 #define CLKID_SD_EMMC_C_CLK0 60 #define CLKID_HIFI_PLL 69 +#define CLKID_PCIE_CML_EN0 79 +#define CLKID_PCIE_CML_EN1 80 +#define CLKID_MIPI_ENABLE 81 #endif /* __AXG_CLKC_H */ -- 2.18.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] clk: meson-axg: add pcie and mipi clock bindings 2018-07-02 21:31 ` [PATCH v2 1/2] clk: meson-axg: add pcie and mipi clock bindings Yixun Lan @ 2018-07-03 9:20 ` Jerome Brunet 0 siblings, 0 replies; 9+ messages in thread From: Jerome Brunet @ 2018-07-03 9:20 UTC (permalink / raw) To: Yixun Lan, Neil Armstrong Cc: Kevin Hilman, Carlo Caione, Michael Turquette, Stephen Boyd, Qiufang Dai, Jian Hu, Jianxin Qin, linux-clk, linux-amlogic, linux-arm-kernel, linux-kernel, devicetree On Mon, 2018-07-02 at 21:31 +0000, Yixun Lan wrote: > Add the pcie and mipi clock dt-bindings for the pcie driver. > > Since the mipi clock isalso used by the pcie driver, > we add it together in this patch. > > Tested-by: Jianxin Qin <jianxin.qin@amlogic.com> > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> > --- > include/dt-bindings/clock/axg-clkc.h | 3 +++ > 1 file changed, 3 insertions(+) Applied. Thx ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] clk: meson-axg: add clocks required by pcie driver 2018-07-02 21:31 [PATCH v2 0/2] clk: meson-axg: add pcie related clocks Yixun Lan 2018-07-02 21:31 ` [PATCH v2 1/2] clk: meson-axg: add pcie and mipi clock bindings Yixun Lan @ 2018-07-02 21:31 ` Yixun Lan 2018-07-03 9:24 ` Jerome Brunet 1 sibling, 1 reply; 9+ messages in thread From: Yixun Lan @ 2018-07-02 21:31 UTC (permalink / raw) To: Jerome Brunet, Neil Armstrong Cc: Yixun Lan, Kevin Hilman, Carlo Caione, Michael Turquette, Stephen Boyd, Qiufang Dai, Jian Hu, Jianxin Qin, linux-clk, linux-amlogic, linux-arm-kernel, linux-kernel Adding clocks for the pcie driver. Due to the ASIC design, the pcie controller re-use part of the mipi clock logic, so the mipi clock is also added. Tested-by: Jianxin Qin <jianxin.qin@amlogic.com> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> --- drivers/clk/meson/axg.c | 148 ++++++++++++++++++++++++++++++++++++++++ drivers/clk/meson/axg.h | 6 +- 2 files changed, 153 insertions(+), 1 deletion(-) diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index 3fb884db1b10..aa7de8752231 100644 --- a/drivers/clk/meson/axg.c +++ b/drivers/clk/meson/axg.c @@ -625,6 +625,140 @@ static struct clk_regmap axg_mpll3 = { }, }; +static const struct pll_rate_table axg_pcie_pll_rate_table[] = { + { + .rate = 100000000, + .m = 200, + .n = 3, + .od = 1, + .od2 = 3, + }, + { /* sentinel */ }, +}; + +static const struct reg_sequence axg_pcie_init_regs[] = { + { .reg = HHI_PCIE_PLL_CNTL, .def = 0x400106c8 }, + { .reg = HHI_PCIE_PLL_CNTL1, .def = 0x0084a2aa }, + { .reg = HHI_PCIE_PLL_CNTL2, .def = 0xb75020be }, + { .reg = HHI_PCIE_PLL_CNTL3, .def = 0x0a47488e }, + { .reg = HHI_PCIE_PLL_CNTL4, .def = 0xc000004d }, + { .reg = HHI_PCIE_PLL_CNTL5, .def = 0x00078000 }, + { .reg = HHI_PCIE_PLL_CNTL6, .def = 0x002323c6 }, +}; + +static struct clk_regmap axg_pcie_pll = { + .data = &(struct meson_clk_pll_data){ + .m = { + .reg_off = HHI_PCIE_PLL_CNTL, + .shift = 0, + .width = 9, + }, + .n = { + .reg_off = HHI_PCIE_PLL_CNTL, + .shift = 9, + .width = 5, + }, + .od = { + .reg_off = HHI_PCIE_PLL_CNTL, + .shift = 16, + .width = 2, + }, + .od2 = { + .reg_off = HHI_PCIE_PLL_CNTL6, + .shift = 6, + .width = 2, + }, + .frac = { + .reg_off = HHI_PCIE_PLL_CNTL1, + .shift = 0, + .width = 12, + }, + .l = { + .reg_off = HHI_PCIE_PLL_CNTL, + .shift = 31, + .width = 1, + }, + .rst = { + .reg_off = HHI_PCIE_PLL_CNTL, + .shift = 29, + .width = 1, + }, + .table = axg_pcie_pll_rate_table, + .init_regs = axg_pcie_init_regs, + .init_count = ARRAY_SIZE(axg_pcie_init_regs), + }, + .hw.init = &(struct clk_init_data){ + .name = "pcie_pll", + .ops = &meson_clk_pll_ops, + .parent_names = (const char *[]){ "xtal" }, + .num_parents = 1, + }, +}; + +static struct clk_regmap axg_pcie_mux = { + .data = &(struct clk_regmap_mux_data){ + .offset = HHI_PCIE_PLL_CNTL6, + .mask = 0x1, + .shift = 2, + }, + .hw.init = &(struct clk_init_data){ + .name = "pcie_mux", + .ops = &clk_regmap_mux_ops, + .parent_names = (const char *[]){ "mpll3", "pcie_pll" }, + .num_parents = 2, + .flags = CLK_SET_RATE_PARENT, + }, +}; + +/* skip the partent 0, it's for debug only */ +static u32 mux_table_pcie_ref[] = { 1 }; +static const char * const pcie_ref_parent_names[] = { "pcie_mux" }; + +static struct clk_regmap axg_pcie_ref = { + .data = &(struct clk_regmap_mux_data){ + .offset = HHI_PCIE_PLL_CNTL6, + .mask = 0x1, + .shift = 1, + .table = mux_table_pcie_ref, + }, + .hw.init = &(struct clk_init_data){ + .name = "pcie_ref", + .ops = &clk_regmap_mux_ops, + .parent_names = pcie_ref_parent_names, + .num_parents = ARRAY_SIZE(pcie_ref_parent_names), + .flags = CLK_SET_RATE_PARENT, + }, +}; + +static struct clk_regmap axg_pcie_cml_en0 = { + .data = &(struct clk_regmap_gate_data){ + .offset = HHI_PCIE_PLL_CNTL6, + .bit_idx = 4, + }, + .hw.init = &(struct clk_init_data) { + .name = "pcie_cml_en0", + .ops = &clk_regmap_gate_ops, + .parent_names = (const char *[]){ "pcie_ref" }, + .num_parents = 1, + .flags = CLK_SET_RATE_PARENT, + + }, +}; + +static struct clk_regmap axg_pcie_cml_en1 = { + .data = &(struct clk_regmap_gate_data){ + .offset = HHI_PCIE_PLL_CNTL6, + .bit_idx = 3, + }, + .hw.init = &(struct clk_init_data) { + .name = "pcie_cml_en1", + .ops = &clk_regmap_gate_ops, + .parent_names = (const char *[]){ "pcie_ref" }, + .num_parents = 1, + .flags = CLK_SET_RATE_PARENT, + }, +}; + static u32 mux_table_clk81[] = { 0, 2, 3, 4, 5, 6, 7 }; static const char * const clk81_parent_names[] = { "xtal", "fclk_div7", "mpll1", "mpll2", "fclk_div4", @@ -820,6 +954,7 @@ static MESON_GATE(axg_mmc_pclk, HHI_GCLK_MPEG2, 11); static MESON_GATE(axg_vpu_intr, HHI_GCLK_MPEG2, 25); static MESON_GATE(axg_sec_ahb_ahb3_bridge, HHI_GCLK_MPEG2, 26); static MESON_GATE(axg_gic, HHI_GCLK_MPEG2, 30); +static MESON_GATE(axg_mipi_enable, HHI_MIPI_CNTL0, 29); /* Always On (AO) domain gates */ @@ -909,6 +1044,13 @@ static struct clk_hw_onecell_data axg_hw_onecell_data = { [CLKID_FCLK_DIV4_DIV] = &axg_fclk_div4_div.hw, [CLKID_FCLK_DIV5_DIV] = &axg_fclk_div5_div.hw, [CLKID_FCLK_DIV7_DIV] = &axg_fclk_div7_div.hw, + [CLKID_PCIE_PLL] = &axg_pcie_pll.hw, + [CLKID_PCIE_MUX] = &axg_pcie_mux.hw, + [CLKID_PCIE_REF] = &axg_pcie_ref.hw, + [CLKID_PCIE_CML_EN0] = &axg_pcie_cml_en0.hw, + [CLKID_PCIE_CML_EN1] = &axg_pcie_cml_en1.hw, + [CLKID_MIPI_ENABLE] = &axg_mipi_enable.hw, + [NR_CLKS] = NULL, }, .num = NR_CLKS, @@ -987,6 +1129,12 @@ static struct clk_regmap *const axg_clk_regmaps[] = { &axg_fclk_div4, &axg_fclk_div5, &axg_fclk_div7, + &axg_pcie_pll, + &axg_pcie_mux, + &axg_pcie_ref, + &axg_pcie_cml_en0, + &axg_pcie_cml_en1, + &axg_mipi_enable, }; static const struct of_device_id clkc_match_table[] = { diff --git a/drivers/clk/meson/axg.h b/drivers/clk/meson/axg.h index b421df6a7ea0..6e55ebd6c77d 100644 --- a/drivers/clk/meson/axg.h +++ b/drivers/clk/meson/axg.h @@ -16,6 +16,7 @@ * Register offsets from the data sheet must be multiplied by 4 before * adding them to the base address to get the right value. */ +#define HHI_MIPI_CNTL0 0x00 #define HHI_GP0_PLL_CNTL 0x40 #define HHI_GP0_PLL_CNTL2 0x44 #define HHI_GP0_PLL_CNTL3 0x48 @@ -127,8 +128,11 @@ #define CLKID_FCLK_DIV4_DIV 73 #define CLKID_FCLK_DIV5_DIV 74 #define CLKID_FCLK_DIV7_DIV 75 +#define CLKID_PCIE_PLL 76 +#define CLKID_PCIE_MUX 77 +#define CLKID_PCIE_REF 78 -#define NR_CLKS 76 +#define NR_CLKS 82 /* include the CLKIDs that have been made part of the DT binding */ #include <dt-bindings/clock/axg-clkc.h> -- 2.18.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] clk: meson-axg: add clocks required by pcie driver 2018-07-02 21:31 ` [PATCH v2 2/2] clk: meson-axg: add clocks required by pcie driver Yixun Lan @ 2018-07-03 9:24 ` Jerome Brunet 2018-07-03 10:17 ` Yixun Lan 0 siblings, 1 reply; 9+ messages in thread From: Jerome Brunet @ 2018-07-03 9:24 UTC (permalink / raw) To: Yixun Lan, Neil Armstrong Cc: Kevin Hilman, Carlo Caione, Michael Turquette, Stephen Boyd, Qiufang Dai, Jian Hu, Jianxin Qin, linux-clk, linux-amlogic, linux-arm-kernel, linux-kernel On Mon, 2018-07-02 at 21:31 +0000, Yixun Lan wrote: > Adding clocks for the pcie driver. Due to the ASIC design, > the pcie controller re-use part of the mipi clock logic, > so the mipi clock is also added. > > Tested-by: Jianxin Qin <jianxin.qin@amlogic.com> > Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> > --- > drivers/clk/meson/axg.c | 148 ++++++++++++++++++++++++++++++++++++++++ > drivers/clk/meson/axg.h | 6 +- > 2 files changed, 153 insertions(+), 1 deletion(-) > > [...] > + > +/* skip the partent 0, it's for debug only */ > +static u32 mux_table_pcie_ref[] = { 1 }; > +static const char * const pcie_ref_parent_names[] = { "pcie_mux" }; Dropped these symbols. > + > +static struct clk_regmap axg_pcie_ref = { > + .data = &(struct clk_regmap_mux_data){ > + .offset = HHI_PCIE_PLL_CNTL6, > + .mask = 0x1, > + .shift = 1, > + .table = mux_table_pcie_ref, Replaced with the table itself > + }, > + .hw.init = &(struct clk_init_data){ > + .name = "pcie_ref", > + .ops = &clk_regmap_mux_ops, > + .parent_names = pcie_ref_parent_names, > + .num_parents = ARRAY_SIZE(pcie_ref_parent_names), Replaced with the table itself and applied. Thx > + .flags = CLK_SET_RATE_PARENT, > + }, > +}; > + > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] clk: meson-axg: add clocks required by pcie driver 2018-07-03 9:24 ` Jerome Brunet @ 2018-07-03 10:17 ` Yixun Lan 2018-07-03 11:01 ` Jerome Brunet 0 siblings, 1 reply; 9+ messages in thread From: Yixun Lan @ 2018-07-03 10:17 UTC (permalink / raw) To: Jerome Brunet, Neil Armstrong Cc: yixun.lan, Kevin Hilman, Carlo Caione, Michael Turquette, Stephen Boyd, Qiufang Dai, Jian Hu, Jianxin Qin, linux-clk, linux-amlogic, linux-arm-kernel, linux-kernel Hi Jerome: On 07/03/18 17:24, Jerome Brunet wrote: > On Mon, 2018-07-02 at 21:31 +0000, Yixun Lan wrote: >> Adding clocks for the pcie driver. Due to the ASIC design, >> the pcie controller re-use part of the mipi clock logic, >> so the mipi clock is also added. >> >> Tested-by: Jianxin Qin <jianxin.qin@amlogic.com> >> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> >> --- >> drivers/clk/meson/axg.c | 148 ++++++++++++++++++++++++++++++++++++++++ >> drivers/clk/meson/axg.h | 6 +- >> 2 files changed, 153 insertions(+), 1 deletion(-) >> >> > > [...] > >> + >> +/* skip the partent 0, it's for debug only */ >> +static u32 mux_table_pcie_ref[] = { 1 }; >> +static const char * const pcie_ref_parent_names[] = { "pcie_mux" }; > > Dropped these symbols. > >> + >> +static struct clk_regmap axg_pcie_ref = { >> + .data = &(struct clk_regmap_mux_data){ >> + .offset = HHI_PCIE_PLL_CNTL6, >> + .mask = 0x1, >> + .shift = 1, >> + .table = mux_table_pcie_ref, > > Replaced with the table itself > >> + }, >> + .hw.init = &(struct clk_init_data){ >> + .name = "pcie_ref", >> + .ops = &clk_regmap_mux_ops, >> + .parent_names = pcie_ref_parent_names, >> + .num_parents = ARRAY_SIZE(pcie_ref_parent_names), > > Replaced with the table itself and applied. Thx > >> + .flags = CLK_SET_RATE_PARENT, >> + }, >> +}; >> + I'm seeing you already applied this patch, so would you like to fix/amend the patch for me, or want me send another patch version? thanks ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] clk: meson-axg: add clocks required by pcie driver 2018-07-03 10:17 ` Yixun Lan @ 2018-07-03 11:01 ` Jerome Brunet 2018-07-03 14:05 ` Yixun Lan 0 siblings, 1 reply; 9+ messages in thread From: Jerome Brunet @ 2018-07-03 11:01 UTC (permalink / raw) To: Yixun Lan, Neil Armstrong Cc: Kevin Hilman, Carlo Caione, Michael Turquette, Stephen Boyd, Qiufang Dai, Jian Hu, Jianxin Qin, linux-clk, linux-amlogic, linux-arm-kernel, linux-kernel On Tue, 2018-07-03 at 18:17 +0800, Yixun Lan wrote: > I'm seeing you already applied this patch, so would you like to > fix/amend the patch for me, or want me send another patch version? > > thanks It means that I amended your patch before applying it. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] clk: meson-axg: add clocks required by pcie driver 2018-07-03 11:01 ` Jerome Brunet @ 2018-07-03 14:05 ` Yixun Lan 2018-07-03 14:42 ` Jerome Brunet 0 siblings, 1 reply; 9+ messages in thread From: Yixun Lan @ 2018-07-03 14:05 UTC (permalink / raw) To: Jerome Brunet, Neil Armstrong Cc: yixun.lan, Kevin Hilman, Carlo Caione, Michael Turquette, Stephen Boyd, Qiufang Dai, Jian Hu, Jianxin Qin, linux-clk, linux-amlogic, linux-arm-kernel, linux-kernel Hi Jerome On 07/03/2018 07:01 PM, Jerome Brunet wrote: > On Tue, 2018-07-03 at 18:17 +0800, Yixun Lan wrote: >> I'm seeing you already applied this patch, so would you like to >> fix/amend the patch for me, or want me send another patch version? >> >> thanks > > It means that I amended your patch before applying it. > > . > Sorry, I'm asking.. because as I checked the clk-meson[1] tree, branch - next/drivers, it's not updated which it's still my original version.. Yixun [1] https://github.com/BayLibre/clk-meson/commit/cd1c7b71d14f197c404533c085b83817c08bf516#diff-c9327329286e3a07f2ddbe69649ec963R714 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] clk: meson-axg: add clocks required by pcie driver 2018-07-03 14:05 ` Yixun Lan @ 2018-07-03 14:42 ` Jerome Brunet 0 siblings, 0 replies; 9+ messages in thread From: Jerome Brunet @ 2018-07-03 14:42 UTC (permalink / raw) To: Yixun Lan, Neil Armstrong Cc: Kevin Hilman, Carlo Caione, Michael Turquette, Stephen Boyd, Qiufang Dai, Jian Hu, Jianxin Qin, linux-clk, linux-amlogic, linux-arm-kernel, linux-kernel On Tue, 2018-07-03 at 22:05 +0800, Yixun Lan wrote: > Sorry, I'm asking.. > > because as I checked the clk-meson[1] tree, branch - next/drivers, > it's not updated which it's still my original version.. > > Yixun Indeed. It pushed now. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-07-03 14:42 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-07-02 21:31 [PATCH v2 0/2] clk: meson-axg: add pcie related clocks Yixun Lan 2018-07-02 21:31 ` [PATCH v2 1/2] clk: meson-axg: add pcie and mipi clock bindings Yixun Lan 2018-07-03 9:20 ` Jerome Brunet 2018-07-02 21:31 ` [PATCH v2 2/2] clk: meson-axg: add clocks required by pcie driver Yixun Lan 2018-07-03 9:24 ` Jerome Brunet 2018-07-03 10:17 ` Yixun Lan 2018-07-03 11:01 ` Jerome Brunet 2018-07-03 14:05 ` Yixun Lan 2018-07-03 14:42 ` Jerome Brunet
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).