From: Tony Lindgren <tony@atomide.com>
To: Belisko Marek <marek.belisko@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-omap@vger.kernel.org,
"Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: omap5 fixing palmas IRQ_TYPE_NONE warning leads to gpadc timeouts
Date: Tue, 3 Jul 2018 01:45:16 -0700 [thread overview]
Message-ID: <20180703084516.GT112168@atomide.com> (raw)
In-Reply-To: <CAAfyv35bat+t6awL-VRigAoaUTySwOgZkQMs=W9mEKQ6VDW3FA@mail.gmail.com>
* Belisko Marek <marek.belisko@gmail.com> [180620 09:40]:
> Hello,
>
> I'm trying to fix warning (for omap5 board) produced by recent change
> to avoid using IRQ_TYPE_NONE like:
> [ 1.818666] WARNING: CPU: 1 PID: 778 at
> drivers/irqchip/irq-gic.c:1016 gic_irq_domain_translate+0x78/0x100
> [ 1.828839] Modules linked in:
>
> I did look to other commit which did update and without deep knowledge
> I just simply do this small change:
> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi
> b/arch/arm/boot/dts/omap5-board-common.dtsi
> index 218892b..ab2df8c 100644
> --- a/arch/arm/boot/dts/omap5-board-common.dtsi
> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
> @@ -393,7 +393,7 @@
>
> palmas: palmas@48 {
> compatible = "ti,palmas";
> - interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; /* IRQ_SYS_1N */
> + interrupts = <GIC_SPI 7 IRQ_TYPE_HIGH>; /* IRQ_SYS_1N */
> reg = <0x48>;
> interrupt-controller;
> #interrupt-cells = <2>;
>
> and it looks board boots fine. Only issue is that gpadc driver is not
> working (at least not getting interrupts at all ADC fails with
> timeout). I did look to gpadc driver and driver is not using
> interrupts defined in dts but request interrupt directly from palmas
> mfd module. Any ideas what needs to be changed to have gpadc again
> working with mentioned patch?
Can you try with IRQF_TRIGGER_HIGH added also to the flags to
regmap_add_irq_chip() in drivers/mfd/palmas.c?
Regards,
Tony
next prev parent reply other threads:[~2018-07-03 8:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 16:37 omap5 fixing palmas IRQ_TYPE_NONE warning leads to gpadc timeouts Belisko Marek
2018-07-03 8:45 ` Tony Lindgren [this message]
2018-07-03 18:31 ` Belisko Marek
2018-11-13 18:06 ` Tony Lindgren
2018-11-14 17:03 ` Tony Lindgren
2018-11-14 17:26 ` Tony Lindgren
2018-11-19 10:18 ` Peter Ujfalusi
2018-11-19 16:19 ` Tony Lindgren
2018-11-19 17:14 ` Tony Lindgren
2018-11-20 11:14 ` Jon Hunter
2018-11-23 16:48 ` Tony Lindgren
2018-11-26 9:36 ` Thierry Reding
2018-11-26 9:49 ` Peter Ujfalusi
2018-11-26 10:25 ` Thierry Reding
2018-11-26 19:32 ` Tony Lindgren
2018-11-26 20:17 ` Jon Hunter
2018-11-27 17:55 ` Tony Lindgren
2018-11-27 18:17 ` Tony Lindgren
2018-11-26 10:13 ` Jon Hunter
2018-11-20 12:22 ` Laxman Dewangan
2018-11-26 10:14 ` Thierry Reding
2018-11-26 19:14 ` Tony Lindgren
2018-11-26 19:19 ` Santosh Shilimkar
2018-11-27 18:03 ` Tony Lindgren
2018-11-20 7:36 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703084516.GT112168@atomide.com \
--to=tony@atomide.com \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).