[PATCH] net: fec: remove redundant variable 'inc'

[PATCH] net: fec: remove redundant variable 'inc'

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

Variable 'inc' is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
warning: variable 'inc' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/freescale/fec_ptp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index 36c2d7d6ee1b..7e892b1cbd3d 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -99,7 +99,6 @@ static int fec_ptp_enable_pps(struct fec_enet_private *fep, uint enable)
 {
 	unsigned long flags;
 	u32 val, tempval;
-	int inc;
 	struct timespec64 ts;
 	u64 ns;
 	val = 0;
@@ -114,7 +113,6 @@ static int fec_ptp_enable_pps(struct fec_enet_private *fep, uint enable)
 
 	fep->pps_channel = DEFAULT_PPS_CHANNEL;
 	fep->reload_period = PPS_OUPUT_RELOAD_PERIOD;
-	inc = fep->ptp_inc;
 
 	spin_lock_irqsave(&fep->tmreg_lock, flags);
 
-- 
2.17.1

RE: [PATCH] net: fec: remove redundant variable 'inc'

[Andy Duan]

From: Colin King <colin.king@canonical.com> Sent: 2018年7月4日 15:50
> Variable 'inc' is being assigned but is never used hence it is redundant and
> can be removed.
> 
> Cleans up clang warning:
> warning: variable 'inc' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks.

Acked-by: Fugang Duan <fugang.duan@nxp.com>

> ---
>  drivers/net/ethernet/freescale/fec_ptp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index 36c2d7d6ee1b..7e892b1cbd3d 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -99,7 +99,6 @@ static int fec_ptp_enable_pps(struct
> fec_enet_private *fep, uint enable)  {
>  	unsigned long flags;
>  	u32 val, tempval;
> -	int inc;
>  	struct timespec64 ts;
>  	u64 ns;
>  	val = 0;
> @@ -114,7 +113,6 @@ static int fec_ptp_enable_pps(struct
> fec_enet_private *fep, uint enable)
> 
>  	fep->pps_channel = DEFAULT_PPS_CHANNEL;
>  	fep->reload_period = PPS_OUPUT_RELOAD_PERIOD;
> -	inc = fep->ptp_inc;
> 
>  	spin_lock_irqsave(&fep->tmreg_lock, flags);
> 
> --
> 2.17.1

Re: [PATCH] net: fec: remove redundant variable 'inc'

[David Miller]

From: Colin King <colin.king@canonical.com>
Date: Wed,  4 Jul 2018 08:49:43 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable 'inc' is being assigned but is never used hence it is
> redundant and can be removed.
> 
> Cleans up clang warning:
> warning: variable 'inc' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.