* [PATCH] w1: fix w1_ds2438 documentation
@ 2018-07-04 9:02 manio
2018-07-04 9:10 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: manio @ 2018-07-04 9:02 UTC (permalink / raw)
To: linux-kernel, Evgeniy Polyakov, Greg Kroah-Hartman
Signed-off-by: Mariusz Bialonczyk <manio@skyboo.net>
---
Documentation/w1/slaves/w1_ds2438 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/w1/slaves/w1_ds2438
b/Documentation/w1/slaves/w1_ds2438
index b99f3674c5b4..e64f65a09387 100644
--- a/Documentation/w1/slaves/w1_ds2438
+++ b/Documentation/w1/slaves/w1_ds2438
@@ -60,4 +60,4 @@ vad: general purpose A/D input (VAD)
vdd: battery input (VDD)
After the voltage conversion the value is returned as decimal ASCII.
-Note: The value is in mV, so to get a volts the value has to be divided
by 10.
+Note: To get a volts the value has to be divided by 100.
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] w1: fix w1_ds2438 documentation
2018-07-04 9:02 [PATCH] w1: fix w1_ds2438 documentation manio
@ 2018-07-04 9:10 ` Greg Kroah-Hartman
2018-07-05 4:51 ` [PATCH v2] " Mariusz Bialonczyk
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-04 9:10 UTC (permalink / raw)
To: manio; +Cc: linux-kernel, Evgeniy Polyakov
On Wed, Jul 04, 2018 at 11:02:00AM +0200, manio wrote:
> Signed-off-by: Mariusz Bialonczyk <manio@skyboo.net>
I need a changelog text please.
> ---
> Documentation/w1/slaves/w1_ds2438 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/w1/slaves/w1_ds2438
> b/Documentation/w1/slaves/w1_ds2438
> index b99f3674c5b4..e64f65a09387 100644
> --- a/Documentation/w1/slaves/w1_ds2438
> +++ b/Documentation/w1/slaves/w1_ds2438
> @@ -60,4 +60,4 @@ vad: general purpose A/D input (VAD)
> vdd: battery input (VDD)
>
> After the voltage conversion the value is returned as decimal ASCII.
> -Note: The value is in mV, so to get a volts the value has to be divided by
> 10.
> +Note: To get a volts the value has to be divided by 100.
This does not look correct at all, are you sure about it?
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] w1: fix w1_ds2438 documentation
2018-07-04 9:10 ` Greg Kroah-Hartman
@ 2018-07-05 4:51 ` Mariusz Bialonczyk
0 siblings, 0 replies; 3+ messages in thread
From: Mariusz Bialonczyk @ 2018-07-05 4:51 UTC (permalink / raw)
To: linux-kernel, Evgeniy Polyakov, Greg Kroah-Hartman; +Cc: Mariusz Bialonczyk
The previous documentation was wrongly stating about the order
of magnitude of CONVERT_V result files contents (vad, vdd).
This commit is correcting this.
Reported-by: Adam Stolarczyk <adam@stolarczyk.net.pl>
Signed-off-by: Mariusz Bialonczyk <manio@skyboo.net>
---
Resending as V2 because it was malformed by mail mail app recently.
I also added the Reported-by line and added a commit message
to describe the problem (to comply with Greg's review points).
Documentation/w1/slaves/w1_ds2438 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/w1/slaves/w1_ds2438 b/Documentation/w1/slaves/w1_ds2438
index b99f3674c5b4..e64f65a09387 100644
--- a/Documentation/w1/slaves/w1_ds2438
+++ b/Documentation/w1/slaves/w1_ds2438
@@ -60,4 +60,4 @@ vad: general purpose A/D input (VAD)
vdd: battery input (VDD)
After the voltage conversion the value is returned as decimal ASCII.
-Note: The value is in mV, so to get a volts the value has to be divided by 10.
+Note: To get a volts the value has to be divided by 100.
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-05 4:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-04 9:02 [PATCH] w1: fix w1_ds2438 documentation manio
2018-07-04 9:10 ` Greg Kroah-Hartman
2018-07-05 4:51 ` [PATCH v2] " Mariusz Bialonczyk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).