linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sample/vfio-mdev: Change return type to vm_fault_t
@ 2018-07-04 15:30 Souptick Joarder
  2018-07-05 19:44 ` Alex Williamson
  0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2018-07-04 15:30 UTC (permalink / raw)
  To: willy, kwankhede
  Cc: kvm, linux-kernel, svptas.linux, brajeswar.linux,
	sabyasachi.linux, ajitn.linux

convert mbochs_region_vm_fault and mbochs_dmabuf_vm_fault
to return vm_fault_t type.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 samples/vfio-mdev/mbochs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c
index 2960e26..7743fbc 100644
--- a/samples/vfio-mdev/mbochs.c
+++ b/samples/vfio-mdev/mbochs.c
@@ -657,7 +657,7 @@ static void mbochs_put_pages(struct mdev_state *mdev_state)
 	dev_dbg(dev, "%s: %d pages released\n", __func__, count);
 }
 
-static int mbochs_region_vm_fault(struct vm_fault *vmf)
+static vm_fault_t mbochs_region_vm_fault(struct vm_fault *vmf)
 {
 	struct vm_area_struct *vma = vmf->vma;
 	struct mdev_state *mdev_state = vma->vm_private_data;
@@ -695,7 +695,7 @@ static int mbochs_mmap(struct mdev_device *mdev, struct vm_area_struct *vma)
 	return 0;
 }
 
-static int mbochs_dmabuf_vm_fault(struct vm_fault *vmf)
+static vm_fault_t mbochs_dmabuf_vm_fault(struct vm_fault *vmf)
 {
 	struct vm_area_struct *vma = vmf->vma;
 	struct mbochs_dmabuf *dmabuf = vma->vm_private_data;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] sample/vfio-mdev: Change return type to vm_fault_t
  2018-07-04 15:30 [PATCH] sample/vfio-mdev: Change return type to vm_fault_t Souptick Joarder
@ 2018-07-05 19:44 ` Alex Williamson
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2018-07-05 19:44 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: willy, kwankhede, kvm, linux-kernel, svptas.linux,
	brajeswar.linux, sabyasachi.linux, ajitn.linux

On Wed, 4 Jul 2018 21:00:14 +0530
Souptick Joarder <jrdr.linux@gmail.com> wrote:

> convert mbochs_region_vm_fault and mbochs_dmabuf_vm_fault
> to return vm_fault_t type.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
>  samples/vfio-mdev/mbochs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c
> index 2960e26..7743fbc 100644
> --- a/samples/vfio-mdev/mbochs.c
> +++ b/samples/vfio-mdev/mbochs.c
> @@ -657,7 +657,7 @@ static void mbochs_put_pages(struct mdev_state *mdev_state)
>  	dev_dbg(dev, "%s: %d pages released\n", __func__, count);
>  }
>  
> -static int mbochs_region_vm_fault(struct vm_fault *vmf)
> +static vm_fault_t mbochs_region_vm_fault(struct vm_fault *vmf)
>  {
>  	struct vm_area_struct *vma = vmf->vma;
>  	struct mdev_state *mdev_state = vma->vm_private_data;
> @@ -695,7 +695,7 @@ static int mbochs_mmap(struct mdev_device *mdev, struct vm_area_struct *vma)
>  	return 0;
>  }
>  
> -static int mbochs_dmabuf_vm_fault(struct vm_fault *vmf)
> +static vm_fault_t mbochs_dmabuf_vm_fault(struct vm_fault *vmf)
>  {
>  	struct vm_area_struct *vma = vmf->vma;
>  	struct mbochs_dmabuf *dmabuf = vma->vm_private_data;


Looks good to me, I'll include this in my vfio for-linus branch for
v4.18. Thanks,

Alex

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-05 19:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-04 15:30 [PATCH] sample/vfio-mdev: Change return type to vm_fault_t Souptick Joarder
2018-07-05 19:44 ` Alex Williamson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).