From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lukasz Tyrala <ltyrala@cadence.com>,
Bartosz Folta <bfolta@cadence.com>
Subject: Re: [PATCH 09/15] Introduce Cadence USBSSP DRD Driver - added debugfs files.
Date: Thu, 5 Jul 2018 17:13:19 +0200 [thread overview]
Message-ID: <20180705151319.GB10795@kroah.com> (raw)
In-Reply-To: <BYAPR07MB4709412C63D2D9947F8EEFF4DD400@BYAPR07MB4709.namprd07.prod.outlook.com>
On Thu, Jul 05, 2018 at 09:44:27AM +0000, Pawel Laszczak wrote:
> > > Signed-off-by: Laszczak Pawel <pawell@cadence.com>
> > > ---
> >
> > Again for all of these, you need a changelog text.
> >
> > > drivers/usb/usbssp/gadget-debugfs.c | 514
> > ++++++++++++++++++++++++++++
> > > drivers/usb/usbssp/gadget-debugfs.h | 137 ++++++++
> > > 2 files changed, 651 insertions(+)
> > > create mode 100644 drivers/usb/usbssp/gadget-debugfs.c
> > > create mode 100644 drivers/usb/usbssp/gadget-debugfs.h
> > >
> > > diff --git a/drivers/usb/usbssp/gadget-debugfs.c
> > b/drivers/usb/usbssp/gadget-debugfs.c
> > > new file mode 100644
> > > index 000000000000..c0d1e96728e6
> > > --- /dev/null
> > > +++ b/drivers/usb/usbssp/gadget-debugfs.c
> > > @@ -0,0 +1,514 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * USBSSP device controller driver
> > > + *
> > > + * Copyright (C) 2018 Cadence.
> > > + *
> > > + * Author: Pawel Laszczak
> > > + * Some code borrowed from the Linux XHCI driver.
> >
> > What code was borrowed? Please acknowledge that copyright.
>
> USBSSP controller is very similar to XHCI controller and
> is mostly compliance with XHCI specification.
> In result, driver for device mode based on
> drivers/usb/host/xhci* driver.
>
> Especially xhci.c, xhci-ring.c, xhci-mem.c , xhci-debugfs.c
> and xhci-trace.h was re-used. By borrowed I means that these
> files have been taken from xhci driver and have been adopted
> in such way that it can be use for the device side.
> Probably this sentence should looks like:
> " A lot of code based on Linux XHCI driver" ?
Be specific, just like you said so here. And include the copyright
ownership of that code please, because it is relevant here.
> You know, the most of algorithm for handling transfer and
> memory management are the same as for XHCI driver.
>
> Because the USB gadget API in kernel completely different
> from Host USB API, so files had to been changed very much.
>
> What do you think by "Please acknowledge that copyright" ?
>
> "
> The standard header for xhci driver looks like:
> // SPDX-License-Identifier: GPL-2.0
> /*
> * xHCI host controller driver PCI Bus Glue.
> *
> * Copyright (C) 2008 Intel Corp.
> *
> * Author: Sarah Sharp
> * Some code borrowed from the Linux EHCI driver.
> */
> "
> Should I add In my header:
> Copyright (C) 2018 Cadence.
> Copyright (C) 2008 Intel Corp.
>
> or something like this:
> ....
> A lot of code based on Linux XHCI driver
> Origin: Copyright (C) 2008 Intel Corp
Yes, that would be good.
thanks,
greg k-h
next prev parent reply other threads:[~2018-07-05 15:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 19:57 Introduced new Cadence USBSSP DRD Driver Pawel Laszczak
2018-07-03 19:57 ` [PATCH 01/15] Introduce Cadence USBSSP DRD Driver - added gadget.c file Pawel Laszczak
2018-07-04 9:13 ` Greg Kroah-Hartman
2018-07-05 10:15 ` Pawel Laszczak
2018-07-05 15:14 ` Greg Kroah-Hartman
2018-07-03 19:57 ` [PATCH 02/15] Introduce Cadence USBSSP DRD driver - added gadget-mem.c Pawel Laszczak
2018-07-03 19:57 ` [PATCH 03/15] Introduce Cadence USBSSP DRD Driver - added gadget-ring.c file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 04/15] Introduce Cadence USBSSP DRD Driver - added gadget.h file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 05/15] Introduce Cadence USBSSP DRD Driver - added gadget-port.c file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 06/15] Introduce Cadence USBSSP DRD Driver - added gadget-ep0 file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 07/15] Introduce Cadence USBSSP DRD Driver - added gadget-if.c Driver implements interface between gadget drivers and USBSSP device driver Pawel Laszczak
2018-07-03 19:57 ` [PATCH 08/15] Introduce Cadence USBSSP DRD driver - added gadget-ext-caps.h Pawel Laszczak
2018-07-03 19:57 ` [PATCH 09/15] Introduce Cadence USBSSP DRD Driver - added debugfs files Pawel Laszczak
2018-07-04 9:15 ` Greg Kroah-Hartman
2018-07-05 9:44 ` Pawel Laszczak
2018-07-05 15:13 ` Greg Kroah-Hartman [this message]
2018-07-03 19:57 ` [PATCH 10/15] Introduce Cadence USBSSP DRD Driver - added trace files Pawel Laszczak
2018-07-03 19:57 ` [PATCH 11/15] Introduce Cadence USBSSP DRD driver - added gadget-dbg.c file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 12/15] Introduce Cadence USBSSP DRD Driver - added usbssp-plat.c file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 13/15] Introduce Cadence USBSSP DRD Driver - added usbssp-pci-of-wrap.c file This file implements wrapper between PCI adn platform driver Pawel Laszczak
2018-07-03 19:57 ` [PATCH 14/15] Introduce Cadence USBSSP DRD Driver - added Kconfig and Makefile files Pawel Laszczak
2018-07-03 20:30 ` Randy Dunlap
2018-07-03 19:57 ` [PATCH 15/15] Introduce Cadence USBSSP DRD Driver - added USBSSP in Makefile and Kconfig files Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705151319.GB10795@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=bfolta@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ltyrala@cadence.com \
--cc=pawell@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).