From: Pawel Laszczak <pawell@cadence.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lukasz Tyrala <ltyrala@cadence.com>,
Bartosz Folta <bfolta@cadence.com>
Subject: RE: [PATCH 01/15] Introduce Cadence USBSSP DRD Driver - added gadget.c file.
Date: Thu, 5 Jul 2018 10:15:04 +0000 [thread overview]
Message-ID: <BYAPR07MB4709E76774739A793CACE0D7DD400@BYAPR07MB4709.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20180704091342.GA25518@kroah.com>
> On Tue, Jul 03, 2018 at 08:57:45PM +0100, Pawel Laszczak wrote:
> > From: Laszczak Pawel <pawell.cadence.com>
> >
> > Signed-off-by: Laszczak Pawel <pawell@cadence.com>
> > ---
>
> I can't take patches without any changelog text at all, sorry.
>
> Also, your subject lines need work, look at how all other usb patches are
> written, your long prefix is not really helping out here.
>
> > drivers/usb/usbssp/gadget.c | 2082
> > +++++++++++++++++++++++++++++++++++
> > 1 file changed, 2082 insertions(+)
> > create mode 100644 drivers/usb/usbssp/gadget.c
>
>
> Just splitting the driver up by file is hard to review, as you are just dumping
> individual files on us, not functionality, and we can not review anything until
> all of them are added. Can you break this up into logical chunks? Make
> these in a way that is easy to review, would you want to review this patch
> series in this way?
It's quite large driver and I thought that this form will be better and faster to review.
I didn't want to prepare too much patches.
I will prepare new patch set and I will tray to split it into logical chunk.
Thanks,
Pawel Laszczak
next prev parent reply other threads:[~2018-07-05 10:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 19:57 Introduced new Cadence USBSSP DRD Driver Pawel Laszczak
2018-07-03 19:57 ` [PATCH 01/15] Introduce Cadence USBSSP DRD Driver - added gadget.c file Pawel Laszczak
2018-07-04 9:13 ` Greg Kroah-Hartman
2018-07-05 10:15 ` Pawel Laszczak [this message]
2018-07-05 15:14 ` Greg Kroah-Hartman
2018-07-03 19:57 ` [PATCH 02/15] Introduce Cadence USBSSP DRD driver - added gadget-mem.c Pawel Laszczak
2018-07-03 19:57 ` [PATCH 03/15] Introduce Cadence USBSSP DRD Driver - added gadget-ring.c file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 04/15] Introduce Cadence USBSSP DRD Driver - added gadget.h file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 05/15] Introduce Cadence USBSSP DRD Driver - added gadget-port.c file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 06/15] Introduce Cadence USBSSP DRD Driver - added gadget-ep0 file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 07/15] Introduce Cadence USBSSP DRD Driver - added gadget-if.c Driver implements interface between gadget drivers and USBSSP device driver Pawel Laszczak
2018-07-03 19:57 ` [PATCH 08/15] Introduce Cadence USBSSP DRD driver - added gadget-ext-caps.h Pawel Laszczak
2018-07-03 19:57 ` [PATCH 09/15] Introduce Cadence USBSSP DRD Driver - added debugfs files Pawel Laszczak
2018-07-04 9:15 ` Greg Kroah-Hartman
2018-07-05 9:44 ` Pawel Laszczak
2018-07-05 15:13 ` Greg Kroah-Hartman
2018-07-03 19:57 ` [PATCH 10/15] Introduce Cadence USBSSP DRD Driver - added trace files Pawel Laszczak
2018-07-03 19:57 ` [PATCH 11/15] Introduce Cadence USBSSP DRD driver - added gadget-dbg.c file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 12/15] Introduce Cadence USBSSP DRD Driver - added usbssp-plat.c file Pawel Laszczak
2018-07-03 19:57 ` [PATCH 13/15] Introduce Cadence USBSSP DRD Driver - added usbssp-pci-of-wrap.c file This file implements wrapper between PCI adn platform driver Pawel Laszczak
2018-07-03 19:57 ` [PATCH 14/15] Introduce Cadence USBSSP DRD Driver - added Kconfig and Makefile files Pawel Laszczak
2018-07-03 20:30 ` Randy Dunlap
2018-07-03 19:57 ` [PATCH 15/15] Introduce Cadence USBSSP DRD Driver - added USBSSP in Makefile and Kconfig files Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR07MB4709E76774739A793CACE0D7DD400@BYAPR07MB4709.namprd07.prod.outlook.com \
--to=pawell@cadence.com \
--cc=balbi@kernel.org \
--cc=bfolta@cadence.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ltyrala@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).