* [PATCH] [net-next] devlink: fix incorrect return statement
@ 2018-07-06 12:58 Arnd Bergmann
2018-07-07 11:07 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-07-06 12:58 UTC (permalink / raw)
To: Jiri Pirko, David S. Miller
Cc: Arnd Bergmann, Arkadi Sharshevsky, Moshe Shemesh, David Ahern,
netdev, linux-kernel
A newly added dummy helper function tries to return a failure from a "void"
function:
In file included from include/net/dsa.h:24,
from arch/arm/plat-orion/common.c:21:
include/net/devlink.h: In function 'devlink_param_value_changed':
include/net/devlink.h:771:9: error: 'return' with a value, in function returning void [-Werror]
return -EOPNOTSUPP;
This fixes it by removing the bogus statement.
Fixes: ea601e170988 ("devlink: Add devlink notifications support for params")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
include/net/devlink.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/net/devlink.h b/include/net/devlink.h
index 8ed571385626..f67c29cede15 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -768,7 +768,6 @@ devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
static inline void
devlink_param_value_changed(struct devlink *devlink, u32 param_id)
{
- return -EOPNOTSUPP;
}
#endif
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [net-next] devlink: fix incorrect return statement
2018-07-06 12:58 [PATCH] [net-next] devlink: fix incorrect return statement Arnd Bergmann
@ 2018-07-07 11:07 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-07-07 11:07 UTC (permalink / raw)
To: arnd; +Cc: jiri, arkadis, moshe, dsahern, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 6 Jul 2018 14:58:51 +0200
> A newly added dummy helper function tries to return a failure from a "void"
> function:
>
> In file included from include/net/dsa.h:24,
> from arch/arm/plat-orion/common.c:21:
> include/net/devlink.h: In function 'devlink_param_value_changed':
> include/net/devlink.h:771:9: error: 'return' with a value, in function returning void [-Werror]
> return -EOPNOTSUPP;
>
> This fixes it by removing the bogus statement.
>
> Fixes: ea601e170988 ("devlink: Add devlink notifications support for params")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-07 11:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-06 12:58 [PATCH] [net-next] devlink: fix incorrect return statement Arnd Bergmann
2018-07-07 11:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).