From: Darren Hart <dvhart@infradead.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "Lee, Chun-Yi" <jlee@suse.com>,
Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: acer-wmi: mark expected switch fall-throughs
Date: Fri, 6 Jul 2018 16:15:42 -0700 [thread overview]
Message-ID: <20180706231542.GB3041@fury> (raw)
In-Reply-To: <20180705204221.GA11336@embeddedor.com>
On Thu, Jul 05, 2018 at 03:42:21PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Warning level 2 was used: -Wimplicit-fallthrough=2
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/platform/x86/acer-wmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 8952173..114b028 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -1018,6 +1018,7 @@ static acpi_status WMID_get_u32(u32 *value, u32 cap)
> *value = tmp & 0x1;
> return 0;
> }
> + /* else: fall through */
> default:
> return AE_ERROR;
> }
> @@ -1344,6 +1345,7 @@ static acpi_status get_u32(u32 *value, u32 cap)
> status = AMW0_get_u32(value, cap);
> break;
> }
> + /* else: fall through */
> case ACER_WMID:
> status = WMID_get_u32(value, cap);
> break;
> @@ -1386,6 +1388,7 @@ static acpi_status set_u32(u32 value, u32 cap)
>
> return AMW0_set_u32(value, cap);
> }
> + /* else: fall through */
I suspect you are correct, bu these last two weren't obviously intentional to
me. Has this seen any testing?
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-07-06 23:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 20:42 [PATCH] platform/x86: acer-wmi: mark expected switch fall-throughs Gustavo A. R. Silva
2018-07-06 23:15 ` Darren Hart [this message]
2019-05-08 16:49 [PATCH] platform/x86: acer-wmi: Mark " Gustavo A. R. Silva
2019-05-08 23:06 ` Darren Hart
2019-05-09 1:48 ` Gustavo A. R. Silva
2019-06-29 13:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706231542.GB3041@fury \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=gustavo@embeddedor.com \
--cc=jlee@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).