From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Darren Hart <dvhart@infradead.org>,
"Lee, Chun-Yi" <jlee@suse.com>,
Andy Shevchenko <andy@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] platform/x86: acer-wmi: Mark expected switch fall-throughs
Date: Sat, 29 Jun 2019 16:13:16 +0300 [thread overview]
Message-ID: <CAHp75Vf52tq9UWx9sr3VihZSddQMoEcqeXWzW4y6CJFq7cgH0w@mail.gmail.com> (raw)
In-Reply-To: <b1869c7f-0927-9a30-a195-a188719c748c@embeddedor.com>
On Thu, May 9, 2019 at 4:48 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Commit 5c742b45dd5fbbb6cf74d3378341704f4b23c5e8 mentions that "This was fixed
> in acer_acpi some time ago, but I forgot to port the patch over to acer-wmi
> when it was merged." Notice that this driver (acer-wmi) is based on the
> no-longer existing acer_acpi driver. But after googling for a while I could
> found the fix the original author talks about:
>
> https://repo.or.cz/acer_acpi.git/commitdiff/74c08a38875ffa9989c3100947650ac8a388c189
>
> So, the fix is indeed similar and contains the same fall-throughs from case
> ACER_AMW0_V2 to case ACER_WMID in both functions get_u32() and set_u32().
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-06-29 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 16:49 [PATCH] platform/x86: acer-wmi: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-05-08 23:06 ` Darren Hart
2019-05-09 1:48 ` Gustavo A. R. Silva
2019-06-29 13:13 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-05 20:42 [PATCH] platform/x86: acer-wmi: mark " Gustavo A. R. Silva
2018-07-06 23:15 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf52tq9UWx9sr3VihZSddQMoEcqeXWzW4y6CJFq7cgH0w@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=gustavo@embeddedor.com \
--cc=jlee@suse.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).